From nobody@FreeBSD.org  Sat Dec  8 05:33:12 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EB9C116A417
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  8 Dec 2007 05:33:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id DBC2A13C458
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  8 Dec 2007 05:33:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lB85X4oi019926
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 8 Dec 2007 05:33:04 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id lB85X4hI019925;
	Sat, 8 Dec 2007 05:33:04 GMT
	(envelope-from nobody)
Message-Id: <200712080533.lB85X4hI019925@www.freebsd.org>
Date: Sat, 8 Dec 2007 05:33:04 GMT
From: Weongyo Jeong <weongyo.jeong@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [ndis] a trivial fix when ndis sets `ndis_resource_list' structure.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         118493
>Category:       kern
>Synopsis:       [ndis] [patch] a trivial fix when ndis sets `ndis_resource_list' structure.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 08 05:40:01 UTC 2007
>Closed-Date:    Sat Feb 26 11:53:16 UTC 2011
>Last-Modified:  Sat Feb 26 12:00:26 UTC 2011
>Originator:     Weongyo Jeong
>Release:        FreeBSD-CURRENT
>Organization:
CDNetworks
>Environment:
>Description:
When NDIS try to set `ndis_resource_list' structure in 
ndis_convert_res() function, handling SYS_RES_MEMORY is weird because it sets

  prd->u.cprd_port.cprd_start.np_quad

not

  prd->u.cprd_mem.cprd_start.np_quad

This difference does not make any problems but made me confusing to read codes.
>How-To-Repeat:

>Fix:
Index: kern_ndis.c
===================================================================
RCS file: /data/cvs/src/sys/compat/ndis/kern_ndis.c,v
retrieving revision 1.96
diff -u -r1.96 kern_ndis.c
--- kern_ndis.c 10 Jun 2007 04:40:13 -0000      1.96
+++ kern_ndis.c 8 Dec 2007 05:05:43 -0000
@@ -644,9 +644,9 @@
                                    CM_RESOURCE_MEMORY_READ_WRITE;
                                prd->cprd_sharedisp =
                                    CmResourceShareDeviceExclusive;
-                               prd->u.cprd_port.cprd_start.np_quad =
+                               prd->u.cprd_mem.cprd_start.np_quad =
                                    brle->start;
-                               prd->u.cprd_port.cprd_len = brle->count;
+                               prd->u.cprd_mem.cprd_len = brle->count;
                                break;
                        case SYS_RES_IRQ:
                                prd->cprd_type = CmResourceTypeInterrupt;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->weongyo 
Responsible-Changed-By: thompsa 
Responsible-Changed-When: Fri Dec 28 01:11:52 UTC 2007 
Responsible-Changed-Why:  
Pass back to the new committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118493 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118493: commit references a PR
Date: Wed, 23 Feb 2011 21:45:35 +0000 (UTC)

 Author: brucec
 Date: Wed Feb 23 21:45:28 2011
 New Revision: 218985
 URL: http://svn.freebsd.org/changeset/base/218985
 
 Log:
   Use the cprd_mem field when setting the start and length for a memory
   resource - the layout of cprd_port is identical but using cprd_mem
   makes the code easier to understand.
   
   PR:		kern/118493
   Submitted by:	Weongyo Jeong <weongyo.jeong at gmail.com>
   MFC after:	3 days
 
 Modified:
   head/sys/compat/ndis/kern_ndis.c
 
 Modified: head/sys/compat/ndis/kern_ndis.c
 ==============================================================================
 --- head/sys/compat/ndis/kern_ndis.c	Wed Feb 23 21:17:38 2011	(r218984)
 +++ head/sys/compat/ndis/kern_ndis.c	Wed Feb 23 21:45:28 2011	(r218985)
 @@ -591,9 +591,9 @@ ndis_convert_res(arg)
  				    CM_RESOURCE_MEMORY_READ_WRITE;
  				prd->cprd_sharedisp =
  				    CmResourceShareDeviceExclusive;
 -				prd->u.cprd_port.cprd_start.np_quad =
 +				prd->u.cprd_mem.cprd_start.np_quad =
  				    brle->start;
 -				prd->u.cprd_port.cprd_len = brle->count;
 +				prd->u.cprd_mem.cprd_len = brle->count;
  				break;
  			case SYS_RES_IRQ:
  				prd->cprd_type = CmResourceTypeInterrupt;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: brucec 
State-Changed-When: Wed Feb 23 21:51:06 UTC 2011 
State-Changed-Why:  
Committed to HEAD. 


Responsible-Changed-From-To: weongyo->brucec 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Wed Feb 23 21:51:06 UTC 2011 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118493 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118493: commit references a PR
Date: Sat, 26 Feb 2011 11:46:14 +0000 (UTC)

 Author: brucec
 Date: Sat Feb 26 11:46:06 2011
 New Revision: 219051
 URL: http://svn.freebsd.org/changeset/base/219051
 
 Log:
   MFC r218985:
   
   Use the cprd_mem field when setting the start and length for a memory
   resource - the layout of cprd_port is identical but using cprd_mem
   makes the code easier to understand.
   
   PR:           kern/118493
   Submitted by: Weongyo Jeong <weongyo.jeong at gmail.com>
 
 Modified:
   stable/8/sys/compat/ndis/kern_ndis.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
 
 Modified: stable/8/sys/compat/ndis/kern_ndis.c
 ==============================================================================
 --- stable/8/sys/compat/ndis/kern_ndis.c	Sat Feb 26 11:20:51 2011	(r219050)
 +++ stable/8/sys/compat/ndis/kern_ndis.c	Sat Feb 26 11:46:06 2011	(r219051)
 @@ -591,9 +591,9 @@ ndis_convert_res(arg)
  				    CM_RESOURCE_MEMORY_READ_WRITE;
  				prd->cprd_sharedisp =
  				    CmResourceShareDeviceExclusive;
 -				prd->u.cprd_port.cprd_start.np_quad =
 +				prd->u.cprd_mem.cprd_start.np_quad =
  				    brle->start;
 -				prd->u.cprd_port.cprd_len = brle->count;
 +				prd->u.cprd_mem.cprd_len = brle->count;
  				break;
  			case SYS_RES_IRQ:
  				prd->cprd_type = CmResourceTypeInterrupt;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brucec 
State-Changed-When: Sat Feb 26 11:52:57 UTC 2011 
State-Changed-Why:  
Merged to stable/7 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118493 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118493: commit references a PR
Date: Sat, 26 Feb 2011 11:52:42 +0000 (UTC)

 Author: brucec
 Date: Sat Feb 26 11:52:34 2011
 New Revision: 219052
 URL: http://svn.freebsd.org/changeset/base/219052
 
 Log:
   MFC r218985:
   
   Use the cprd_mem field when setting the start and length for a memory
   resource - the layout of cprd_port is identical but using cprd_mem
   makes the code easier to understand.
   
   PR:           kern/118493
   Submitted by: Weongyo Jeong <weongyo.jeong at gmail.com>
 
 Modified:
   stable/7/sys/compat/ndis/kern_ndis.c
 Directory Properties:
   stable/7/sys/   (props changed)
   stable/7/sys/cddl/contrib/opensolaris/   (props changed)
   stable/7/sys/contrib/dev/acpica/   (props changed)
   stable/7/sys/contrib/pf/   (props changed)
 
 Modified: stable/7/sys/compat/ndis/kern_ndis.c
 ==============================================================================
 --- stable/7/sys/compat/ndis/kern_ndis.c	Sat Feb 26 11:46:06 2011	(r219051)
 +++ stable/7/sys/compat/ndis/kern_ndis.c	Sat Feb 26 11:52:34 2011	(r219052)
 @@ -642,9 +642,9 @@ ndis_convert_res(arg)
  				    CM_RESOURCE_MEMORY_READ_WRITE;
  				prd->cprd_sharedisp =
  				    CmResourceShareDeviceExclusive;
 -				prd->u.cprd_port.cprd_start.np_quad =
 +				prd->u.cprd_mem.cprd_start.np_quad =
  				    brle->start;
 -				prd->u.cprd_port.cprd_len = brle->count;
 +				prd->u.cprd_mem.cprd_len = brle->count;
  				break;
  			case SYS_RES_IRQ:
  				prd->cprd_type = CmResourceTypeInterrupt;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
