From nobody@FreeBSD.org  Sat Dec  1 08:06:09 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0E81816A419
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  1 Dec 2007 08:06:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0734413C455
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  1 Dec 2007 08:06:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lB185t58061085
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 1 Dec 2007 08:05:55 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id lB185tQN061084;
	Sat, 1 Dec 2007 08:05:55 GMT
	(envelope-from nobody)
Message-Id: <200712010805.lB185tQN061084@www.freebsd.org>
Date: Sat, 1 Dec 2007 08:05:55 GMT
From: Weongyo Jeong <weongyo.jeong@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] ndis - a incorrect definition of struct ndis_wlan_bssid_ex
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         118369
>Category:       kern
>Synopsis:       [ndis] [patch] ndis - a incorrect definition of struct ndis_wlan_bssid_ex
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    thompsa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 01 08:10:05 UTC 2007
>Closed-Date:    Sun Aug 10 05:58:21 UTC 2008
>Last-Modified:  Sun Aug 10 06:00:09 UTC 2008
>Originator:     Weongyo Jeong
>Release:        FreeBSD-CURRENT
>Organization:
CDNetworks
>Environment:
>Description:
Following http://msdn2.microsoft.com/en-us/library/ms799391.aspx, the last element of `struct _NDIS_WLAN_BSSID_EX' should `UCHAR  IEs[1]' but in FreeBSD, it is defined as `uint32_t nwbx_ies[1]'.



>How-To-Repeat:

>Fix:
Index: ndis_var.h
===================================================================
RCS file: /data/ndis/ndis/ndis_var.h,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 ndis_var.h
--- ndis_var.h  1 Dec 2007 06:23:11 -0000       1.1.1.1
+++ ndis_var.h  1 Dec 2007 06:45:05 -0000
@@ -466,7 +466,7 @@
        uint32_t                nwbx_netinfra;
        ndis_80211_rates_ex     nwbx_supportedrates;
        uint32_t                nwbx_ielen;
-       uint32_t                nwbx_ies[1];
+       uint8_t                 nwbx_ies[1];
 };
 
 typedef struct ndis_wlan_bssid_ex ndis_wlan_bssid_ex;


Patch attached with submission follows:

Index: ndis_var.h
===================================================================
RCS file: /data/ndis/ndis/ndis_var.h,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 ndis_var.h
--- ndis_var.h	1 Dec 2007 06:23:11 -0000	1.1.1.1
+++ ndis_var.h	1 Dec 2007 06:45:05 -0000
@@ -466,7 +466,7 @@
 	uint32_t		nwbx_netinfra;
 	ndis_80211_rates_ex	nwbx_supportedrates;
 	uint32_t		nwbx_ielen;
-	uint32_t		nwbx_ies[1];
+	uint8_t			nwbx_ies[1];
 };
 
 typedef struct ndis_wlan_bssid_ex ndis_wlan_bssid_ex;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->thompsa 
Responsible-Changed-By: thompsa 
Responsible-Changed-When: Sat Dec 1 10:44:54 UTC 2007 
Responsible-Changed-Why:  
I'll take care of this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118369 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118369: commit references a PR
Date: Sun,  2 Dec 2007 04:04:49 +0000 (UTC)

 thompsa     2007-12-02 04:04:42 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/compat/ndis      ndis_var.h 
   Log:
   Correct the nwbx_ies field type in struct ndis_wlan_bssid_ex.
   
   PR:             kern/118369
   Submitted by:   Weongyo Jeong
   
   Revision  Changes    Path
   1.48      +1 -1      src/sys/compat/ndis/ndis_var.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: thompsa 
State-Changed-When: Sun Dec 2 04:33:56 UTC 2007 
State-Changed-Why:  
Commited, will MFC after a few weeks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118369 
State-Changed-From-To: patched->closed 
State-Changed-By: thompsa 
State-Changed-When: Sun Aug 10 05:58:04 UTC 2008 
State-Changed-Why:  
MFC complete. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118369 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118369: commit references a PR
Date: Sun, 10 Aug 2008 05:57:32 +0000 (UTC)

 thompsa     2008-08-10 05:57:10 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/compat/ndis      ndis_var.h 
   Log:
   SVN rev 181496 on 2008-08-10 05:57:10Z by thompsa
   
   MFC r174141
   
    Correct the nwbx_ies field type in struct ndis_wlan_bssid_ex.
   
    PR:            kern/118369
   
   Revision  Changes    Path
   1.47.2.1  +1 -1      src/sys/compat/ndis/ndis_var.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
