From nobody@FreeBSD.org  Fri Nov 23 13:14:44 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5622116A418
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 23 Nov 2007 13:14:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B21113C469
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 23 Nov 2007 13:14:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lANDEd2t064978
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 23 Nov 2007 13:14:39 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id lANDEdUB064977;
	Fri, 23 Nov 2007 13:14:39 GMT
	(envelope-from nobody)
Message-Id: <200711231314.lANDEdUB064977@www.freebsd.org>
Date: Fri, 23 Nov 2007 13:14:39 GMT
From: Toomas Aas <toomas.aas@raad.tartu.ee>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Typo in aac debug messages
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         118219
>Category:       kern
>Synopsis:       [patch] Typo in aac debug messages
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rwatson
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 23 13:20:01 UTC 2007
>Closed-Date:    Sun Jan 13 16:30:38 UTC 2008
>Last-Modified:  Sun Jan 13 16:30:38 UTC 2008
>Originator:     Toomas Aas
>Release:        7.0-BETA3
>Organization:
Tartu City Government
>Environment:
FreeBSD heerold.raad.tartu.ee 7.0-BETA3 FreeBSD 7.0-BETA3 #1: Fri Nov 23 12:59:44 EET 2007     toomas@heerold.raad.tartu.ee:/usr/obj/usr/src/sys/HEEROLD07  amd64

>Description:
Several aac debug messages contain word "Conatainer" instead of "Container"
>How-To-Repeat:
Using a machine with aac-compatible controller, build a kernel with
options AAC_DEBUG=0
and create an event which causes debug messages to be printed (such as removing one hard disk from a RAID)

>Fix:
Apply the attached patch

Patch attached with submission follows:

--- aac_debug.c.orig	2007-11-23 14:56:55.000000000 +0200
+++ aac_debug.c	2007-11-23 14:57:48.000000000 +0200
@@ -416,57 +416,57 @@
 			break;
 		case AifJobCtrZero:		/* Container clear operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerZero) container %d\n", 
+				      "(ContainerZero) container %d\n", 
 				      aif->data.PR[0].jd.client.container.src);
 			break;
 		case AifJobCtrCopy:		/* Container copy operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerCopy) container %d to %d\n", 
+				      "(ContainerCopy) container %d to %d\n", 
 				      aif->data.PR[0].jd.client.container.src,
 				      aif->data.PR[0].jd.client.container.dst);
 			break;
 		case AifJobCtrCreateMirror:	/* Container Create Mirror
 						 * operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerCreateMirror) container %d\n",
+				      "(ContainerCreateMirror) container %d\n",
 				      aif->data.PR[0].jd.client.container.src);
 				      /* XXX two containers? */
 			break;
 		case AifJobCtrMergeMirror:	/* Container Merge Mirror
 						 * operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerMergeMirror) container %d\n",
+				      "(ContainerMergeMirror) container %d\n",
 				      aif->data.PR[0].jd.client.container.src);
 				      /* XXX two containers? */
 			break;
 		case AifJobCtrScrubMirror:	/* Container Scrub Mirror
 						 * operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerScrubMirror) container %d\n",
+				      "(ContainerScrubMirror) container %d\n",
 				      aif->data.PR[0].jd.client.container.src);
 			break;
 		case AifJobCtrRebuildRaid5:	/* Container Rebuild Raid5
 						 * operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerRebuildRaid5) container %d\n",
+				      "(ContainerRebuildRaid5) container %d\n",
 				      aif->data.PR[0].jd.client.container.src);
 			break;
 		case AifJobCtrScrubRaid5:	/* Container Scrub Raid5
 						 * operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerScrubRaid5) container %d\n", 
+				      "(ContainerScrubRaid5) container %d\n", 
 				      aif->data.PR[0].jd.client.container.src);
 			break;
 		case AifJobCtrMorph:		/* Container morph operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerMorph) container %d\n", 
+				      "(ContainerMorph) container %d\n", 
 				      aif->data.PR[0].jd.client.container.src);
 				      /* XXX two containers? */
 			break;
 		case AifJobCtrPartCopy:		/* Container Partition copy
 						 * operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerPartCopy) container %d to "
+				      "(ContainerPartCopy) container %d to "
 				      "%d\n",
 				      aif->data.PR[0].jd.client.container.src,
 				      aif->data.PR[0].jd.client.container.dst);
@@ -474,13 +474,13 @@
 		case AifJobCtrRebuildMirror:	/* Container Rebuild Mirror
 						 * operation */
 			device_printf(sc->aac_dev,
-				      "(ConatainerRebuildMirror) container " 
+				      "(ContainerRebuildMirror) container " 
 				      "%d\n",
 				      aif->data.PR[0].jd.client.container.src);
 			break;
 		case AifJobCtrCrazyCache:	/* crazy cache */
 			device_printf(sc->aac_dev,
-				      "(ConatainerCrazyCache) container %d\n", 
+				      "(ContainerCrazyCache) container %d\n", 
 				      aif->data.PR[0].jd.client.container.src);
 				      /* XXX two containers? */
 			break;


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: rwatson 
State-Changed-When: Sun Nov 25 12:30:19 UTC 2007 
State-Changed-Why:  
I didn't find this PR until after I'd committed what I assume to be an 
identical change to aac_debug after seeing your post on the mailing lists. 
I'll leave the PR in the patched state until I've MFC'd.  Thanks! 



Responsible-Changed-From-To: freebsd-bugs->rwatson 
Responsible-Changed-By: rwatson 
Responsible-Changed-When: Sun Nov 25 12:30:19 UTC 2007 
Responsible-Changed-Why:  
I committed an identical change. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=118219 
State-Changed-From-To: patched->closed 
State-Changed-By: rwatson 
State-Changed-When: Sun Jan 13 16:29:40 UTC 2008 
State-Changed-Why:  
Change was MFC'd, so closing PR.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118219 
>Unformatted:
