From bg@sics.se  Tue Nov 20 15:59:13 2007
Return-Path: <bg@sics.se>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D19D516A419;
	Tue, 20 Nov 2007 15:59:13 +0000 (UTC)
	(envelope-from bg@sics.se)
Received: from ibook.sics.se (ibook.sics.se [193.10.66.104])
	by mx1.freebsd.org (Postfix) with ESMTP id AA8AA13C468;
	Tue, 20 Nov 2007 15:59:13 +0000 (UTC)
	(envelope-from bg@sics.se)
Received: by ibook.sics.se (Postfix, from userid 113)
	id 9FFADB6B; Tue, 20 Nov 2007 16:58:53 +0100 (CET)
Message-Id: <20071120155853.9FFADB6B@ibook.sics.se>
Date: Tue, 20 Nov 2007 16:58:53 +0100 (CET)
From: Bjoern Groenvall <bg@sics.se>
Reply-To: Bjoern Groenvall <bg@sics.se>
To: FreeBSD-gnats-submit@freebsd.org
Cc: bg@sics.se, kmacy@FreeBSD.org
Subject: [nfs] kldunload nfsserver wedges server
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         118152
>Category:       kern
>Synopsis:       [nfs] [patch] kldunload nfsserver wedges server
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 20 16:00:05 UTC 2007
>Closed-Date:    Sun Feb 10 11:20:23 UTC 2008
>Last-Modified:  Thu Feb 14 14:20:01 UTC 2008
>Originator:     Bjoern Groenvall
>Release:        FreeBSD 8.0-CURRENT amd64
>Organization:
SICS
>Environment:
System: FreeBSD duvel.sics.se 8.0-CURRENT FreeBSD 8.0-CURRENT #2: Sun Nov 18 20:14:16 UTC 2007 root@duvel.sics.se:/usr/obj/usr/src/sys/GEN-NFS amd64


	HP PC, amd64
>Description:
	unloading the nfsserver kernel module panics server
>How-To-Repeat:
	kldunload nfsserver
>Fix:

nfsrv_destroycache() is accidentally called twice (change
nfs_srvsubs.c:1.147).

--- nfs_srvsubs.c.DIST	2007-11-20 15:34:14.000000000 +0000
+++ nfs_srvsubs.c	2007-11-20 15:34:23.000000000 +0000
@@ -569,7 +569,6 @@
 			syscall_deregister(&nfssvc_offset, &nfssvc_prev_sysent);
 		callout_drain(&nfsrv_callout);
 		nfsrv_destroycache();	/* Free the server request cache */
-		nfsrv_destroycache();	/* Free the server request cache */
 		mtx_destroy(&nfsd_mtx);
 		break;
 	default:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Tue Nov 20 17:46:54 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118152 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Fri Jan 18 17:03:52 UTC 2008 
State-Changed-Why:  
Patched in current, will MFC soon 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118152 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118152: commit references a PR
Date: Fri, 18 Jan 2008 17:03:42 +0000 (UTC)

 remko       2008-01-18 17:03:36 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/nfsserver        nfs_srvsubs.c 
   Log:
   Use nfsrv_destroycache() only once, else it crashes the server.
   
   PR:             kern/118152
   Submitted by:   Bjoern Groenvall <bg at sics dot se>
   Approved by:    imp (mentor, a while ago already), jhb
   MFC After:      3 days
   
   Revision  Changes    Path
   1.153     +0 -1      src/sys/nfsserver/nfs_srvsubs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118152: commit references a PR
Date: Sun, 10 Feb 2008 11:19:39 +0000 (UTC)

 remko       2008-02-10 11:19:34 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/nfsserver        nfs_srvsubs.c 
   Log:
   MFC rev 1.153 nfs_srvsubs.c
   
   Use nfsrv_destroycache() only once, else it crashes the server.
   
     PR: kern/118152
     Submitted by: Bjoern Groenvall <bg at sics dot se>
     Approved by: imp (mentor, a while ago already), jhb
     MFC After: 3 days
   
   Approved by:    imp (mentor, implicit)
   
   Revision   Changes    Path
   1.149.2.2  +0 -1      src/sys/nfsserver/nfs_srvsubs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Sun Feb 10 11:20:22 UTC 2008 
State-Changed-Why:  
MFC'ed to all relevant branches (RC2 for FreeBSD 7 MFC is requested but 
that could be too late, if I get approval I will get it in), thanks for 
the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118152 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118152: commit references a PR
Date: Thu, 14 Feb 2008 14:12:32 +0000 (UTC)

 remko       2008-02-14 14:12:13 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7_0)
     sys/nfsserver        nfs_srvsubs.c 
   Log:
   MFC rev 1.153 nfs_srvsubs.c
   
   Use nfsrv_destroycache() only once, else it crashes the server.
   
     PR: kern/118152
     Submitted by: Bjoern Groenvall <bg at sics dot se>
     Approved by: imp (mentor, a while ago already), jhb
     MFC After: 3 days
   
   Approved by:    re (kensmith), imp (mentor, implicit)
   
   Revision       Changes    Path
   1.149.2.1.2.1  +0 -1      src/sys/nfsserver/nfs_srvsubs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
