From ed@hoeg.nl  Sun Nov 18 22:15:56 2007
Return-Path: <ed@hoeg.nl>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2131A16A417
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 18 Nov 2007 22:15:56 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211])
	by mx1.freebsd.org (Postfix) with ESMTP id E3CE113C45D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 18 Nov 2007 22:15:55 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 112D71CCC6; Sun, 18 Nov 2007 23:15:55 +0100 (CET)
Message-Id: <20071118221555.112D71CCC6@palm.hoeg.nl>
Date: Sun, 18 Nov 2007 23:15:55 +0100 (CET)
From: Ed Schouten <ed@fxq.nl>
Reply-To: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [Patch] msk(4): Make it work on 3rd generation MacBooks
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         118110
>Category:       kern
>Synopsis:       [msk] [patch] make msk(4) work on 3rd generation MacBooks
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    yongari
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 18 22:20:00 UTC 2007
>Closed-Date:    Sun Feb 03 08:01:43 UTC 2008
>Last-Modified:  Sun Feb  3 08:10:01 UTC 2008
>Originator:     Ed Schouten
>Release:        FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
A new Apple MacBook, running a brand-new -CURRENT.
>Description:
The msk(4) driver doesn't attach on my new Apple MacBook. A PCI ID is
missing. When I add it, I can SSH to my other box and run send-pr to
file this bug! :-)
>How-To-Repeat:
>Fix:
According to various sources (Linux PCI ID's project), the chip in
question is called the 88E8058. This patch adds the needed bits.

--- src/sys/dev/msk/if_msk.c	2007-07-30 04:38:26.000000000 +0200
+++ src/sys/dev/msk/if_msk.c	2007-11-18 23:08:26.000000000 +0100
@@ -203,6 +203,8 @@
 	    "Marvell Yukon 88E8055 Gigabit Ethernet" },
 	{ VENDORID_MARVELL, DEVICEID_MRVL_4364,
 	    "Marvell Yukon 88E8056 Gigabit Ethernet" },
+	{ VENDORID_MARVELL, DEVICEID_MRVL_436A,
+	    "Marvell Yukon 88E8058 Gigabit Ethernet" },
 	{ VENDORID_DLINK, DEVICEID_DLINK_DGE550SX,
 	    "D-Link 550SX Gigabit Ethernet" },
 	{ VENDORID_DLINK, DEVICEID_DLINK_DGE560T,
--- src/sys/dev/msk/if_mskreg.h	2007-07-06 13:12:48.000000000 +0200
+++ src/sys/dev/msk/if_mskreg.h	2007-11-18 23:08:05.000000000 +0100
@@ -135,6 +135,7 @@
 #define DEVICEID_MRVL_4362	0x4362
 #define DEVICEID_MRVL_4363	0x4363
 #define DEVICEID_MRVL_4364	0x4364
+#define DEVICEID_MRVL_436A	0x436A
 
 /*
  * D-Link gigabit ethernet device ID
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->yongari 
Responsible-Changed-By: yongari 
Responsible-Changed-When: Mon Nov 19 01:23:34 UTC 2007 
Responsible-Changed-Why:  
Grab 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118110 
State-Changed-From-To: open->feedback 
State-Changed-By: yongari 
State-Changed-When: Mon Nov 19 01:24:21 UTC 2007 
State-Changed-Why:  
I think your patch should work but I'd like to know more detailed 
hardware information for 88E8058. Would you show me the verbosed boot 
messages related with msk(4) and attached PHY driver? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118110 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118110: commit references a PR
Date: Tue, 20 Nov 2007 07:47:39 +0000 (UTC)

 yongari     2007-11-20 07:47:32 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/msk          if_msk.c if_mskreg.h 
   Log:
   Add device id for 88E8058(Yukon EC Ultra) which is found on 3rd
   generation MacBooks.
   Unfortunately 88E8058 supports one MSI message so msk(4) needs more
   generic way to handle the MSI capability.
   
   PR:     118110
   
   Revision  Changes    Path
   1.23      +2 -0      src/sys/dev/msk/if_msk.c
   1.10      +1 -0      src/sys/dev/msk/if_mskreg.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->patched 
State-Changed-By: yongari 
State-Changed-When: Wed Nov 21 00:45:46 UTC 2007 
State-Changed-Why:  
Feedback received. Patch committed to HEAD. 
Thank you very much for submitting the patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118110 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118110: commit references a PR
Date: Sun,  3 Feb 2008 07:57:11 +0000 (UTC)

 yongari     2008-02-03 07:57:04 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/dev/msk          if_msk.c if_mskreg.h 
   Log:
   MFC if_msk.c rev 1.23, if_mskreg.h 1.10 to RELENG_7.
     Add device id for 88E8058(Yukon EC Ultra) which is found on 3rd
     generation MacBooks.
     Unfortunately 88E8058 supports one MSI message so msk(4) needs more
     generic way to handle the MSI capability.
   
     PR:   118110
   
   Revision  Changes    Path
   1.18.2.6  +2 -0      src/sys/dev/msk/if_msk.c
   1.6.2.5   +1 -0      src/sys/dev/msk/if_mskreg.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: yongari 
State-Changed-When: Sun Feb 3 08:01:12 UTC 2008 
State-Changed-Why:  
MFC done. Thank you very much for the patch! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118110 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118110: commit references a PR
Date: Sun,  3 Feb 2008 08:00:24 +0000 (UTC)

 yongari     2008-02-03 08:00:16 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/dev/msk          if_msk.c if_mskreg.h 
   Log:
   MFC if_msk.c rev 1.23, if_mskreg.h 1.10 to RELENG_6.
     Add device id for 88E8058(Yukon EC Ultra) which is found on 3rd
     generation MacBooks.
     Unfortunately 88E8058 supports one MSI message so msk(4) needs more
     generic way to handle the MSI capability.
   
     PR:   118110
   
   Revision   Changes    Path
   1.11.2.14  +2 -0      src/sys/dev/msk/if_msk.c
   1.3.2.9    +1 -0      src/sys/dev/msk/if_mskreg.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
