From nobody@FreeBSD.org  Sun Nov  4 14:21:46 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA11E16A419
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  4 Nov 2007 14:21:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id C97EE13C4BE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  4 Nov 2007 14:21:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lA4ELacp044685
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 4 Nov 2007 14:21:36 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id lA4ELaDw044684;
	Sun, 4 Nov 2007 14:21:36 GMT
	(envelope-from nobody)
Message-Id: <200711041421.lA4ELaDw044684@www.freebsd.org>
Date: Sun, 4 Nov 2007 14:21:36 GMT
From: Klaus Mayr <webmaster@mayr-software.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         117813
>Category:       kern
>Synopsis:       [patch] make "snd_atiixp.ko" work on a KINO690S1 Mainboard
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ariff
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 04 14:30:02 UTC 2007
>Closed-Date:    Tue Nov 06 02:09:55 UTC 2007
>Last-Modified:  Tue Nov  6 02:10:03 UTC 2007
>Originator:     Klaus Mayr
>Release:        FreeBSD 7.0-current-200709 amd64
>Organization:
Mayr Software & Netzwerke
>Environment:
FreeBSD srv01.mayr-software.de 7.0-CURRENT-200709 #0: Mon Sep 10 23:28:19 UTC 2007
root@myers.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Makes "snd_atiixp.ko" work on a KINO690S1 Mainboard which has the ATI SB600 chipset with a ALC655 AC97-compatible soundchip. :-)

Board description: http://www.ipc2u.de/catalog/P/PE/36486.html.

Using "kldload snd_driver" did not work to find any multimedia drivers for
the chipset. The board has the ATI SB600 as south bridge, which may be hndled with the snd_hda driver, but as mentioned in the board description only uses an ac97 compatible codec. The command "pciconf -lv" returns an "ATI IXP SB600 ..." audio controller, but the snd_atiixp driver did not work/load.

So i did the modifications below. :-)


>How-To-Repeat:
n/a
>Fix:

I added the following lines to the atiixp.* files in /usr/src/sys/dev/sound/pci

******************************************************************************

+++ atiixp.c	2007-11-04 15:36:13.000000000 +0100
@@ -170,6 +170,7 @@
 	{ ATI_VENDOR_ID, ATI_IXP_200_ID, "ATI IXP 200" },
 	{ ATI_VENDOR_ID, ATI_IXP_300_ID, "ATI IXP 300" },
 	{ ATI_VENDOR_ID, ATI_IXP_400_ID, "ATI IXP 400" },
+        { ATI_VENDOR_ID, ATI_IXP_SB600_ID, "ATI IXP SB600" },
 };
 
 static void atiixp_enable_interrupts(struct atiixp_info *);

*****************************************************************************

+++ atiixp.h	2007-11-04 15:37:55.000000000 +0100
@@ -51,6 +51,7 @@
 #define ATI_IXP_200_ID		0x4341
 #define ATI_IXP_300_ID		0x4361
 #define ATI_IXP_400_ID		0x4370
+#define ATI_IXP_SB600_ID	0x4384
 
 #define ATI_IXP_BASE_RATE	48000
 
*****************************************************************************



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->ariff 
Responsible-Changed-By: remko 
Responsible-Changed-When: Sun Nov 4 15:37:09 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117813 
State-Changed-From-To: open->patched 
State-Changed-By: ariff 
State-Changed-When: Sun Nov 4 16:05:41 UTC 2007 
State-Changed-Why:  
Fix committed, MFC later. 

Thanks for the submission. I love this PR :) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117813 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/117813: commit references a PR
Date: Sun,  4 Nov 2007 16:03:18 +0000 (UTC)

 ariff       2007-11-04 16:03:10 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/sound/pci    atiixp.c atiixp.h 
   Log:
   Add support for trimmed down version of ATI SB600 AC97 audio
   controller.
   
   URL:            http://www.ipc2u.de/catalog/P/PE/36486.html
   PR:             kern/117813
   Submitted by:   Klaus Mayr
   MFC after:      1 day
   
   Revision  Changes    Path
   1.21      +1 -0      src/sys/dev/sound/pci/atiixp.c
   1.4       +1 -0      src/sys/dev/sound/pci/atiixp.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: ariff 
State-Changed-When: Tue Nov 6 02:08:58 UTC 2007 
State-Changed-Why:  
Fix committed. Thanks for the submission. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117813 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/117813: commit references a PR
Date: Tue,  6 Nov 2007 02:08:02 +0000 (UTC)

 ariff       2007-11-06 02:07:57 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/dev/sound/pci    atiixp.c atiixp.h 
   Log:
   MFC:
   
     Revisions:
     1.21     src/sys/dev/sound/pci/atiixp.c
     1.4      src/sys/dev/sound/pci/atiixp.h
   
   Add support for trimmed down version of ATI SB600 AC97 audio
   controller.
   
   URL:            http://www.ipc2u.de/catalog/P/PE/36486.html
   PR:             kern/117813
   Submitted by:   Klaus Mayr
   Approved by:    re (kensmith)
   
   Revision  Changes    Path
   1.19.2.1  +2 -1      src/sys/dev/sound/pci/atiixp.c
   1.3.2.1   +1 -0      src/sys/dev/sound/pci/atiixp.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/117813: commit references a PR
Date: Tue,  6 Nov 2007 02:08:29 +0000 (UTC)

 ariff       2007-11-06 02:08:25 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/dev/sound/pci    atiixp.c atiixp.h 
   Log:
   MFC:
   
     Revisions:
     1.21     src/sys/dev/sound/pci/atiixp.c
     1.4      src/sys/dev/sound/pci/atiixp.h
   
   Add support for trimmed down version of ATI SB600 AC97 audio
   controller.
   
   URL:            http://www.ipc2u.de/catalog/P/PE/36486.html
   PR:             kern/117813
   Submitted by:   Klaus Mayr
   
   Revision  Changes    Path
   1.2.2.8   +1 -0      src/sys/dev/sound/pci/atiixp.c
   1.1.2.3   +1 -0      src/sys/dev/sound/pci/atiixp.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
