From nobody@FreeBSD.org  Thu Sep  6 21:36:15 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 38A5C16A421
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Sep 2007 21:36:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id E2B6D13C46A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Sep 2007 21:36:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l86LaEkH059859
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 Sep 2007 21:36:14 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l86LaEhG059858;
	Thu, 6 Sep 2007 21:36:14 GMT
	(envelope-from nobody)
Message-Id: <200709062136.l86LaEhG059858@www.freebsd.org>
Date: Thu, 6 Sep 2007 21:36:14 GMT
From: Igor Mozolevsky <igor@hybrid-lab.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] acpi_ibm => psm0 not found problem
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         116169
>Category:       kern
>Synopsis:       [PATCH] acpi_ibm => psm0 not found problem
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-acpi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 06 21:40:01 GMT 2007
>Closed-Date:    Mon Jan 14 18:49:08 UTC 2008
>Last-Modified:  Mon Jan 14 18:49:08 UTC 2008
>Originator:     Igor Mozolevsky
>Release:        RELENG_6 from cvs
>Organization:
>Environment:
>Description:
psm driver fails to allocate irq 12 because acpi_ibm has already grabbed it
>How-To-Repeat:
build kernel with both acpi_ibm and psm included
>Fix:
patch acpi_ibm.c and psm.c as per attached file

Patch attached with submission follows:

--- /usr/src/sys/dev/acpi_support/acpi_ibm.c.orig	2007-09-06 22:19:39.000000000 +0100
+++ /usr/src/sys/dev/acpi_support/acpi_ibm.c	2007-09-06 22:20:27.000000000 +0100
@@ -317,7 +317,7 @@
 
 	device_set_desc(dev, "IBM ThinkPad ACPI Extras");
 
-	return (0);
+	return (BUS_PROBE_LOW_PRIORITY);
 }
 
 static int
--- /usr/src/sys/dev/atkbdc/psm.c.orig	2007-09-06 22:20:13.000000000 +0100
+++ /usr/src/sys/dev/atkbdc/psm.c	2007-09-06 22:21:15.000000000 +0100
@@ -1254,7 +1254,7 @@
     /* done */
     kbdc_set_device_mask(sc->kbdc, mask | KBD_AUX_CONTROL_BITS);
     kbdc_lock(sc->kbdc, FALSE);
-    return (0);
+    return (BUS_PROBE_DEFAULT);
 }
 
 static int


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-acpi 
Responsible-Changed-By: remko 
Responsible-Changed-When: Fri Sep 7 06:15:18 UTC 2007 
Responsible-Changed-Why:  
Reassign to ACPI team 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116169 

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, igor@hybrid-lab.co.uk
Cc:  
Subject: Re: kern/116169: [PATCH] acpi_ibm =&gt; psm0 not found problem
Date: Mon, 31 Dec 2007 11:08:34 -0500

 This should have been fixed by rev 1.15 of acpi_ibm.c
 
 -- 
 John Baldwin
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Mon Jan 14 05:26:49 UTC 2008 
State-Changed-Why:  
To submitter: did the checkin noted in the Audit-Trail fix the problem? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116169 

From: Daniel Rucci <dan@rucci.org>
To: bug-followup@FreeBSD.org, igor@hybrid-lab.co.uk
Cc:  
Subject: Re: kern/116169: [PATCH] acpi_ibm =&gt; psm0 not found problem
Date: Mon, 14 Jan 2008 12:44:09 -0500

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 If he doesn't follow up or just for some more feedback.
 
 $ uname -a
 FreeBSD izer.warganizer.com 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #1:
 Mon Jan 14 11:38:51 EST 2008
 root@izer.warganizer.com:/usr/obj/usr/src/sys/LAPTOPKERN  i386
 
 $FreeBSD: src/sys/dev/acpi_support/acpi_ibm.c,v 1.14.2.1 2007/11/02
 18:54:09 jhb Exp
 
 i built my kernel with
 device      acpi_ibm
 device      psm     # PS/2 mouse
 
 with no build errors and its running now.
 
 
 some dmesg
 ACPI APIC Table: <IBM    TP-1U   >
 ACPI Warning (tbfadt-0505): Optional field "Gpe1Block" has zero address
 or length:        0    102C/0 [20070320]
 acpi_ibm0: <IBM ThinkPad ACPI Extras> on acpi0
 psm0: <PS/2 Mouse> irq 12 on atkbdc0
 psm0: [GIANT-LOCKED]
 psm0: [ITHREAD]
 psm0: model Generic PS/2 mouse, device ID 0
 
 lemme know if you need anything else.
 
 
 dan
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.4 (FreeBSD)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
 iD8DBQFHi59p35WRARjlw0YRAt/6AKCDmPD7jd5IoW5vwMGJsTlc9tnf1gCfdiVX
 SmfLw8Lp6QWyGRO0vqeLkS8=
 =iCQt
 -----END PGP SIGNATURE-----
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Mon Jan 14 18:48:41 UTC 2008 
State-Changed-Why:  
Submitter notes that the cited checkin fixed the problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116169 
>Unformatted:
