From eugen@grosbein.pp.ru  Sat Aug 11 02:55:17 2007
Return-Path: <eugen@grosbein.pp.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E141A16A418
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Aug 2007 02:55:17 +0000 (UTC)
	(envelope-from eugen@grosbein.pp.ru)
Received: from grosbein.pp.ru (grgw.svzserv.kemerovo.su [213.184.64.166])
	by mx1.freebsd.org (Postfix) with ESMTP id 3659F13C468
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Aug 2007 02:55:15 +0000 (UTC)
	(envelope-from eugen@grosbein.pp.ru)
Received: from grosbein.pp.ru (localhost [127.0.0.1])
	by grosbein.pp.ru (8.14.1/8.14.1) with ESMTP id l7B2tBxo036585;
	Sat, 11 Aug 2007 10:55:11 +0800 (KRAST)
	(envelope-from eugen@grosbein.pp.ru)
Received: (from eugen@localhost)
	by grosbein.pp.ru (8.14.1/8.14.1/Submit) id l7B2tA1F036584;
	Sat, 11 Aug 2007 10:55:10 +0800 (KRAST)
	(envelope-from eugen)
Message-Id: <200708110255.l7B2tA1F036584@grosbein.pp.ru>
Date: Sat, 11 Aug 2007 10:55:10 +0800 (KRAST)
From: Eugene Grosbein <eugen@grosbein.pp.ru>
Reply-To: Eugene Grosbein <eugen@grosbein.pp.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: hm@freebsd.org
Subject: [patch] latest commit to RELENG_6's src/sys/net/if_tap.c broke buildworld when MODULES_WITH_WORLD=true
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         115414
>Category:       kern
>Synopsis:       [patch] latest commit to RELENG_6's src/sys/net/if_tap.c broke buildworld when MODULES_WITH_WORLD=true
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    hm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 11 03:00:04 GMT 2007
>Closed-Date:    Tue Aug 21 11:00:02 CEST 2007
>Last-Modified:  Tue Aug 21 09:00:12 GMT 2007
>Originator:     Eugene Grosbein
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
Svyaz-Service JSC
>Environment:
System: FreeBSD grosbein.pp.ru 6.2-STABLE FreeBSD 6.2-STABLE #0: Sat Jul 28 01:42:57 KRAST 2007 eu@grosbein.pp.ru:/usr/obj/usr/local/src/sys/DADV i386

>Description:
	make buildworld breaks on tap(4) module build:

===> sys/modules/if_tap (depend)
rm -f .depend
mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE -I- -I. -I@
-I@/contrib/altq -I@/../include
/usr/obj/src/sys/modules/if_tap/../../net/if_tap.c
/usr/obj/src/sys/modules/if_tap/../../net/if_tap.c:38:24: opt_compat.h: No such file or directory
mkdep: compile failed
*** Error code 1

	The reason is that fix for PR: kern/111480 was incomplete.

>How-To-Repeat:
	cd /usr/src && make MODULES_WITH_WORLD=true buildworld

>Fix:

	Perform MFC of src/sys/modules/if_tap/Makefile,v1.6:

--- Makefile.orig	2007-08-11 10:47:19.000000000 +0800
+++ Makefile	2007-08-11 10:48:14.000000000 +0800
@@ -5,9 +5,12 @@
 .PATH: ${.CURDIR}/../../net
 
 KMOD=	if_tap
-SRCS=	if_tap.c opt_inet.h vnode_if.h
+SRCS=	if_tap.c opt_compat.h opt_inet.h vnode_if.h
 
 .if !defined(KERNBUILDDIR)
+opt_compat.h:
+	echo "#define COMPAT_FREEBSD6 1" > ${.TARGET}
+
 opt_inet.h:
 	echo "#define INET 1" > opt_inet.h
 .endif


Eugene Grosbein
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->hm 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Aug 11 03:21:42 UTC 2007 
Responsible-Changed-Why:  
hm did the commit. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115414 

From: Andre Albsmeier <Andre.Albsmeier@siemens.com>
To: bug-followup@FreeBSD.org, eugen@grosbein.pp.ru, hm@FreeBSD.org
Cc:  
Subject: Re: kern/115414: [patch] latest commit to RELENG_6's
	src/sys/net/if_tap.c broke buildworld when MODULES_WITH_WORLD=true
Date: Mon, 20 Aug 2007 08:03:58 +0200

 Can someone commit this please finally?
 
 make world is still broken on RELENG_6
 with MODULES_WITH_WORLD=true
State-Changed-From-To: open->closed 
State-Changed-By: hm 
State-Changed-When: Tue Aug 21 10:59:06 CEST 2007 
State-Changed-Why:  
After testing committed to RELENG_6, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115414 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/115414: commit references a PR
Date: Tue, 21 Aug 2007 08:58:32 +0000 (UTC)

 hm          2007-08-21 08:58:22 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/modules/if_tap   Makefile 
   Log:
   PR:             kern/115414
   Submitted by:   Eugene Grosbein <eugen@grosbein.pp.ru>
   The fix for PR kern/111480 was incomplete, "make MODULES_WITH_WORLD=true
   buildworld" stopped with an error.
   
   Revision  Changes    Path
   1.4.2.2   +4 -1      src/sys/modules/if_tap/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
