From alex-goncharov@comcast.net  Sun Jul 22 03:17:45 2007
Return-Path: <alex-goncharov@comcast.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 98B5116A419
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Jul 2007 03:17:45 +0000 (UTC)
	(envelope-from alex-goncharov@comcast.net)
Received: from alnrmhc13.comcast.net (alnrmhc13.comcast.net [204.127.225.93])
	by mx1.freebsd.org (Postfix) with ESMTP id 78EF513C45D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Jul 2007 03:17:45 +0000 (UTC)
	(envelope-from alex-goncharov@comcast.net)
Received: from [66.30.18.168] (c-66-30-18-168.hsd1.ma.comcast.net[66.30.18.168])
          by comcast.net (alnrmhc13) with ESMTP
          id <20070722030742b13006iq7le>; Sun, 22 Jul 2007 03:07:43 +0000
Received: from algo by [66.30.18.168] with local (Exim 4.67 (FreeBSD))
	(envelope-from <alex-goncharov@comcast.net>)
	id 1ICRnK-000Np7-7K
	for FreeBSD-gnats-submit@freebsd.org; Sat, 21 Jul 2007 23:07:42 -0400
Message-Id: <E1ICRnK-000Np7-7K@[66.30.18.168]>
Date: Sat, 21 Jul 2007 23:07:42 -0400
From: Alex Goncharov <algo1@comcast.net>
Sender: Alex Goncharov <alex-goncharov@comcast.net>
Reply-To: Alex Goncharov <algo1@comcast.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: sys/pci/agp_i810.c misses i845G chipset
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         114802
>Category:       kern
>Synopsis:       [agp] [patch] sys/pci/agp_i810.c misses i845G chipset
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 22 03:20:02 GMT 2007
>Closed-Date:    Mon Dec 03 11:34:37 UTC 2007
>Last-Modified:  Mon Dec 03 11:34:37 UTC 2007
>Originator:     Alex Goncharov
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
N/A
>Environment:
System: FreeBSD fasolt 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sat Jul 21 17:26:14 EDT 2007 root@MYHOST:/usr/obj/usr/src-7.0-CURRENT/sys/GENERIC i386

>Description:

After a code upgrade from 6.2-STABLE to 7.0-CURRENT, the X server
won't start, complaining about the absense of `/dev/agpgart', which is
missing indeed.

>How-To-Repeat:

* Have a machine with '82845G/GL/GV/GE/PE Integrated Graphics Device'.

* Install 7.0-CURRENT, where the revision's sys/pci/agp_i810.c CVS Id
  is:

  $FreeBSD: src/sys/pci/agp_i810.c,v 1.40 2007/07/13 16:28:12

  Reboot.

* Observe the lack of `/dev/agpgart'.

* Observe the failure to start X (provided the `xorg.conf' uses the
  i810 driver:

Section "Device"
        Driver      "i810"
EndSection

>Fix:

Applying the following patch:
===================================================================
--- sys/pci/agp_i810.c 2007-07-21 14:56:26.000000000 -0400
+++ sys/pci/agp_i810.c-fixed  2007-07-21 15:27:26.000000000 -0400
@@ -130,6 +130,8 @@
            "Intel 82815 (i815 GMCH) SVGA controller"},
        {0x35778086, CHIP_I830, 0x00020000,
            "Intel 82830M (830M GMCH) SVGA controller"},
+       {0x25628086, CHIP_I830, 0x00020000,
+           "Intel 82845M (845M GMCH) SVGA controller"},
        {0x35828086, CHIP_I855, 0x00020000,
            "Intel 82852/5"},
        {0x25728086, CHIP_I855, 0x00020000,
===================================================================

resolves the issue -- after a rebuild and restart, `/dev/agpgart' does
appear, and the X servers starts and operates problem-free.

Note that the quoted string, "Intel 82845M (845M GMCH) SVGA
controller", may need to be changed to give a more accurate
information on the controller.

After the fix, pcicong -lv produces (in the relevant piece):

===================================================================

vgapci0@pci0:2:0:       class=0x030000 card=0x01271028 chip=0x25628086 rev=0x01 
hdr=0x00
    vendor     = 'Intel Corporation'
    device     = '82845G/GL/GV/GE/PE Integrated Graphics Device'
    class      = display
    subclass   = VGA
===================================================================
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->anholt 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Jul 22 04:09:37 UTC 2007 
Responsible-Changed-Why:  
anholt is interested in agp PRs. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114802 
Responsible-Changed-From-To: anholt->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Sun Sep 23 19:30:39 UTC 2007 
Responsible-Changed-Why:  
Temporary take this PR to see what we can do to make somebody interested 
in this PR :) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114802 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/114802: commit references a PR
Date: Mon, 26 Nov 2007 18:17:14 +0000 (UTC)

 remko       2007-11-26 18:17:07 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/agp          agp_i810.c 
   Log:
   Add the 845M GMCH controller.
   
   PR:             114802
   Approved by:    imp (mentor), anholt (private mail)
   Submitted by:   Alex Goncharov <algo1 at comcast dot net>
   MFC After:      3 days
   
   Revision  Changes    Path
   1.44      +2 -0      src/sys/dev/agp/agp_i810.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Mon Nov 26 19:57:34 UTC 2007 
State-Changed-Why:  
Patched in -HEAD 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114802 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/114802: commit references a PR
Date: Sat,  1 Dec 2007 16:24:27 +0000 (UTC)

 remko       2007-12-01 16:24:23 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/pci              agp_i810.c 
   Log:
   MFC rev 1.11 agp.4
   
     Add information about the 845M card that I recently committed support
     for.
   
   MFC rev 1.44 agp_i810.c
   
     Add the 845M GMCH controller.
   
     PR:             114802
     Approved by:    imp (mentor), anholt (private mail)
     Submitted by:   Alex Goncharov <algo1 at comcast dot net>
     MFC After:      3 days
   
   Approved by:    re (hrs), imp (mentor, implicit)
   
   Revision  Changes    Path
   1.41.2.2  +2 -0      src/sys/pci/agp_i810.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Mon Dec 3 11:34:35 UTC 2007 
State-Changed-Why:  
I've got reports tha tthis already worked in RELENG_6, so only CURRENT 
and RELENG_7, where not correct (because of new code drops there); I 
fixed this. Let me know in case it does not work after all... 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114802 
>Unformatted:
