From eugen@grosbein.pp.ru  Fri Jul 20 17:25:10 2007
Return-Path: <eugen@grosbein.pp.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3E0B816A419
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jul 2007 17:25:10 +0000 (UTC)
	(envelope-from eugen@grosbein.pp.ru)
Received: from grosbein.pp.ru (grgw.svzserv.kemerovo.su [213.184.64.166])
	by mx1.freebsd.org (Postfix) with ESMTP id 92B7813C467
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jul 2007 17:25:09 +0000 (UTC)
	(envelope-from eugen@grosbein.pp.ru)
Received: from grosbein.pp.ru (localhost [127.0.0.1])
	by grosbein.pp.ru (8.14.1/8.14.1) with ESMTP id l6KHP7MP001921;
	Sat, 21 Jul 2007 01:25:07 +0800 (KRAST)
	(envelope-from eugen@grosbein.pp.ru)
Received: (from eugen@localhost)
	by grosbein.pp.ru (8.14.1/8.14.1/Submit) id l6KHP73U001920;
	Sat, 21 Jul 2007 01:25:07 +0800 (KRAST)
	(envelope-from eugen)
Message-Id: <200707201725.l6KHP73U001920@grosbein.pp.ru>
Date: Sat, 21 Jul 2007 01:25:07 +0800 (KRAST)
From: Eugene Grosbein <eugen@grosbein.pp.ru>
Reply-To: Eugene Grosbein <eugen@grosbein.pp.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: rodrigc@freebsd.org
Subject: [patch] "mount_msdosfs -l" does not work due to bad MFC
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         114776
>Category:       kern
>Synopsis:       [patch] "mount_msdosfs -l" does not work due to bad MFC
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    rodrigc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 20 17:30:01 GMT 2007
>Closed-Date:    Sat Jul 21 22:30:58 GMT 2007
>Last-Modified:  Sat Jul 21 22:30:58 GMT 2007
>Originator:     Eugene Grosbein
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
Svyaz-Service JSC
>Environment:
System: FreeBSD grosbein.pp.ru 6.2-STABLE FreeBSD 6.2-STABLE #9: Sat Jul 21 00:30:50 KRAST 2007 eu@grosbein.pp.ru:/usr/obj/usr/local/src/sys/DADV i386

>Description:
	It's impossible to force using/generating long file names
	for FAT filesystem when its root directory does not have
	one such name. This bug was fixed in CURRENT in October 2005,
	sys/fs/msdosfs/msdosfs_vfsops.c, revision 1.148
	but MFC performed by rodrigc@ was incomplete,
	so the "-l" option of mount_msdosfs does just nothing for 6-STABLE.

>How-To-Repeat:
	Mount FAT that does not contain long file names in root directory
	and try to create long file name there.

>Fix:

	Complete MFC of revision 1.148 for msdosfs_vfsops.c:

--- sys/fs/msdosfs/msdosfs_vfsops.c.orig	31 Oct 2005 15:41:20 -0000	1.147
+++ sys/fs/msdosfs/msdosfs_vfsops.c	18 Nov 2005 22:34:31 -0000	1.148
@@ -163,8 +163,12 @@
 		pmp->pm_dirmask = v & ALLPERMS;
 	vfs_flagopt(mp->mnt_optnew, "shortname",
 	    &pmp->pm_flags, MSDOSFSMNT_SHORTNAME);
+	vfs_flagopt(mp->mnt_optnew, "shortnames",
+	    &pmp->pm_flags, MSDOSFSMNT_SHORTNAME);
 	vfs_flagopt(mp->mnt_optnew, "longname",
 	    &pmp->pm_flags, MSDOSFSMNT_LONGNAME);
+	vfs_flagopt(mp->mnt_optnew, "longnames",
+	    &pmp->pm_flags, MSDOSFSMNT_LONGNAME);
 	vfs_flagopt(mp->mnt_optnew, "kiconv",
 	    &pmp->pm_flags, MSDOSFSMNT_KICONV);
 

Eugene Grosbein
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rodrigc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jul 20 20:00:38 UTC 2007 
Responsible-Changed-Why:  
Over to committer of the MFC this is concerning. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114776 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/114776: commit references a PR
Date: Sat, 21 Jul 2007 22:24:14 +0000 (UTC)

 rodrigc     2007-07-21 22:24:07 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/fs/msdosfs       msdosfs_vfsops.c 
   Log:
   MFC 1.148:
   When parsing mount options, accept "shortnames" and "longnames" in addition
   to "shortname" and "longname".
   
   Submitted by:   Eugene Grosbein
   PR:             114776
   
   Revision    Changes    Path
   1.144.2.12  +4 -0      src/sys/fs/msdosfs/msdosfs_vfsops.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: rodrigc 
State-Changed-When: Sat Jul 21 22:30:40 UTC 2007 
State-Changed-Why:  
Patch applied, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114776 
>Unformatted:
