From nobody@FreeBSD.org  Sat Jul  7 19:47:12 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 37F9A16A400
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Jul 2007 19:47:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 285FC13C45B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Jul 2007 19:47:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l67JlC14034952
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 7 Jul 2007 19:47:12 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l67JlB7c034951;
	Sat, 7 Jul 2007 19:47:12 GMT
	(envelope-from nobody)
Message-Id: <200707071947.l67JlB7c034951@www.freebsd.org>
Date: Sat, 7 Jul 2007 19:47:12 GMT
From: Craig Rodrigues <rodrigc@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: MOKB testcase causes kernel to crash in UFS mount code
X-Send-Pr-Version: www-3.0

>Number:         114389
>Category:       kern
>Synopsis:       [ufs] MOKB testcase causes kernel to crash in UFS mount code
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    rodrigc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 07 19:50:08 GMT 2007
>Closed-Date:    Sat Jul 21 22:31:57 GMT 2007
>Last-Modified:  Sat Jul 21 22:31:57 GMT 2007
>Originator:     Craig Rodrigues
>Release:        CURRENT
>Organization:
>Environment:
FreeBSD 7.0-CURRENT FreeBSD 7.0-CURRENT #24: Sat Jul  7 15:09:35 EDT 2007     /usr/obj/usr/src/sys/MYKERNEL1  i386

>Description:
The testcase at:
http://projects.info-pull.com/mokb/MOKB-08-11-2006.html

can cause the kernel to crash in the UFS mount code.
>How-To-Repeat:
(1) fetch http://projects.info-pull.com/mokb/bug-files/MOKB-08-11-2006.img.bz2
(2) bunzip2 MOKB-08-11-2006.img.bz2
(3) mdconfig -a -t vnode -f ./MOKB-08-11-2006.img -u 0
(4) mount /dev/md0 /mnt
>Fix:
See attached patch.

Patch attached with submission follows:

Index: ffs_vnops.c
===================================================================
RCS file: /home/ncvs/src/sys/ufs/ffs/ffs_vnops.c,v
retrieving revision 1.172
diff -u -u -r1.172 ffs_vnops.c
--- ffs_vnops.c	12 Jun 2007 00:12:01 -0000	1.172
+++ ffs_vnops.c	7 Jul 2007 19:46:36 -0000
@@ -1192,14 +1192,18 @@
 {
 	struct inode *ip;
 	struct ufs2_dinode *dp;
+	struct fs *fs;
 	struct uio luio;
 	struct iovec liovec;
 	int easize, error;
 	u_char *eae;
 
 	ip = VTOI(vp);
+	fs = ip->i_fs;
 	dp = ip->i_din2;
 	easize = dp->di_extsize;
+	if ((uoff_t)(easize + extra) > NXADDR * fs->fs_bsize)
+		return (EFBIG);
 
 	eae = malloc(easize + extra, M_TEMP, M_WAITOK);
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rodrigc 
Responsible-Changed-By: rodrigc 
Responsible-Changed-When: Sat Jul 7 19:51:50 UTC 2007 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=114389 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/114389: commit references a PR
Date: Fri, 13 Jul 2007 18:51:25 +0000 (UTC)

 rodrigc     2007-07-13 18:51:08 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/ufs/ffs          ffs_vnops.c 
   Log:
   Perform range check before allocating memory when reading
   extended attributes.
   
   Reviewed by:    kib
   Approved by:    re (hrs)
   PR:             114389
   
   Revision  Changes    Path
   1.173     +4 -0      src/sys/ufs/ffs/ffs_vnops.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/114389: commit references a PR
Date: Sat, 21 Jul 2007 22:17:13 +0000 (UTC)

 rodrigc     2007-07-21 22:17:06 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/ufs/ffs          ffs_vnops.c 
   Log:
   MFC: 1.173:
     Perform range check before allocating memory when reading
     extended attributes.
   
     Reviewed by:    kib
     PR:             114389
   
   Revision   Changes    Path
   1.157.2.6  +4 -0      src/sys/ufs/ffs/ffs_vnops.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: rodrigc 
State-Changed-When: Sat Jul 21 22:31:23 UTC 2007 
State-Changed-Why:  
Patch applied. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114389 
>Unformatted:
