From nobody@FreeBSD.org  Tue Jul  3 11:59:47 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D741316A400
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  3 Jul 2007 11:59:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id C8CAC13C4AD
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  3 Jul 2007 11:59:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l63Bxl5H000471
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 3 Jul 2007 11:59:47 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l63BxlaR000470;
	Tue, 3 Jul 2007 11:59:47 GMT
	(envelope-from nobody)
Message-Id: <200707031159.l63BxlaR000470@www.freebsd.org>
Date: Tue, 3 Jul 2007 11:59:47 GMT
From: nst <nst@yahoo.co.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: kernel lock
X-Send-Pr-Version: www-3.0

>Number:         114237
>Category:       kern
>Synopsis:       [lor] kernel lock
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    csjp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 03 12:00:17 GMT 2007
>Closed-Date:    Tue Nov 15 16:54:45 UTC 2011
>Last-Modified:  Tue Nov 15 16:54:45 UTC 2011
>Originator:     nst
>Release:        CURRENT
>Organization:
>Environment:
FreeBSD web 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Tue Jul  3 00:00:38 JST 2007     root@web:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
kernel: lock order reversal:
kernel: 1st 0xc3280090 inp (divinp) @ /usr/src/sys/modules/ipdivert/../../netinet/ip_divert.c:356
kernel: 2nd 0xc0bf0018 PFil hook read/write mutex (PFil hook read/write mutex) @ /usr/src/sys/net/pfil.c:73
kernel: KDB: stack backtrace:
kernel: db_trace_self_wrapper(c0a905d9,d51d6a38,c0781b8e,c0a92a7d,c0bf0018,...) at db_trace_self_wrapper+0x26
kernel: kdb_backtrace(c0a92a7d,c0bf0018,c0a9aedc,c0a9aedc,c0a9aec4,...) at kdb_backtrace+0x29
kernel: witness_checkorder(c0bf0018,1,c0a9aec4,49,c31932b8,...) at witness_checkorder+0x6de
kernel: _rw_rlock(c0bf0018,c0a9aec4,49,c31932b8,0,...) at _rw_rlock+0x8e
kernel: pfil_run_hooks(c0bf0000,d51d6b10,c2eb7400,2,0,...) at pfil_run_hooks+0x35
kernel: ip_output(c303ed00,0,d51d6ae4,22,0,...) at ip_output+0x862
kernel: div_send(c318e630,0,c303ed00,c2f232a0,0,...) at div_send+0x1fe
kernel: sosend_generic(c318e630,c2f232a0,d51d6be8,0,0,...) at sosend_generic+0x50d
kernel: sosend(c318e630,c2f232a0,d51d6be8,0,0,...) at sosend+0x54
kernel: kern_sendit(c3066c00,4,d51d6c64,0,0,...) at kern_sendit+0x137
kernel: sendit(0,bfbdecc1,0,c2f232a0,10,...) at sendit+0xb1
kernel: sendto(c3066c00,d51d6cfc,18,c,c0b3a078,...) at sendto+0x48
kernel: syscall(d51d6d38) at syscall+0x2b3
kernel: Xint0x80_syscall() at Xint0x80_syscall+0x20
kernel: --- syscall (133, FreeBSD ELF32, sendto), eip = 0x2814537f, esp = 0xbfbdebdc, ebp = 0xbfbeec78 ---

>How-To-Repeat:
ipfw + nat 

rc.conf
firewall_type="simple"
natd_enable="YES"

>Fix:


>Release-Note:
>Audit-Trail:

From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
To: bug-followup@FreeBSD.org, nst@yahoo.co.jp
Cc:  
Subject: Re: kern/114237: kernel lock
Date: Tue, 3 Jul 2007 14:04:11 +0000 (UTC)

 On Tue, 3 Jul 2007, nst wrote:
 
 > kernel: lock order reversal:
 > kernel: 1st 0xc3280090 inp (divinp) @ /usr/src/sys/modules/ipdivert/../../netinet/ip_divert.c:356
 > kernel: 2nd 0xc0bf0018 PFil hook read/write mutex (PFil hook read/write mutex) @ /usr/src/sys/net/pfil.c:73
 
 
 This looks very similar to
 http://sources.zabbadoz.net/freebsd/lor.html#181
 
 -- 
 Bjoern A. Zeeb                                 bzeeb at Zabbadoz dot NeT
 Software is harder than hardware  so better get it right the first time.
State-Changed-From-To: open->feedback 
State-Changed-By: kmacy 
State-Changed-When: Mon Nov 19 08:58:07 UTC 2007 
State-Changed-Why:  

Is this still an issue or a false positive? 


Responsible-Changed-From-To: freebsd-bugs->csjp 
Responsible-Changed-By: kmacy 
Responsible-Changed-When: Mon Nov 19 08:58:07 UTC 2007 
Responsible-Changed-Why:  

Is this still an issue or a false positive?  

http://www.freebsd.org/cgi/query-pr.cgi?pr=114237 
State-Changed-From-To: feedback->patched 
State-Changed-By: csjp 
State-Changed-When: Wed Nov 21 16:23:07 UTC 2007 
State-Changed-Why:  
We no longer hold pcb locks over ip_output() in divert. This has 
been fixed in HEAD and RELENG_7, and I am currently working on a 
patch to merge to RELENG_6.  It should be noted that the multicast 
code received a much needed facelift in CURRENT and RELENG_7 so 
the patch that gets merged will be a bit different. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114237 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Nov 15 16:54:43 UTC 2011 
State-Changed-Why:  
fixed a long time ago 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114237 
>Unformatted:
