From nobody@FreeBSD.org  Thu Jun 28 23:28:55 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 91F6B16A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 28 Jun 2007 23:28:55 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 8344913C45D
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 28 Jun 2007 23:28:55 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l5SNStNH077112
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 28 Jun 2007 23:28:55 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l5SNStXR077111;
	Thu, 28 Jun 2007 23:28:55 GMT
	(envelope-from nobody)
Message-Id: <200706282328.l5SNStXR077111@www.freebsd.org>
Date: Thu, 28 Jun 2007 23:28:55 GMT
From: Alan Grow <alangrow+b9d2265c@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ACPI kernel panic during S3 suspend / resume
X-Send-Pr-Version: www-3.0

>Number:         114113
>Category:       kern
>Synopsis:       [acpi] [patch] ACPI kernel panic during S3 suspend / resume
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-acpi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 28 23:30:09 GMT 2007
>Closed-Date:    Sun Apr 06 02:44:23 UTC 2008
>Last-Modified:  Sun Apr 06 02:44:23 UTC 2008
>Originator:     Alan Grow
>Release:        -CURRENT
>Organization:
>Environment:
FreeBSD host 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Thu Jun 28 16:09:35 EDT 2007     root@host:/usr/obj/usr/src/sys/HOST  i386
>Description:
A -CURRENT build from yesterday panics every time on S3 suspend / resume:

panic: _mtx_lock_sleep: recursed on non_recursive mutex acpi subsystem GPE lock @ ../../../dev/acpica/Osd/OsdSynch.c


>How-To-Repeat:
$ acpiconf -s 3
>Fix:
The tip-off is in sys/contrib/dev/acpica/CHANGES.txt: "All interfaces to the global lock now allow the same thread to acquire the lock multiple times." However, mtx_init() is still called without the MTX_RECURSE flag in sys/dev/acpica/Osd/OsdSynch.c. The following patch fixes it for me:


--- sys/dev/acpica/Osd/OsdSynch.c.orig	2007-06-28 18:35:07.000000000 -0400
+++ sys/dev/acpica/Osd/OsdSynch.c	2007-03-26 19:04:02.000000000 -0400
@@ -92,7 +92,7 @@
     if ((as = malloc(sizeof(*as), M_ACPISEM, M_NOWAIT | M_ZERO)) == NULL)
 	return_ACPI_STATUS (AE_NO_MEMORY);
 
-    mtx_init(&as->as_mtx, "ACPI semaphore", NULL, MTX_DEF | MTX_RECURSE);
+    mtx_init(&as->as_mtx, "ACPI semaphore", NULL, MTX_DEF);
     as->as_units = InitialUnits;
     as->as_maxunits = MaxUnits;
     as->as_pendings = as->as_resetting = as->as_timeouts = 0;
@@ -346,7 +346,7 @@
 	snprintf(h->name, sizeof(h->name), "acpi subsystem HW lock");
     else
 	snprintf(h->name, sizeof(h->name), "acpi subsys %p", OutHandle);
-    mtx_init(&h->lock, h->name, NULL, MTX_DEF | MTX_RECURSE);
+    mtx_init(&h->lock, h->name, NULL, MTX_DEF);
     *OutHandle = (ACPI_SPINLOCK)h;
     return (AE_OK);
 }

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-acpi 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jun 29 04:46:02 UTC 2007 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=114113 
State-Changed-From-To: open->closed 
State-Changed-By: takawata 
State-Changed-When: Sun Apr 6 02:42:51 UTC 2008 
State-Changed-Why:  
I encountered same problem, and fixed with the same way. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114113 
>Unformatted:
