From nobody@FreeBSD.org  Fri Jun 22 22:18:54 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4F78416A400
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jun 2007 22:18:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B2B113C448
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jun 2007 22:18:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l5MMIsoL089840
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jun 2007 22:18:54 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l5MMIr23089838;
	Fri, 22 Jun 2007 22:18:53 GMT
	(envelope-from nobody)
Message-Id: <200706222218.l5MMIr23089838@www.freebsd.org>
Date: Fri, 22 Jun 2007 22:18:53 GMT
From: Aaron Needles <aneedles@ieee.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: bstp_update_state() routine in net/bridgestp.c misuse "bp" in loop
X-Send-Pr-Version: www-3.0

>Number:         113958
>Category:       kern
>Synopsis:       bstp_update_state() routine in net/bridgestp.c misuse "bp" in loop
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    thompsa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 22 22:20:04 GMT 2007
>Closed-Date:    Fri Jun 29 00:36:39 GMT 2007
>Last-Modified:  Fri Jun 29 00:40:03 GMT 2007
>Originator:     Aaron Needles
>Release:        FreeBSD 6-STABLE (RELENG_6)
>Organization:
Schilling Robotics, LLC
>Environment:
N/A
>Description:
Source code issue.  Affect unknown.

Find bstp_update_state() routine in net/bridgestp.c

The following items...
bp->bp_role
bp->bp_synced

Should be changed to use bp2...
bp2->bp_role
bp2->bp_synced

.. otherwise, the code makes no sense.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->thompsa 
Responsible-Changed-By: thompsa 
Responsible-Changed-When: Fri Jun 22 22:44:27 UTC 2007 
Responsible-Changed-Why:  
Grab this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113958 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/113958: commit references a PR
Date: Fri, 22 Jun 2007 23:28:40 +0000 (UTC)

 thompsa     2007-06-22 23:28:33 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/net              bridgestp.c 
   Log:
   Check the correct port to see if synced is true.
   
   PR:             misc/113958
   Submitted by:   Aaron Needles
   Approved by:    re (bmah)
   MFC after:      1 week
   
   Revision  Changes    Path
   1.37      +2 -2      src/sys/net/bridgestp.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: thompsa 
State-Changed-When: Fri Jun 22 23:43:16 UTC 2007 
State-Changed-Why:  
Fixed in HEAD, thanks for the the PR! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113958 
State-Changed-From-To: patched->closed 
State-Changed-By: thompsa 
State-Changed-When: Fri Jun 29 00:35:57 UTC 2007 
State-Changed-Why:  
The change has been MFC'd. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113958 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/113958: commit references a PR
Date: Fri, 29 Jun 2007 00:35:44 +0000 (UTC)

 thompsa     2007-06-29 00:35:37 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/net              bridgestp.c 
   Log:
   MFC r1.37
     Check the correct port to see if synced is true.
   
   PR:             misc/113958
   Submitted by:   Aaron Needles
   
   Revision  Changes    Path
   1.3.2.12  +2 -2      src/sys/net/bridgestp.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
