From lab@gta.com  Thu May 31 19:55:51 2007
Return-Path: <lab@gta.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E3AF716A400
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 31 May 2007 19:55:50 +0000 (UTC)
	(envelope-from lab@gta.com)
Received: from gta.com (gta-edge-199-20.gta.com [199.120.225.20])
	by mx1.freebsd.org (Postfix) with SMTP id 7DA9C13C447
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 31 May 2007 19:55:50 +0000 (UTC)
	(envelope-from lab@gta.com)
Received: (qmail 52629 invoked by uid 1000); 31 May 2007 19:29:08 -0000
Message-Id: <20070531192908.52628.qmail@gta.com>
Date: 31 May 2007 19:29:08 -0000
From: Larry Baird <lab@gta.com>
Reply-To: Larry Baird <lab@gta.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: dcons module doesn't compile if "MODULES_WITH_WORLD=true" 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         113204
>Category:       kern
>Synopsis:       dcons module doesn't compile if "MODULES_WITH_WORLD=true"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    simokawa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 31 20:00:12 GMT 2007
>Closed-Date:    Fri Feb 29 03:13:14 UTC 2008
>Last-Modified:  Fri Feb 29 03:13:14 UTC 2008
>Originator:     Larry Baird
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD dragon.gta.com 6.2-STABLE FreeBSD 6.2-STABLE #0: Wed May 30 07:4
0:40 EDT 2007 root@dragon.gta.com:/usr/src/sys/i386/compile/DRAGON i386

	
>Description:
	if MODULES_WITH_WORLD=true then dcons doesn't compile during buildworld.
	
>How-To-Repeat:
	
	add "MODULES_WITH_WORLD=true" to /etc/make.conf
	cd /usr/src && make buildworld
>Fix:

	
	Patch is:

--- sys/modules/dcons/Makefile.orig     Thu May 31 15:22:38 2007
+++ sys/modules/dcons/Makefile  Thu May 31 15:25:53 2007
@@ -5,7 +5,8 @@
 
 KMOD   = dcons
 SRCS   = dcons.c dcons.h dcons_os.c dcons_os.h \
-               opt_dcons.h opt_ddb.h opt_comconsole.h
+               opt_dcons.h opt_ddb.h opt_comconsole.h \
+               opt_kdb.h opt_gdb.h
 
 .if !defined(KERNBUILDDIR)
 opt_ddb.h:
@@ -13,6 +14,12 @@
 
 opt_comconsole.h:
        echo "#define ALT_BREAK_TO_DEBUGGER 1" > $@
+
+opt_kdb.h:
+       echo "" > $@
+
+opt_gdb.h:
+       echo "" > $@
 .endif
 
 CFLAGS+= -I${.CURDIR}/../.. 



>Release-Note:
>Audit-Trail:

From: "Abdullah Ibn Hamad Al-Marri" <almarrie@gmail.com>
To: bug-followup@FreeBSD.org, "Larry Baird" <lab@gta.com>
Cc:  
Subject: Re: kern/113204: dcons module doesn't compile if "MODULES_WITH_WORLD=true"
Date: Thu, 31 May 2007 23:34:26 +0300

 Thank you Larry!
 
 This broke my -CURRENT as and so -STABLE.
 
 check http://www.freebsd.org/cgi/query-pr.cgi?pr=113199
 
 I use "MODULES_WITH_WORLD=true" in my make.conf too.
 
 I hope it will be fixed in -STABLE and -CURRENT ASAP.
 
 -- 
 Regards,
 
 -Abdullah Ibn Hamad Al-Marri
 Arab Portal
 http://www.WeArab.Net/
State-Changed-From-To: open->analyzed 
State-Changed-By: simokawa 
State-Changed-When: Thu May 31 22:45:50 UTC 2007 
State-Changed-Why:  
Thanks for the report. 
I'll commit a fix as soon as buildworld completes. 


Responsible-Changed-From-To: freebsd-bugs->simokawa 
Responsible-Changed-By: simokawa 
Responsible-Changed-When: Thu May 31 22:45:50 UTC 2007 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=113204 
State-Changed-From-To: analyzed->feedback 
State-Changed-By: simokawa 
State-Changed-When: Fri Jun 1 00:59:12 UTC 2007 
State-Changed-Why:  
A fix committed. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113204 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/113204: commit references a PR
Date: Fri,  1 Jun 2007 00:51:06 +0000 (UTC)

 simokawa    2007-06-01 00:50:59 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/modules/dcons    Makefile 
   Log:
   Fix a breakage with "MODULES_WITH_WORLD=true make buildworld".
   
   PR: kern/113204
   
   Revision  Changes    Path
   1.3.2.2   +5 -2      src/sys/modules/dcons/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Fri Feb 29 03:12:36 UTC 2008 
State-Changed-Why:  
A fix was committed by simokawa 2007-06-01. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113204 
>Unformatted:
