From shoesoft@gmx.net  Tue May 15 15:48:03 2007
Return-Path: <shoesoft@gmx.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A620116A405
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 May 2007 15:48:03 +0000 (UTC)
	(envelope-from shoesoft@gmx.net)
Received: from mx03.kabsi.at (mx03.kabsi.at [195.202.128.130])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E9CF13C44B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 May 2007 15:48:02 +0000 (UTC)
	(envelope-from shoesoft@gmx.net)
Received: from something.pepperland (h081217094222.dyn.cm.kabsi.at [81.217.94.222])
	by mx03.kabsi.at (8.13.6/8.13.6) with ESMTP id l4FFm0Ab030406
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 May 2007 17:48:01 +0200
Message-Id: <1179244081.41618@something.pepperland>
Date: Tue, 15 May 2007 17:48:01 +0200
From: "Stefan Ehmann" <shoesoft@gmx.net>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [sound] envy24 enables de-emphasis filter
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify:

>Number:         112688
>Category:       kern
>Synopsis:       [envy24] [patch] envy24 enables de-emphasis filter
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-multimedia
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 15 15:50:06 GMT 2007
>Closed-Date:    Sat May 19 11:07:49 GMT 2007
>Last-Modified:  Sat May 19 11:10:07 GMT 2007
>Originator:     Stefan Ehmann
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:


System: FreeBSD 7.0-CURRENT #126: Tue May  1 14:25:44 CEST 2007
    stefan@something.pepperland:/usr/obj/usr/src/sys/SOMETHING



>Description:


The current envy24 (and envy24ht) driver enables the AK452X de-emphasis filter.

This results in muffled sound because high frequencies are attenuated.

Discussed here:
http://lists.freebsd.org/pipermail/freebsd-multimedia/2007-January/005773.html

Sending this PR so it won't get lost (since it has never been commited).


>How-To-Repeat:





>Fix:


--- envy-diff begins here ---
--- envy24.c.orig	Tue May 15 17:24:32 2007
+++ envy24.c	Tue May 15 17:24:07 2007
@@ -859,7 +859,7 @@
 	spicds_setcif(ptr->info, ptr->parent->cfg->cif);
 	spicds_setformat(ptr->info,
 	    AK452X_FORMAT_I2S | AK452X_FORMAT_256FSN | AK452X_FORMAT_1X);
-	spicds_setdvc(ptr->info, 0);
+	spicds_setdvc(ptr->info, AK452X_DVC_DEMOFF);
 	/* for the time being, init only first codec */
 	if (ptr->num == 0)
 		spicds_init(ptr->info);
--- envy24ht.c.orig	Tue May 15 17:24:36 2007
+++ envy24ht.c	Tue May 15 17:24:12 2007
@@ -932,7 +932,7 @@
 	ptr->parent->cfg->type == SPICDS_TYPE_AK4528) {
 	spicds_setformat(ptr->info,
 	    AK452X_FORMAT_I2S | AK452X_FORMAT_256FSN | AK452X_FORMAT_1X);
-	spicds_setdvc(ptr->info, 0);
+	spicds_setdvc(ptr->info, AK452X_DVC_DEMOFF);
 	}
 
 	/* for the time being, init only first codec */
--- envy-diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-multimedia 
Responsible-Changed-By: remko 
Responsible-Changed-When: Tue May 15 18:05:20 UTC 2007 
Responsible-Changed-Why:  
reassign to multimedia team. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112688 
State-Changed-From-To: open->closed 
State-Changed-By: joel 
State-Changed-When: Sat May 19 11:07:23 UTC 2007 
State-Changed-Why:  
Patch committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112688 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/112688: commit references a PR
Date: Sat, 19 May 2007 11:06:51 +0000 (UTC)

 joel        2007-05-19 11:06:43 UTC
 
   FreeBSD src repository (doc committer)
 
   Modified files:
     sys/dev/sound/pci    envy24.c envy24ht.c 
   Log:
   Turn off the AK452X De-emphasis filter for 44.1KHz.  This should fix some
   sound quality problems.
   
   PR:             kern/112688
   Submitted by:   Stefan Ehmann <shoesoft@gmx.net>
   Reviewed by:    Konstantin Dimitrov <kosio.dimitrov@gmail.com>
   Approved by:    ariff
   
   Revision  Changes    Path
   1.12      +1 -1      src/sys/dev/sound/pci/envy24.c
   1.12      +1 -1      src/sys/dev/sound/pci/envy24ht.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
