From root@mx00.secion.net  Wed Apr 11 15:52:44 2007
Return-Path: <root@mx00.secion.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3B16016A406
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 11 Apr 2007 15:52:44 +0000 (UTC)
	(envelope-from root@mx00.secion.net)
Received: from fepb01-svc.webpage.t-com.de (mailbackup.webpage.t-com.de [80.152.31.31])
	by mx1.freebsd.org (Postfix) with ESMTP id A2B3713C468
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 11 Apr 2007 15:52:43 +0000 (UTC)
	(envelope-from root@mx00.secion.net)
Received: from [10.131.0.102] by mail.webpage.t-com.de InterMail with ESMTP
          id <20070411153159.VYLP327686.fepb01-svc.webpage.t-com.de@SMTPGateway>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Wed, 11 Apr 2007 17:31:59 +0200
Received: from mx00.secion.net (mx00.dmz.secion.de [192.168.13.250])
	by yxor.dmz.secion.de (Postfix) with ESMTP id ACB8222D6D
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 11 Apr 2007 17:31:53 +0200 (CEST)
Received: from localhost (localhost.dmz.secion.de [127.0.0.1])
	by mx00.secion.net (Postfix) with ESMTP id 71C2039C31
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 11 Apr 2007 17:31:53 +0200 (CEST)
Received: by mx00.secion.net (Postfix, from userid 0)
	id C5BF539893; Wed, 11 Apr 2007 17:31:47 +0200 (CEST)
Message-Id: <20070411155243.A2B3713C468@mx1.freebsd.org>
Date: Wed, 11 Apr 2007 17:31:47 +0200 (CEST)
From: Hellmuth Michaelis <hm@secion.de>
Reply-To: Hellmuth Michaelis <hm@secion.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: vmware3 port crashes under FreeBSD 6.2
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         111480
>Category:       kern
>Synopsis:       emulators/vmware3 port crashes under FreeBSD 6.2
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 11 16:00:09 GMT 2007
>Closed-Date:    Sun Jul 29 15:53:11 CEST 2007
>Last-Modified:  Sun Jul 29 14:00:05 GMT 2007
>Originator:     Hellmuth Michaelis
>Release:        FreeBSD 6.2
>Organization:
secion GmbH, Hamburg, Germany
>Environment:
        running Win XP Pro in vmware3 port on FreeBSD 6.2(-STABLE)

>Description:
        Since upgrading from FreeBSD 6.2-PRERELEASE (as of Nov, 8, 2006)
        to FreeBSD 6.2-STABLE FreeBSD 6.2-PRERELEASE 
        /usr/ports/emulators/vmware3 does not run anymore.
        The symptom is that running Windows XP Pro inside
        vmware3 produces the message:

        VMware Workstation Unrecoverable error: (VMX)
        NOT_IMPLEMENTED F(717):1423

        shortly after the initial (black) XP start screen 
        appears. This is reproducible.

        A similar report exists in http://docs.FreeBSD.org/cgi/mid.cgi?20070311020841.U34774
        As described in this report, disabling the
        network made vmware run again, enabling
        networking crashed it.

        I updated world, kernel, ports, same effect.

        When going back to the old 6.2-PRERELEASE kernel
        (same userland, ports etc) the vmware port runs again.

>How-To-Repeat:

        Run WXPPro in the vmware3 port under 6.2-STABLE.

>Fix:
        None yet.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->freebsd-ports-bugs 
Responsible-Changed-By: remko 
Responsible-Changed-When: Wed Apr 11 18:44:43 UTC 2007 
Responsible-Changed-Why:  
Reassign to the ports team since this initially is something under 
the ports tree; if there are more details that this has it's roots 
in the src/ tree, please return the ticket to -bugs with additional 
info so that we can try to resolve this (narrow down the reason 
as far as possible). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111480 

From: Hellmuth Michaelis <hm@secion.de>
To: bug-followup@freebsd.org
Cc: Remko Lodder <remko@freebsd.org>
Subject: Re: ports/111480: emulators/vmware3 port crashes under FreeBSD 6.2
Date: Mon, 23 Apr 2007 14:31:46 +0200

 Hi,
 
 over the weekend i narrowed the cause of this down: vmware3 under
 =46reeBSD stable as of March 4th runs but on FreeBSD stable as of
 March 5th does not run and crashes.
 
 =46urther investigation showed that the cause is the file=20
 /usr/src/sys/net/if_tap.c: with file file version
 
 $FreeBSD: src/sys/net/if_tap.c,v 1.55.2.8 2007/02/27 13:27:06 bms Exp $
 
 vmware runs, whereas with file versions=20
 
 $FreeBSD: src/sys/net/if_tap.c,v 1.55.2.9 2007/03/04 14:34:41 bms Exp $
 and
 $FreeBSD: src/sys/net/if_tap.c,v 1.55.2.10 2007/04/01 22:02:30 bms Exp $
 
 it crashes as described.
 
 I played a bit with the syctls introduced in the newer versions of
 if_tap but without any success regarding my problem.
 
 Btw: the error message in the vmware logfile is:
 
 Apr 23 13:59:05: VMX|Vnet_SetIFFlags ioctl: Inappropriate ioctl for device
 Apr 23 13:59:05: VMX|NOT_IMPLEMENTED F(717):1423
 
 Best regards,
 Hellmuth Michaelis
 =2D-=20
 Hellmuth Michaelis                      fon   +49 (0)40 - 389071-26
 Gesch=E4ftsf=FChrer                         mobil +49 (0)160 - 96455696
 secion GmbH                             fax   +49 (0)40 - 389071-19
 B=FClowstra=DFe 20                          mail  hm@secion.de
 22763 Hamburg                           www   http://www.secion.de/
 
 Die secion GmbH ist eingetragen beim Amtsgericht Hamburg HRB 91079
 Gesch=E4ftsf=FChrer sind Marcus Henschel und Hellmuth Michaelis
Responsible-Changed-From-To: freebsd-ports-bugs->bms 
Responsible-Changed-By: remko 
Responsible-Changed-When: Wed Apr 25 05:45:27 UTC 2007 
Responsible-Changed-Why:  
Hellmuth gave serious indications that this might be due to changes 
in if_tap, Bruce touched this last so Assign the ticket to him, 
can you have a look at this please bruce? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111480 
Responsible-Changed-From-To: bms->remko 
Responsible-Changed-By: bms 
Responsible-Changed-When: Wed Apr 25 06:55:44 UTC 2007 
Responsible-Changed-Why:  
ENOTIME to look at this; vmware is not something I use 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111480 

From: "Joerg Lehners" <Joerg.Lehners@Informatik.Uni-Oldenburg.DE>
To: bug-followup@FreeBSD.org, hm@secion.de
Cc:  
Subject: kern/111480: emulators/vmware3 port crashes under FreeBSD 6.2
Date: Wed, 18 Jul 2007 19:40:41 +0200 (MEST)

 Hello!
 
 I looked at this and found:
 
 with if_tap.c version 1.55.2.9 onwards if_tap seems to overtake
 some of the functionality of the vmnet kernel module:
 
 The logic behind
 
 #if defined(COMPAT_FREEBSD6) || defined(COMPAT_FREEBSD5) || \
      defined(COMPAT_FREEBSD4)
 
 seems to be ok, but ineffektiv, as if_tap.c does not include
 the files #defining COMPAT_FREEBSDX (opt_compat.h) when the kernel
 config has the 'options COMPAT_FREEBSDX' set.
 So the neccessary tapioctl() got invisible.
 
 A fast test with
 
 #if defined(COMPAT_FREEBSD6) || defined(COMPAT_FREEBSD5) || \
      defined(COMPAT_FREEBSD4) || 1
 
 (lines around 715 and 793) makes vmware3 work again on
 FreeBSD testido2 6.2-STABLE FreeBSD 6.2-STABLE #4: Wed Jul 18 19:18:42 MEST 2007
 
 So: make if_tap.c depending on the kernel framework for the
 COMPAT_FREEBSDX stuff to fix the error.
 
    Joerg
 -- 
 Mail: Joerg.Lehners@Informatik.Uni-Oldenburg.DE    Tel: 2198
 Real: Joerg Lehners, Informatik ARBI, Uni Oldenburg, D-26111 Oldenburg
 Unwoerter: Kostensenkung - Gewinnmaximierung - billig, billig, billig

From: "Joerg Lehners" <Joerg.Lehners@Informatik.Uni-Oldenburg.DE>
To: bug-followup@FreeBSD.org, hm@secion.de
Cc:  
Subject: Re: kern/111480: emulators/vmware3 port crashes under FreeBSD 6.2
Date: Thu, 19 Jul 2007 11:46:48 +0200 (MEST)

 Well, It seems the patch
 
 Index: net/if_tap.c
 ===================================================================
 RCS file: /home/user/joerg/BSD/FreeBSD-CVS/src/sys/net/if_tap.c,v
 retrieving revision 1.55.2.10
 diff -C2 -r1.55.2.10 if_tap.c
 *** net/if_tap.c        1 Apr 2007 22:02:30 -0000       1.55.2.10
 --- net/if_tap.c        19 Jul 2007 09:31:50 -0000
 ***************
 *** 36,39 ****
 --- 36,40 ----
     */
 
 + #include "opt_compat.h"
    #include "opt_inet.h"
 
 
 is sufficient.
 
    Joerg
 -- 
 Mail: Joerg.Lehners@Informatik.Uni-Oldenburg.DE    Tel: 2198
 Real: Joerg Lehners, Informatik ARBI, Uni Oldenburg, D-26111 Oldenburg
 Unwoerter: Kostensenkung - Gewinnmaximierung - billig, billig, billig

From: Hellmuth Michaelis <hm@secion.de>
To: "Joerg Lehners" <Joerg.Lehners@informatik.uni-oldenburg.de>
Cc: bug-followup@freebsd.org
Subject: Re: kern/111480: emulators/vmware3 port crashes under FreeBSD 6.2
Date: Fri, 27 Jul 2007 18:17:32 +0200

 Am Thursday 19 July 2007 schrieb Joerg Lehners:
 > 
 > Well, It seems the patch
 
 [ ... ]
 
 > + #include "opt_compat.h"
 >    #include "opt_inet.h"
 > 
 > is sufficient.
 
 Good work! On one system this patch seems to make vmware run
 again, will test it on another. It seems on stable just the #include
 was forgotten because it is present on current. In case all went
 well, i'll commit it to stable, ist this ok for you, Remko ?
 
 hellmuth
State-Changed-From-To: open->closed 
State-Changed-By: hm 
State-Changed-When: Sun Jul 29 15:48:49 CEST 2007 
State-Changed-Why:  
Verified correct operation, all ok! committed to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111480 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/111480: commit references a PR
Date: Sun, 29 Jul 2007 13:47:21 +0000 (UTC)

 hm          2007-07-29 13:47:13 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/net              if_tap.c 
   Log:
   PR:             kern/111480
   Submitted by:   Joerg Lehners, Joerg dot Lehners at Informatik dot Uni-Oldenburg dot DE
   
   add missing '#include "opt_compat.h"' (which is already present in current),
   so that kernel config options 'COMPAT_FREEBSD4' and 'COMPAT_FREEBSD5' are
   recognized again. this made the vmware3 port running under the linuxulator
   run again as usual.
   
   Revision   Changes    Path
   1.55.2.11  +1 -0      src/sys/net/if_tap.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:

Checked the fix non several machines running vmware3 port under
RELENG_6, runs fine! Joerg's fix committed to RELENG_6. 
Thanks again, Joerg!
