From nobody@FreeBSD.org  Sun Mar 25 15:19:42 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BC3A816A400
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Mar 2007 15:19:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id AD78C13C448
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Mar 2007 15:19:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l2PFJgA1057147
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Mar 2007 15:19:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l2PFEf8L056452;
	Sun, 25 Mar 2007 15:14:41 GMT
	(envelope-from nobody)
Message-Id: <200703251514.l2PFEf8L056452@www.freebsd.org>
Date: Sun, 25 Mar 2007 15:14:41 GMT
From: Paul Haddad<paul@pth.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: re driver doesn't properly support RTL8110SC
X-Send-Pr-Version: www-3.0

>Number:         110804
>Category:       kern
>Synopsis:       [re] re driver doesn't properly support RTL8110SC
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 25 15:20:01 GMT 2007
>Closed-Date:    Wed Apr 11 17:14:41 GMT 2007
>Last-Modified:  Wed Apr 11 17:20:07 GMT 2007
>Originator:     Paul Haddad
>Release:        pfSense 1.0.1/6.1 (but verified problem still exists in 6.2)
>Organization:
PTH Consulting
>Environment:
FreeBSD router.pth.prv 6.1-RELEASE-p15 FreeBSD 6.1-RELEASE-p15 #3: Sat Mar 17 23:09:48 UTC 2007     root@pfSense.local:/usr/obj.pfSense/usr/src/sys/pfSense_wrap.6  i386

>Description:
The Jetway AD3RTLANG (3 port RTL8110SC card) device isn't supported properly
in the RE driver.  It seems like the device is listed in if_reg.h but it
isn't matching the device.  The below is the pciconf for the device.


none0@pci0:9:0: class=0x020000 card=0x10ec16f3 chip=0x816910ec rev=0x10 hdr=0x00
    class    = network
    subclass = ethernet
none2@pci0:11:0:        class=0x020000 card=0x10ec16f3 chip=0x816910ec rev=0x10 hdr=0x00
    class    = network
    subclass = ethernet
none3@pci0:12:0:        class=0x020000 card=0x10ec16f3 chip=0x816910ec rev=0x10 hdr=0x00
    class    = network
    subclass = ethernet

This doesn't seem to match what the RE driver is looking for.  I've tried
to change the matching logic for the driver but haven't had any luck with this.
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:

From: linimon@lonesome.com (Mark Linimon)
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: kern/110804: re driver doesn't properly support RTL8110SC
Date: Mon, 26 Mar 2007 11:43:56 -0500

 Forwarded from email to freebsd-bugs.
 
 On Mon, Mar 26, 2007 at 01:52:18PM +0200, Daan Vreeken [PA4DAN] <Danovitsch@vitsch.net> wrote:
 > 
 > I stumbled upon this two weeks ago while setting up a new (mini-ITX) server 
 > for my company. The attached patch adds the correct ID's for the Realtek 
 > chips on the Jetway triple-gigabit expansion card.
 > After patching the kernel all three devices are properly detected and work 
 > like a charm.
 > 
 > This tiny patch was sponsoren by : Vitsch Electronics
 > 
 > pciconf, dmesg or any other information is available upon request.
 > 
 > grtz,
 > -- 
 > Daan
 
 > --- if_re.c~	Mon Jan  1 02:07:02 2007
 > +++ if_re.c	Mon Jan  1 02:11:38 2007
 > @@ -182,6 +182,8 @@
 >  		"RealTek 8169S Single-chip Gigabit Ethernet" },
 >  	{ RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8169_8110SB,
 >  		"RealTek 8169SB/8110SB Single-chip Gigabit Ethernet" },
 > +	{ RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8169_8110SC,
 > +		"RealTek 8169SC/8110SC Single-chip Gigabit Ethernet" },
 >  	{ RT_VENDORID, RT_DEVICEID_8169SC, RL_HWREV_8169_8110SC,
 >  		"RealTek 8169SC/8110SC Single-chip Gigabit Ethernet" },
 >  	{ RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8110S,
 > @@ -1219,7 +1221,9 @@
 >  	 * Allocate the parent bus DMA tag appropriate for PCI.
 >  	 */
 >  #define RL_NSEG_NEW 32
 > -	error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, 0,
 > +// DAAN Daan daan !!
 > +//	error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, 0,
 > +	error = bus_dma_tag_create(NULL, 1, 0,
 >  	    BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
 >  	    MAXBSIZE, RL_NSEG_NEW, BUS_SPACE_MAXSIZE_32BIT, 0,
 >  	    NULL, NULL, &sc->rl_parent_tag);
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Mon Mar 26 19:31:16 UTC 2007 
Responsible-Changed-Why:  
Ill take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110804 

From: "Daan Vreeken [PA4DAN]" <Danovitsch@vitsch.net>
To: remko@freebsd.org
Cc: Bug-Followup@freebsd.org
Subject: Re: misc/110804: re driver doesn't properly support RTL8110SC
Date: Tue, 27 Mar 2007 00:59:31 +0200

 On Monday 26 March 2007 21:30, Remko Lodder wrote:
 > Daan Vreeken [PA4DAN] wrote:
 > > On Sunday 25 March 2007 17:14, Paul Haddad wrote:
 > >>> Number:         110804
 > >>> Category:       misc
 > >>> Synopsis:       re driver doesn't properly support RTL8110SC
 > >>> Confidential:   no
 > >>> Severity:       serious
 > >>> Priority:       low
 > >>> Responsible:    freebsd-bugs
 > >>> State:          open
 > >>> Quarter:
 > >>> Keywords:
 > >>> Date-Required:
 > >>> Class:          sw-bug
 > >>> Submitter-Id:   current-users
 > >>> Arrival-Date:   Sun Mar 25 15:20:01 GMT 2007
 > >>> Closed-Date:
 > >>> Last-Modified:
 > >>> Originator:     Paul Haddad
 > >>> Release:        pfSense 1.0.1/6.1 (but verified problem still exists in
 > >>> 6.2) Organization:
 > >>
 > >> PTH Consulting
 > >>
 > >>> Environment:
 > >>
 > >> FreeBSD router.pth.prv 6.1-RELEASE-p15 FreeBSD 6.1-RELEASE-p15 #3: Sat
 > >> Mar 17 23:09:48 UTC 2007
 > >> root@pfSense.local:/usr/obj.pfSense/usr/src/sys/pfSense_wrap.6  i386
 > >>
 > >>> Description:
 > >>
 > >> The Jetway AD3RTLANG (3 port RTL8110SC card) device isn't supported
 > >> properly in the RE driver.  It seems like the device is listed in
 > >> if_reg.h but it isn't matching the device.  The below is the pciconf for
 > >> the device.
 > >>
 > >>
 > >> none0@pci0:9:0: class=0x020000 card=0x10ec16f3 chip=0x816910ec rev=0x10
 > >> hdr=0x00 class    = network
 > >>     subclass = ethernet
 > >> none2@pci0:11:0:        class=0x020000 card=0x10ec16f3 chip=0x816910ec
 > >> rev=0x10 hdr=0x00 class    = network
 > >>     subclass = ethernet
 > >> none3@pci0:12:0:        class=0x020000 card=0x10ec16f3 chip=0x816910ec
 > >> rev=0x10 hdr=0x00 class    = network
 > >>     subclass = ethernet
 > >>
 > >> This doesn't seem to match what the RE driver is looking for.  I've
 > >> tried to change the matching logic for the driver but haven't had any
 > >> luck with this.
 > >
 > > I stumbled upon this two weeks ago while setting up a new (mini-ITX)
 > > server for my company. The attached patch adds the correct ID's for the
 > > Realtek chips on the Jetway triple-gigabit expansion card.
 > > After patching the kernel all three devices are properly detected and
 > > work like a charm.
 > >
 > > This tiny patch was sponsoren by : Vitsch Electronics
 > >
 > > pciconf, dmesg or any other information is available upon request.
 > >
 > > grtz,
 > >
 > >
 > > ------------------------------------------------------------------------
 > >
 > > --- if_re.c~	Mon Jan  1 02:07:02 2007
 > > +++ if_re.c	Mon Jan  1 02:11:38 2007
 > > @@ -182,6 +182,8 @@
 > >  		"RealTek 8169S Single-chip Gigabit Ethernet" },
 > >  	{ RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8169_8110SB,
 > >  		"RealTek 8169SB/8110SB Single-chip Gigabit Ethernet" },
 > > +	{ RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8169_8110SC,
 > > +		"RealTek 8169SC/8110SC Single-chip Gigabit Ethernet" },
 > >  	{ RT_VENDORID, RT_DEVICEID_8169SC, RL_HWREV_8169_8110SC,
 > >  		"RealTek 8169SC/8110SC Single-chip Gigabit Ethernet" },
 > >  	{ RT_VENDORID, RT_DEVICEID_8169, RL_HWREV_8110S,
 > > @@ -1219,7 +1221,9 @@
 > >  	 * Allocate the parent bus DMA tag appropriate for PCI.
 > >  	 */
 > >  #define RL_NSEG_NEW 32
 > > -	error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, 0,
 > > +// DAAN Daan daan !!
 > > +//	error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, 0,
 > > +	error = bus_dma_tag_create(NULL, 1, 0,
 > >  	    BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
 > >  	    MAXBSIZE, RL_NSEG_NEW, BUS_SPACE_MAXSIZE_32BIT, 0,
 >
 > Hi Daan,
 >
 > was the hashed out bus_dma_tag_create also required for this patch
 > or is this a local change that should not get in actually?
 
 Oopsy, good catch :)
 The bus_dma_tag_create change is required to get the -CURRENT driver to 
 compile on stock 6.2-RELEASE sources. I should have removed it before sending 
 in the patch.
 
 Thanks,
 -- 
 Daan
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Wed Mar 28 18:07:30 UTC 2007 
State-Changed-Why:  
Patched in current! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110804 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/110804: commit references a PR
Date: Wed, 28 Mar 2007 18:07:19 +0000 (UTC)

 remko       2007-03-28 18:07:12 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/re           if_re.c 
   Log:
   Add support for the RTL8110SC driver.
   
   PR:             110804
   Submitted by:   Daan Vreeken
   Sponsored by:   Vitsch Electronics (patch)
   Approved by:    imp (mentor)
   MFC After:      3 days
   
   Revision  Changes    Path
   1.88      +2 -0      src/sys/dev/re/if_re.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Wed Apr 11 17:14:39 UTC 2007 
State-Changed-Why:  
MFC'ed to RELENG_6 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110804 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/110804: commit references a PR
Date: Wed, 11 Apr 2007 17:12:44 +0000 (UTC)

 remko       2007-04-11 17:12:38 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/dev/re           if_re.c 
   Log:
   MFC if_re.c rev 1.88
     Add support for the RTL8110SC driver.
   
     PR:             110804
     Submitted by:   Daan Vreeken
     Sponsored by:   Vitsch Electronics (patch)
     Approved by:    imp (mentor)
     MFC After:      3 days
   
   Approved by:    imp (mentor, implicit)
   
   Revision   Changes    Path
   1.46.2.26  +2 -0      src/sys/dev/re/if_re.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
