From nobody@FreeBSD.org  Fri Jan 19 13:50:22 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 55E1C16A40D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Jan 2007 13:50:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FFF313C455
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Jan 2007 13:50:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l0JDoA9i031377
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Jan 2007 13:50:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l0JDoATB031376;
	Fri, 19 Jan 2007 13:50:10 GMT
	(envelope-from nobody)
Message-Id: <200701191350.l0JDoATB031376@www.freebsd.org>
Date: Fri, 19 Jan 2007 13:50:10 GMT
From: Allan Kintigh<allank@nbs-inc.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ncurses sigabrt's in delscreen() because of free() of already free'd memory
X-Send-Pr-Version: www-3.0

>Number:         108117
>Category:       kern
>Synopsis:       ncurses sigabrt's in delscreen() because of free() of already free'd memory
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rafan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 19 14:00:38 GMT 2007
>Closed-Date:    Tue Apr 24 09:46:09 GMT 2007
>Last-Modified:  Tue Apr 24 09:46:09 GMT 2007
>Originator:     Allan Kintigh
>Release:        6.1-RELEASE, 6.2-RELEASE
>Organization:
National Bancard Services, Inc
>Environment:
FreeBSD developbsd.nbs 6.1-RELEASE FreeBSD 6.1-RELEASE #0: Sun May  7 04:42:56 UTC 2006  root@opus.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP  i386
>Description:
ncurses as distributed on 6.1-RELEASE and 6.2-RELEASE system has a
free() of already free'd memory in the delscreen() function causing an
error message to be sent to stderr and if running as root causes a
sigabrt to be sent to the process.  
>How-To-Repeat:
#include <time.h>
#include <curses.h>

/*
 * cc -o nc_test -lncurses ncurses.c
 */

int current_getch;
int doloop = 1;
static SCREEN *s;
static WINDOW *screen;

int now_sec, now_min, now_hour, now_day, now_wday, now_month, now_year;
time_t now;
struct tm *now_tm;

void screen_init(void) {
   s = newterm("vt100", stdout, stdin);
   set_term (s);
   noecho();
   cbreak();
   halfdelay(1);
   refresh(); // 1)
   screen = newwin(13, 27, 1, 1);
   box(screen, ACS_VLINE, ACS_HLINE);
}

static void update_display(void) {
   curs_set(0);
   mvwprintw(screen,1,1,"-------- HEADER --------");
   mvwprintw(screen,3,6,"TIME: %d:%d:%d", now_hour, now_min, now_sec);
   mvwprintw(screen,5,6,"DATE: %d-%d-%d", now_day, now_month, now_year);
   mvwprintw(screen,7,6,"PRESS q TO END");
   mvwprintw(screen,10,1,"-------- FOOTER --------");
   wrefresh(screen);
   refresh();
}

void screen_end(void) {
   delwin(screen);
   endwin();
   delscreen(s);
}

void maketime(void) {
        // Get the current date/time
        now = time (NULL);
        now_tm = localtime (&now);
        now_sec = now_tm->tm_sec;
        now_min = now_tm->tm_min;
        now_hour = now_tm->tm_hour;
        now_day = now_tm->tm_mday;
        now_wday = now_tm->tm_wday;
        now_month = now_tm->tm_mon + 1;
        now_year = now_tm->tm_year + 1900;
}

int main(void) {
   screen_init();
   while (doloop) {
      current_getch = getch();
      if (current_getch == 113) {
         doloop = 0;
      }
      maketime();
      update_display();
      sleep(1);
   }
   screen_end();
   printf("TEST ENDS\n");
   return 0;
}

>Fix:
The ncurses port fixes the issue, but the released system code should probably be fixed.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rafan 
Responsible-Changed-By: rodrigc 
Responsible-Changed-When: Sat Jan 20 18:10:46 UTC 2007 
Responsible-Changed-Why:  
rafan just updated ncurses in FreeBSD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108117 
State-Changed-From-To: open->feedback 
State-Changed-By: rafan 
State-Changed-When: Sun Jan 21 09:21:19 UTC 2007 
State-Changed-Why:  
Could you please try a recent current, which includes 
ncurses 5.6 in the base. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=108117 
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Apr 24 09:45:09 UTC 2007 
State-Changed-Why:  
Feedback timeout (3 months). 

If this is still a problem, please let us know and we can reopen it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108117 
>Unformatted:
