From nobody@FreeBSD.org  Wed Dec 13 07:54:43 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5322B16A4FB
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Dec 2006 07:54:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9B61643C9E
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Dec 2006 07:49:13 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id kBD7ofxg055123
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Dec 2006 07:50:41 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id kBD7oe1M055122;
	Wed, 13 Dec 2006 07:50:40 GMT
	(envelope-from nobody)
Message-Id: <200612130750.kBD7oe1M055122@www.freebsd.org>
Date: Wed, 13 Dec 2006 07:50:40 GMT
From: "Dr. Markus Waldeck"<waldeck@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum
X-Send-Pr-Version: www-3.0

>Number:         106657
>Category:       kern
>Synopsis:       [netinet] src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 13 08:00:18 GMT 2006
>Closed-Date:    Sun Dec 31 14:36:10 MST 2006
>Last-Modified:  Sun Dec 31 21:40:11 GMT 2006
>Originator:     Dr. Markus Waldeck
>Release:        7.0-CURRENT-200611
>Organization:
>Environment:
FreeBSD fbh 7.0-CURRENT-200611 FreeBSD 7.0-CURRENT-200611
root@fb:/usr/src/sys/i386/compile/FB70B01 i386
>Description:
I tried to figure out what is the purpose of net.inet.udp.checksum.

I found in src/sys/netinet/udp_usrreq.c following lines

#ifndef	COMPAT_42
static int	udpcksum = 1;
#else
static int	udpcksum = 0;		/* XXX */
#endif

I expect that net.inet.udp.checksum is a 4.2BSD compatibility feature.

But /* XXX */ is NOT a very sufficient comment!
>How-To-Repeat:
less src/sys/netinet/udp_usrreq.c
>Fix:
add a useful comment
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: imp 
State-Changed-When: Sun Dec 31 14:35:49 MST 2006 
State-Changed-Why:  
Fixed in current, no need to merge. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106657 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/106657: commit references a PR
Date: Sun, 31 Dec 2006 21:35:19 +0000 (UTC)

 imp         2006-12-31 21:34:53 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/netinet          udp_usrreq.c 
   Log:
   Add comment about udp checksums being off in BSD 4.2 compatibility mode.
   
   Submitted by: Dr. Markus Waldeck
   PR: kern/106657
   
   Revision  Changes    Path
   1.198     +8 -1      src/sys/netinet/udp_usrreq.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
