From seggers@semyam.dinoco.de Wed Mar 17 13:04:18 1999
Return-Path: <seggers@semyam.dinoco.de>
Received: from tim.xenologics.com (tim.xenologics.com [194.77.5.24])
	by hub.freebsd.org (Postfix) with ESMTP id 86B651539D
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 Mar 1999 13:04:15 -0800 (PST)
	(envelope-from seggers@semyam.dinoco.de)
Received: (from uucp@localhost)
	by tim.xenologics.com (8.8.5/8.8.8) with UUCP id WAA29853
	for FreeBSD-gnats-submit@freebsd.org; Wed, 17 Mar 1999 22:03:13 +0100 (MET)
Received: (from seggers@localhost)
	by semyam.dinoco.de (8.9.2/8.8.8) id WAA08338;
	Wed, 17 Mar 1999 22:00:40 +0100 (CET)
	(envelope-from seggers)
Message-Id: <199903172100.WAA08338@semyam.dinoco.de>
Date: Wed, 17 Mar 1999 22:00:40 +0100 (CET)
From: Stefan Eggers <seggers@semyam.dinoco.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: seggers@semyam.dinoco.de
Subject: exports(5) mentions KERBNFS but that's not in LINT
X-Send-Pr-Version: 3.2

>Number:         10642
>Category:       kern
>Synopsis:       exports(5) mentions KERBNFS but that's not in LINT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sheldonh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 17 13:10:01 PST 1999
>Closed-Date:    Fri Aug 11 06:13:44 PDT 2000
>Last-Modified:  Fri Aug 11 06:16:57 PDT 2000
>Originator:     Stefan Eggers
>Release:        FreeBSD 3.1-STABLE i386
>Organization:
none
>Environment:

	3.1-stable from about three weeks ago.

>Description:

	exports(5) mentions a kernel option KERBNFS (it really exists)
but this options is not even mentioned in a comment in LINT.  I think
it would be a good idea to add a line "options KERBNFS" to LINT with a
small comment to what it does as that way it gets a bit more attention
and maybe more people make use of it.

>How-To-Repeat:
>Fix:

>Release-Note:
>Audit-Trail:

From: Johan Karlsson <k@numeri.campus.luth.se>
To: freebsd-gnats-submit@FreeBSD.org
Cc: seggers@semyam.dinoco.de, dfr@FreeBSD.org
Subject: Re: kern/10642: exports(5) mentions KERBNFS but that's not in LINT
Date: Wed, 09 Aug 2000 22:32:56 +0200

 Hi while poking around among the PRs I found this PR.
 
 The option is called NFSKERB _but_,
 
 I found in src/sys/nfs/nfs_socket.c from rev 1.8 that
 this option is unimplemented and should therefore not be 
 visible in LINT.
 
 ==== src/sys/nfs/nfs_socket.c ===
 1297: #ifdef NFSKERB
 1298:                        XXX
 1299: #endif
 
 Using this option would make the kernel not compile.
 
 
 
 Doug, you intorduced the code in question.
 Do you this this ever will be implemented?
 
 If not I think it should be removed along with the reference 
 in exports(5).
 
 Thanks
 Johan K
 
 
 

From: Doug Rabson <dfr@nlsystems.com>
To: Johan Karlsson <k@numeri.campus.luth.se>
Cc: freebsd-gnats-submit@FreeBSD.org, seggers@semyam.dinoco.de,
	dfr@FreeBSD.org
Subject: Re: kern/10642: exports(5) mentions KERBNFS but that's not in LINT
Date: Thu, 10 Aug 2000 09:24:57 +0100 (BST)

 On Wed, 9 Aug 2000, Johan Karlsson wrote:
 
 > 
 > Hi while poking around among the PRs I found this PR.
 > 
 > The option is called NFSKERB _but_,
 > 
 > I found in src/sys/nfs/nfs_socket.c from rev 1.8 that
 > this option is unimplemented and should therefore not be 
 > visible in LINT.
 > 
 > ==== src/sys/nfs/nfs_socket.c ===
 > 1297: #ifdef NFSKERB
 > 1298:                        XXX
 > 1299: #endif
 > 
 > Using this option would make the kernel not compile.
 > 
 > 
 > 
 > Doug, you intorduced the code in question.
 > Do you this this ever will be implemented?
 > 
 > If not I think it should be removed along with the reference 
 > in exports(5).
 
 That is a marker to point out code which was removed to allow the code in
 question to be exported. It shouldn't be removed (unless all of the
 NFSKERB code is being removed) since it needs to be replaced with an
 appropriate call to an encryption routine.
 
 -- 
 Doug Rabson				Mail:  dfr@nlsystems.com
 Nonlinear Systems Ltd.			Phone: +44 20 8348 3944
 
 
 

From: Johan Karlsson <k@numeri.campus.luth.se>
To: Doug Rabson <dfr@nlsystems.com>
Cc: freebsd-gnats-submit@FreeBSD.org, seggers@semyam.dinoco.de,
	dfr@FreeBSD.org
Subject: Re: kern/10642: exports(5) mentions KERBNFS but that's not in LINT 
Date: Thu, 10 Aug 2000 13:20:53 +0200

 At Thu, 10 Aug 2000 09:24:57 BST, Doug Rabson wrote:
 > On Wed, 9 Aug 2000, Johan Karlsson wrote:
 > > ==== src/sys/nfs/nfs_socket.c ===
 > > 1297: #ifdef NFSKERB
 > > 1298:                        XXX
 > > 1299: #endif
 > > 
 > > Using this option would make the kernel not compile.
 > > 
 > > If not I think it should be removed along with the reference 
 > > in exports(5).
 > 
 > That is a marker to point out code which was removed to allow the code in
 > question to be exported. It shouldn't be removed (unless all of the
 > NFSKERB code is being removed) since it needs to be replaced with an
 > appropriate call to an encryption routine.
 > 
 
 Ok, thanks for the explanation.
 
 What do you think about removing the reference in exports(5) or at least 
 adding something like
 
 "Using this option will make the kernel not compile, if one do not also 
 take care of adding calls to the appropriate kerberos encryption routins 
 in the NFS source."
 
 
 /Johan K
 
 

From: Doug Rabson <dfr@nlsystems.com>
To: Johan Karlsson <k@numeri.campus.luth.se>
Cc: freebsd-gnats-submit@FreeBSD.org, seggers@semyam.dinoco.de,
	dfr@FreeBSD.org
Subject: Re: kern/10642: exports(5) mentions KERBNFS but that's not in LINT
Date: Fri, 11 Aug 2000 09:25:54 +0100 (BST)

 On Thu, 10 Aug 2000, Johan Karlsson wrote:
 
 > At Thu, 10 Aug 2000 09:24:57 BST, Doug Rabson wrote:
 > > On Wed, 9 Aug 2000, Johan Karlsson wrote:
 > > > ==== src/sys/nfs/nfs_socket.c ===
 > > > 1297: #ifdef NFSKERB
 > > > 1298:                        XXX
 > > > 1299: #endif
 > > > 
 > > > Using this option would make the kernel not compile.
 > > > 
 > > > If not I think it should be removed along with the reference 
 > > > in exports(5).
 > > 
 > > That is a marker to point out code which was removed to allow the code in
 > > question to be exported. It shouldn't be removed (unless all of the
 > > NFSKERB code is being removed) since it needs to be replaced with an
 > > appropriate call to an encryption routine.
 > > 
 > 
 > Ok, thanks for the explanation.
 > 
 > What do you think about removing the reference in exports(5) or at least 
 > adding something like
 > 
 > "Using this option will make the kernel not compile, if one do not also 
 > take care of adding calls to the appropriate kerberos encryption routins 
 > in the NFS source."
 
 That sounds about right.
 
 -- 
 Doug Rabson				Mail:  dfr@nlsystems.com
 Nonlinear Systems Ltd.			Phone: +44 20 8348 3944
 
 
 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Johan Karlsson <k@numeri.campus.luth.se>
Cc: Doug Rabson <dfr@nlsystems.com>, freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/10642: exports(5) mentions KERBNFS but that's not in LINT 
Date: Fri, 11 Aug 2000 12:15:17 +0200

 On Fri, 11 Aug 2000 11:12:05 +0200, Johan Karlsson wrote:
 
 > +Using this option will make the kernel not compile, if one do not also 
 > +take care of adding calls to the appropriate Kerberos encryption routines 
 > +in the NFS source.
 
 Rather this, which addresses the grammar and the line breaking style:
 
 The use of this option will prevent the kernel from compiling
 unless calls to the appropriate Kerberos encryption routines
 are provided in the NFS source.
 
 I wonder whether it'd be a good idea to provide paths to the affected
 source files?
 
 Ciao,
 Sheldon.
 

From: Johan Karlsson <k@numeri.campus.luth.se>
To: Sheldon Hearn <sheldonh@uunet.co.za>
Cc: Doug Rabson <dfr@nlsystems.com>, freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/10642: exports(5) mentions KERBNFS but that's not in LINT 
Date: Fri, 11 Aug 2000 13:37:21 +0200

 At Fri, 11 Aug 2000 12:15:17 +0200, Sheldon Hearn wrote:
 > I wonder whether it'd be a good idea to provide paths to the affected
 > source files?
 
 The files using the option are:
 sys/nfs/nfs_nqlease.c
 sys/nfs/nfs_socket.c
 sys/nfs/nfs_syscalls.c
 sys/nfs/rpcv2.h
 sbin/mount_nfs/mount_nfs.c
 sbin/nfsd/nfsd.c
 
 where implementation is missing in:
 sys/nfs/nfs_socket.c
 sys/nfs/nfs_syscalls.c
 sys/nfs/rpcv2.h
 
 
 However, since sbin/munt_nfs and sbin/nfsd uses the option
 they will also need to be recompiled.
 
 /Johan K
 
 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Johan Karlsson <k@numeri.campus.luth.se>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/10642: exports(5) mentions KERBNFS but that's not in LINT 
Date: Fri, 11 Aug 2000 14:33:28 +0200

 On Fri, 11 Aug 2000 04:40:03 MST, Johan Karlsson wrote:
 
 >  However, since sbin/munt_nfs and sbin/nfsd uses the option
 >  they will also need to be recompiled.
 
 Hmmm, probably just to use the generic text, then.
 
 Ciao,
 Sheldon.
 
Responsible-Changed-From-To: freebsd-bugs->sheldonh 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Fri Aug 11 05:55:15 PDT 2000 
Responsible-Changed-Why:  
I'll take this one. 
State-Changed-From-To: open->closed 
State-Changed-By: sheldonh 
State-Changed-When: Fri Aug 11 06:13:44 PDT 2000 
State-Changed-Why:  
Explanation added in both HEAD and RELENG_4. 
>Unformatted:
