From nike_d@tormentor.totalterror.net  Fri Dec  1 08:16:26 2006
Return-Path: <nike_d@tormentor.totalterror.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 313BE16A403
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  1 Dec 2006 08:16:26 +0000 (UTC)
	(envelope-from nike_d@tormentor.totalterror.net)
Received: from sellinet.net (galileo.sellinet.net [82.199.192.2])
	by mx1.FreeBSD.org (Postfix) with SMTP id 738C443C9D
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  1 Dec 2006 08:16:11 +0000 (GMT)
	(envelope-from nike_d@tormentor.totalterror.net)
Received: (qmail 19856 invoked by uid 1009); 1 Dec 2006 10:16:22 +0200
Received: from nike_d@tormentor.totalterror.net by galileo by uid 1002 with qmail-scanner-1.22 
 (spamassassin: 3.0.3.  Clear:RC:1(82.199.197.152):. 
 Processed in 0.029227 secs); 01 Dec 2006 08:16:22 -0000
Received: from unknown (HELO tormentor.totalterror.net) (82.199.197.152)
  by galileo.sellinet.net with SMTP; 1 Dec 2006 10:16:22 +0200
Received: (qmail 30298 invoked by uid 1001); 1 Dec 2006 08:16:22 -0000
Message-Id: <20061201081622.30297.qmail@tormentor.totalterror.net>
Date: 1 Dec 2006 08:16:22 -0000
From: Niki Denev <niki@totalterror.net>
Reply-To: Niki Denev <niki@totalterror.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: libalias treats every line in /etc/libalias.conf as loadable module (even the comments)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         106112
>Category:       kern
>Synopsis:       [libalias] [patch] libalias treats every line in /etc/libalias.conf as loadable module (even the comments)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    piso
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 01 08:20:22 GMT 2006
>Closed-Date:    Sat Dec 02 12:48:07 GMT 2006
>Last-Modified:  Sat Dec 02 12:48:07 GMT 2006
>Originator:     Niki Denev <niki@totalterror.net>, <nike_d@cytexbg.com>
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD phobos.totalterror.net 7.0-CURRENT FreeBSD 7.0-CURRENT #13: Wed Nov 15 07:10:16 EET 2006 nike_d@phobos.totalterror.net:/usr/src/sys/i386/compile/PHOBOS i386


>Description:
	The new libalias treats every line in /etc/libalias.conf as loadable module (even the comments),
	and tries to load them one by one.

>How-To-Repeat:
	Starting 'ppp' for example will try to load the modules defined in /etc/libalias.conf,
	and it will complain about problems loading the first line in the file, which is the 
	comment line holding the file $FreeBSD Id.
>Fix:
	A probably not very complete fix because it will skip only lines starting with '#', but will
	fail to detect those with leading whitespace. Anyway here it is :


--- /usr/src/sys/netinet/libalias/alias.c.orig	Wed Nov 22 21:35:58 2006
+++ /usr/src/sys/netinet/libalias/alias.c	Wed Nov 22 21:35:20 2006
@@ -1506,6 +1506,7 @@
 		        break;
 		len = strlen(buf);
 		if (len > 1) {
+			if (buf[0] == '#') continue;
 			buf[len - 1] = '\0';
 			printf("Loading %s\n", buf);
 			LibAliasLoadModule(buf);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->piso 
Responsible-Changed-By: ru 
Responsible-Changed-When: Fri Dec 1 08:56:04 UTC 2006 
Responsible-Changed-Why:  
Known issue; over to the author. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106112 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/106112: commit references a PR
Date: Sat,  2 Dec 2006 10:30:37 +0000 (UTC)

 piso        2006-12-02 10:30:23 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/netinet/libalias alias.c 
   Log:
   Forced commit to use the correct PR syntax.
   
   PR:             kern/106112
   Noted by:       ru
   
   Revision  Changes    Path
   1.57      +0 -0      src/sys/netinet/libalias/alias.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 	 
State-Changed-By: piso 
State-Changed-When: Sat Dec 2 12:40:15 UTC 2006 
State-Changed-Why:  

sys/netinet/libalias/alias.c Rev. 1.56 fixes it. Bug no present in RELENG_XX. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=106112 
>Unformatted:
