From nobody@FreeBSD.org  Fri Dec  1 01:45:21 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1CD6716A5C9
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Dec 2006 01:45:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C6CBD43C9D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  1 Dec 2006 01:45:09 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id kB11jKs3024327
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 1 Dec 2006 01:45:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id kB11jJbI024306;
	Fri, 1 Dec 2006 01:45:19 GMT
	(envelope-from nobody)
Message-Id: <200612010145.kB11jJbI024306@www.freebsd.org>
Date: Fri, 1 Dec 2006 01:45:19 GMT
From: Shun-ichi Kobayashi<koba@mbox.kudpc.kyoto-u.ac.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300
X-Send-Pr-Version: www-3.0

>Number:         106104
>Category:       kern
>Synopsis:       [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ariff
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 01 01:50:14 GMT 2006
>Closed-Date:    Sun Dec 24 06:03:03 GMT 2006
>Last-Modified:  Sun Dec 24 06:03:03 GMT 2006
>Originator:     Shun-ichi Kobayashi
>Release:        FreeBSD 6.2-PRERELEASE i386
>Organization:
Kyoto University
>Environment:
[uname -a]
FreeBSD *.vlan.kuins.net 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #0: Tue Nov 28 19:05:07 JST 2006    


>Description:
It is already known that some machines that uses ich(4) sound driver must turn on inverted external amplifier sense flag individually. See: Rev. 1.57 and Rev. 1.58 (I also referred an email entitled "kern/94056:[PATCH] ..." in freebsd-bugs ML)

My machine HP Compaq nx 4300 also requires this.

[machine]
HP Compaq nx 4300

[pciconf -vl]
pcm0@pci0:30:2: class=0x040100 card=0x309a103c chip=0x266e8086 rev=0x04 hdr=0x00
    vendor   = 'Intel Corporation'
    device   = '82801FB/FR/FW/FRW AC '97 Audio Controller'
    class    = multimedia
    subclass = audio

>How-To-Repeat:

>Fix:
I made a simple patch for this bug. I will follow up via email.
>Release-Note:
>Audit-Trail:

From: "Kobayashi Shun-ichi" <koba@mbox.kudpc.kyoto-u.ac.jp>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/106104: [PATCH] Turn on inverted external amplifier sense flags for HP Compaq nx 4300
Date: Fri, 1 Dec 2006 11:20:07 +0900

 ------=_Part_21237_4533916.1164939607095
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 >Number:	106104
 >Category:	kern
 >Synopsis:	[PATCH] Turn on inverted external amplifier sense flags for
 HP Compaq nx 4300
 >Severity:	serious
 >Priority:	medium
 >Responsible:	freebsd-bugs@FreeBSD.org
 >State:	open
 >Class:	sw-bug
 >Arrival-Date:	Fri Dec 01 01:50:14 GMT 2006
 >Closed-Date:	
 >Last-Modified:	never
 >Originator:	Shun-ichi Kobayashi
 >Release:	FreeBSD 6.2-PRERELEASE i386
 
 >Description:
 
 It is already known that some machines that uses ich(4) sound driver
 must turn on inverted external amplifier sense flag individually. See:
 Rev. 1.57 and Rev. 1.58 (I also referred an email entitled
 "kern/94056:[PATCH] ..." in freebsd-bugs ML)
 
 My machine HP Compaq nx 4300 also requires this.
 
 [machine]
 HP Compaq nx 4300
 
 [pciconf -vl]
 pcm0@pci0:30:2: class=0x040100 card=0x309a103c chip=0x266e8086 rev=0x04 hdr=0x00
 vendor = 'Intel Corporation'
 device = '82801FB/FR/FW/FRW AC '97 Audio Controller'
 class = multimedia
 subclass = audio
 
 >How-To-Repeat:
 
 >Fix:
 I attached a simple patch file for this bug to this email.
 
 Original file is
  /usr/src/sys/dev/sound/pci/ich.c,v 1.53.2.8 2006/08/22 02:37:03
 
 Attached patch file is named as ich.c.diff (created by diff -c)
 
 Here is a copied and pasted version for your reference.
 
 *** /usr/src/sys/dev/sound/pci/ich.c.orig       Tue Nov 28 18:48:52 2006
 --- /usr/src/sys/dev/sound/pci/ich.c    Fri Dec  1 10:41:07 2006
 ***************
 *** 851,856 ****
 --- 851,857 ----
         case 0x81c0104d:        /* Sony VAIO type T */
         case 0x81c5104d:        /* Sony VAIO VGN B1VP/B1XP */
         case 0x3089103c:        /* Compaq Presario B3800 */
 +         case 0x309a103c:        /* HP Compaq nx4300 */
                 ac97_setflags(sc->codec, ac97_getflags(sc->codec) |
 AC97_F_EAPD_INV);
                 break;
         default:
 
 ------=_Part_21237_4533916.1164939607095
 Content-Type: application/octet-stream; name=ich.c.diff
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_ev5ysf5c
 Content-Disposition: attachment; filename="ich.c.diff"
 
 KioqIC91c3Ivc3JjL3N5cy9kZXYvc291bmQvcGNpL2ljaC5jLm9yaWcJVHVlIE5vdiAyOCAxODo0
 ODo1MiAyMDA2Ci0tLSAvdXNyL3NyYy9zeXMvZGV2L3NvdW5kL3BjaS9pY2guYwlGcmkgRGVjICAx
 IDEwOjQxOjA3IDIwMDYKKioqKioqKioqKioqKioqCioqKiA4NTEsODU2ICoqKioKLS0tIDg1MSw4
 NTcgLS0tLQogIAljYXNlIDB4ODFjMDEwNGQ6CS8qIFNvbnkgVkFJTyB0eXBlIFQgKi8KICAJY2Fz
 ZSAweDgxYzUxMDRkOgkvKiBTb255IFZBSU8gVkdOIEIxVlAvQjFYUCAqLwogIAljYXNlIDB4MzA4
 OTEwM2M6CS8qIENvbXBhcSBQcmVzYXJpbyBCMzgwMCAqLworICAgICAgICAgY2FzZSAweDMwOWEx
 MDNjOiAgICAgICAgLyogSFAgQ29tcGFxIG54NDMwMCAqLwogIAkJYWM5N19zZXRmbGFncyhzYy0+
 Y29kZWMsIGFjOTdfZ2V0ZmxhZ3Moc2MtPmNvZGVjKSB8IEFDOTdfRl9FQVBEX0lOVik7CiAgCQli
 cmVhazsKICAJZGVmYXVsdDoK
 ------=_Part_21237_4533916.1164939607095--
Responsible-Changed-From-To: freebsd-bugs->ariff 
Responsible-Changed-By: ariff 
Responsible-Changed-When: Fri Dec 1 06:22:58 UTC 2006 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106104 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/106104: commit references a PR
Date: Fri,  1 Dec 2006 06:53:29 +0000 (UTC)

 ariff       2006-12-01 06:53:14 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/sound/pci    ich.c 
   Log:
   Add inverted amplifier sense quirk for HP Compaq nx4300.
   
   PR:             kern/106104
   Submitted by:   Shun-ichi Kobayashi <koba@mbox.kudpc.kyoto-u.ac.jp>
   MFC after:      3 days
   
   Revision  Changes    Path
   1.69      +1 -0      src/sys/dev/sound/pci/ich.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: ariff 
State-Changed-When: Fri Dec 1 15:38:04 UTC 2006 
State-Changed-Why:  
Committed to HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106104 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/106104: commit references a PR
Date: Sun, 24 Dec 2006 05:44:26 +0000 (UTC)

 ariff       2006-12-24 05:44:11 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/dev/sound/pci    ich.c 
   Log:
   MFC:
   
   Add inverted amplifier sense quirk for HP Compaq nx4300 and few
   NEC VersaPro.
   
   PR:             kern/106104, kern/104715
   Submitted by:   Shun-ichi Kobayashi <koba@mbox.kudpc.kyoto-u.ac.jp>
                   KAWATA Masahiko <kawata@mta.biglobe.ne.jp>
   
   Add support for Nvidia Nforce MCP04 AC97 controller.
   
   PR:             kern/106829
   Submitted by:   Frdric Petit <fredantispam@free.fr>
   
   Revision  Changes    Path
   1.53.2.9  +6 -0      src/sys/dev/sound/pci/ich.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/106104: commit references a PR
Date: Sun, 24 Dec 2006 05:44:59 +0000 (UTC)

 ariff       2006-12-24 05:44:47 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6_2)
     sys/dev/sound/pci    ich.c 
   Log:
   MFC:
   
   Add inverted amplifier sense quirk for HP Compaq nx4300 and few
   NEC VersaPro.
   
   PR:             kern/106104, kern/104715
   Submitted by:   Shun-ichi Kobayashi <koba@mbox.kudpc.kyoto-u.ac.jp>
                   KAWATA Masahiko <kawata@mta.biglobe.ne.jp>
   
   Add support for Nvidia Nforce MCP04 AC97 controller.
   
   PR:             kern/106829
   Submitted by:   Frdric Petit <fredantispam@free.fr>
   
   Approved by:    re (kensmith)
   
   Revision      Changes    Path
   1.53.2.8.2.1  +6 -0      src/sys/dev/sound/pci/ich.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: ariff 
State-Changed-When: Sun Dec 24 06:02:17 UTC 2006 
State-Changed-Why:  
Fix committed to both RELENG_6 and 6_2. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106104 
>Unformatted:
