From nobody@FreeBSD.org  Mon Oct  9 14:15:54 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 61A8116A412
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  9 Oct 2006 14:15:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 151AF43D76
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  9 Oct 2006 14:15:50 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k99EFnNZ098330
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 9 Oct 2006 14:15:49 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k99EFncZ098329;
	Mon, 9 Oct 2006 14:15:49 GMT
	(envelope-from nobody)
Message-Id: <200610091415.k99EFncZ098329@www.freebsd.org>
Date: Mon, 9 Oct 2006 14:15:49 GMT
From: Shuichi KITAGUCHI<kit@ysnb.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] support for Kuroutoshikou SERIAL4P-LPPCI2 (4port serial card)
X-Send-Pr-Version: www-3.0

>Number:         104212
>Category:       kern
>Synopsis:       [puc] [patch] support for Kuroutoshikou SERIAL4P-LPPCI2 (4port serial card)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jhb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 09 14:20:16 GMT 2006
>Closed-Date:    Wed Jun 08 21:14:54 UTC 2011
>Last-Modified:  Wed Jun 08 21:14:54 UTC 2011
>Originator:     Shuichi KITAGUCHI
>Release:        6.2-PRERELEASE
>Organization:
>Environment:
FreeBSD themis.k.ysnb.net 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #1: Sat Oct  7 02:21:33 JST 2006     root@themis.k.ysnb.net:/pub/obj/usr/src/sys/THEMIS  i386
>Description:
Kuroutoshikou SERIAL4P-LPPCI2 (http://www.kuroutoshikou.com/modules/display/?iid=173) seems to use Oxford Semiconductor Ltd OX16PCI954, but default configuration does not work.

modified pucddata.c which config is copied from "SIIG Cyber 4S PCI 16C650 (20x family)" works well for me. please apply an attached patch.
>How-To-Repeat:
boot 6-STABLE with SERIAL4P-LPPCI2.

dmesg is here:
puc0: <Oxford Semiconductor OX16PCI954 UARTs> port 0x9000-0x901f,0x9400-0x941f mem 0xe4061000-0xe4061fff,0xe4062000-0xe4062fff irq 7 at device 4.0 on pci1
puc0: Reserved 0x20 bytes for rid 0x10 type 4 at 0x9000
sio2: <Oxford Semiconductor OX16PCI954 UARTs> on puc0
sio2: type 16550A (multiport master)
sio2: unable to activate interrupt in fast mode - using normal mode
sio3: <Oxford Semiconductor OX16PCI954 UARTs> on puc0
sio3: type 16550A (multiport)
sio3: unable to activate interrupt in fast mode - using normal mode
sio4: <Oxford Semiconductor OX16PCI954 UARTs> on puc0
sio4: type 16550A (multiport)
sio4: unable to activate interrupt in fast mode - using normal mode
sio5: <Oxford Semiconductor OX16PCI954 UARTs> on puc0
sio5: type 16550A (multiport)
sio5: unable to activate interrupt in fast mode - using normal mode

pciconv -lv is here:
puc0@pci1:4:0:  class=0x070006 card=0x215014db chip=0x95011415 rev=0x00 hdr=0x00
    vendor   = 'Oxford Semiconductor Ltd'
    device   = 'OX16PCI954 Quad UART'
    class    = simple comms
    subclass = UART

>Fix:
patch for 6-STABLE is here:

--- pucdata.c.orig	Sat Sep  9 00:06:31 2006
+++ pucdata.c	Sat Oct  7 02:14:20 2006
@@ -876,6 +876,18 @@
 	    },
 	},
 
+	/* Kuroutoshikou SERIAL4P-LPPCI2 */
+	{   "Kuroutoshikou SERIAL4P-LPPCI2",
+	    {	0x1415,	0x9501,	0x14db,	0x2150	},
+	    {	0xffff,	0xffff,	0xffff,	0xffff	},
+	    {
+		{ PUC_PORT_TYPE_COM, 0x10, 0x00, COM_FREQ * 10 },
+		{ PUC_PORT_TYPE_COM, 0x10, 0x08, COM_FREQ * 10 },
+		{ PUC_PORT_TYPE_COM, 0x10, 0x10, COM_FREQ * 10 },
+		{ PUC_PORT_TYPE_COM, 0x10, 0x18, COM_FREQ * 10 },
+	    },
+	},
+
 	/* Oxford Semiconductor OX16PCI954 PCI UARTs */
 	{   "Oxford Semiconductor OX16PCI954 UARTs",
 	    {	0x1415,	0x9501,	0,	0	},

patch for -CURRENT is here: (not tested)

--- pucdata.c.orig	Fri Sep  8 23:43:41 2006
+++ pucdata.c	Mon Oct  9 22:45:10 2006
@@ -596,6 +596,12 @@
 	    PUC_PORT_4S, 0x10, 0, 8,
 	},
 
+	{   0x1415, 0x9501, 0x14db, 0x2150,
+	    "Kuroutoshikou SERIAL4P-LPPCI2",
+	    DEFAULT_RCLK * 10,
+	    PUC_PORT_4S, 0x10, 0, 8,
+	},
+
 	{   0x1415, 0x9501, 0xffff, 0,
 	    "Oxford Semiconductor OX16PCI954 UARTs",
 	    DEFAULT_RCLK,

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: thompsa 
State-Changed-When: Fri Aug 22 00:03:03 UTC 2008 
State-Changed-Why:  
This device is present in pucdata.c on HEAD, awaiting MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104212 

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, kit@ysnb.net, 
 Andrew Thompson <thompsa@FreeBSD.org>
Cc:  
Subject: Re: kern/104212: [puc] [patch] support for Kuroutoshikou SERIAL4P-LPPCI2
 (4port serial card)
Date: Thu, 28 Apr 2011 14:09:02 -0400

 Hmm, it doesn't look like this patch was ever committed to HEAD.  Note 
 that the wildcard entry doesn't work as this card uses DEFAULT_RCLK * 
 10, not DEFAULT_RCLK.
 
 -- 
 John Baldwin

From: Shuichi KITAGUCHI <kit@ysnb.net>
To: bug-followup@FreeBSD.org
Cc: thompsa@FreeBSD.org, jhb@FreeBSD.org
Subject: Re: kern/104212: [puc] [patch] support for Kuroutoshikou
 SERIAL4P-LPPCI2 (4port serial card)
Date: Sun, 01 May 2011 22:41:43 +0900 (JST)

 Yes, this card does not work on HEAD.
 
 I always apply my patch to kernel when building world.
 I'm happy if my patch is commited to HEAD _and_ STABLE...
 
 thanks.
 
 
 --
 Shuichi KITAGUCHI // kit@ysnb.net / ki@hh.iij4u.or.jp
 
 > Hmm, it doesn't look like this patch was ever committed to HEAD.  Note
 > that the wildcard entry doesn't work as this card uses DEFAULT_RCLK *
 > 10, not DEFAULT_RCLK.
 > 
 > -- 
 > John Baldwin
Responsible-Changed-From-To: freebsd-bugs->jhb 
Responsible-Changed-By: jhb 
Responsible-Changed-When: Mon May 2 14:35:35 UTC 2011 
Responsible-Changed-Why:  
Fix committed to HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104212 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/104212: commit references a PR
Date: Mon,  2 May 2011 14:35:10 +0000 (UTC)

 Author: jhb
 Date: Mon May  2 14:34:03 2011
 New Revision: 221326
 URL: http://svn.freebsd.org/changeset/base/221326
 
 Log:
   Add an entry for the Kuroutoshikou SERIAL4P-LPPCI2 which uses an Oxford
   4 port chip but with a nonstandard clock.
   
   PR:		kern/104212
   Submitted by:	Shuichi KITAGUCHI  kit of ysnb net
   MFC after:	1 week
 
 Modified:
   head/sys/dev/puc/pucdata.c
 
 Modified: head/sys/dev/puc/pucdata.c
 ==============================================================================
 --- head/sys/dev/puc/pucdata.c	Mon May  2 14:23:36 2011	(r221325)
 +++ head/sys/dev/puc/pucdata.c	Mon May  2 14:34:03 2011	(r221326)
 @@ -638,6 +638,12 @@ const struct puc_cfg puc_pci_devices[] =
  	    PUC_PORT_4S, 0x10, 0, 8,
  	},
  
 +	{   0x1415, 0x9501, 0x14db, 0x2150,
 +	    "Kuroutoshikou SERIAL4P-LPPCI2",
 +	    DEFAULT_RCLK * 10,
 +	    PUC_PORT_4S, 0x10, 0, 8,
 +	},
 +
  	{   0x1415, 0x9501, 0xffff, 0,
  	    "Oxford Semiconductor OX16PCI954 UARTs",
  	    DEFAULT_RCLK,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Shuichi KITAGUCHI <kit@ysnb.net>
To: bug-followup@FreeBSD.org, jhb@FreeBSD.org
Cc: thompsa@FreeBSD.org
Subject: Re: kern/104212: [puc] [patch] support for Kuroutoshikou
 SERIAL4P-LPPCI2 (4port serial card)
Date: Sun, 29 May 2011 20:56:06 +0900 (JST)

 Hi,
 
 Thanks for commiting this patch.
 This card works fine for me. ;-)
 
 
 --
 Shuichi KITAGUCHI // kit@ysnb.net / ki@hh.iij4u.or.jp
State-Changed-From-To: patched->closed 
State-Changed-By: jhb 
State-Changed-When: Wed Jun 8 21:14:12 UTC 2011 
State-Changed-Why:  
Fix merged to 8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104212 
>Unformatted:
