From beech@alaskaparadise.com  Sun Oct  1 06:09:17 2006
Return-Path: <beech@alaskaparadise.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C9F6716A416
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Oct 2006 06:09:17 +0000 (UTC)
	(envelope-from beech@alaskaparadise.com)
Received: from stargate.alaskaparadise.com (114-103-74-65.gci.net [65.74.103.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5FAB643D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Oct 2006 06:09:17 +0000 (GMT)
	(envelope-from beech@alaskaparadise.com)
Received: from stargate.alaskaparadise.com (stargate.alaskaparadise.com [65.74.103.114])
	by stargate.alaskaparadise.com (Postfix) with ESMTP id A88B23FFC;
	Sat, 30 Sep 2006 22:09:16 -0800 (AKDT)
Message-Id: <1159682956.15101@stargate.alaskaparadise.com>
Date: Sat, 30 Sep 2006 22:09:16 -0800
From: "Beech Rintoul" <beech@alaskaparadise.com>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Cc: beech@alaskaparadise.com
Subject: Error with fdformat
X-Send-Pr-Version: gtk-send-pr 0.4.7 
X-GNATS-Notify:

>Number:         103862
>Category:       kern
>Synopsis:       [fdc] [patch] Error with fdformat on -CURRENT
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 01 06:10:23 GMT 2006
>Closed-Date:    Thu Feb 24 11:05:25 UTC 2011
>Last-Modified:  Thu Feb 24 11:10:10 UTC 2011
>Originator:     Beech Rintoul
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
Alaska Paradise 
>Environment:


System: FreeBSD 7.0-CURRENT #84: Sat Sep 30 19:05:33 AKDT 2006
    root@stargate.alaskaparadise.com:/usr/obj/usr/src/sys/STARGATE



>Description:


When formatting a flopppy with fdformat when it hits a bad sector instead
of displaying an "E" the program exits with the following message;

ioctl(FD_FORM): Device not configured

This seems to only be a problem with -CURRENT


>How-To-Repeat:


Format a disk with a bad sector.


>Fix:





>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Oct 21 17:30:24 UTC 2006 
Responsible-Changed-Why:  
This does not sound i386-specific. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103862 
State-Changed-From-To: open->feedback 
State-Changed-By: remko 
State-Changed-When: Sat Nov 11 09:28:40 UTC 2006 
State-Changed-Why:  
Is this fixed already? Officially we do not support CURRENT 
since that might or might not work at all. Let's see what 
we can find out with the most recent CURRENT. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103862 

From: Gavin Atkinson <gavin@FreeBSD.org>
To: beech@FreeBSD.org
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/103862: [fd] Error with fdformat on -CURRENT
Date: Fri, 08 Jun 2007 15:23:19 +0100

 Hi,
 
 Can you confirm if this is still a problem with a more recent version of
 FreeBSD?  I've been unable to recreate it, however it's possible that it
 depends on the specific fault with the disk.
 
 Thanks,
 
 Gavin
State-Changed-From-To: feedback->closed 
State-Changed-By: gavin 
State-Changed-When: Mon Jul 30 10:23:16 UTC 2007 
State-Changed-Why:  
Feedback timeout (> 1 month) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103862 
State-Changed-From-To: closed->open 
State-Changed-By: jhb 
State-Changed-When: Wed Sep 17 15:46:03 UTC 2008 
State-Changed-Why:  
Confirmed on both 6.3 and 7.x. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103862 

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, beech@alaskaparadise.com
Cc:  
Subject: Re: kern/103862: [fd] Error with fdformat on -CURRENT
Date: Thu, 18 Sep 2008 10:59:05 -0400

 The FD_FORM ioctl used to ignore errors from the floppy controller, now when 
 it encounters an error it returns an error from the ioctl.  The patch below 
 changes fdformat to just ignore those errors (which it was doing before).
 
 Index: fdformat.c
 ===================================================================
 --- fdformat.c	(revision 183112)
 +++ fdformat.c	(working copy)
 @@ -75,8 +75,7 @@
  		f.fd_formb_secno(i) = il[i+1];
  		f.fd_formb_secsize(i) = secsize;
  	}
 -	if(ioctl(fd, FD_FORM, (caddr_t)&f) < 0)
 -		err(EX_OSERR, "ioctl(FD_FORM)");
 +	(void)ioctl(fd, FD_FORM, (caddr_t)&f);
  }
  
  static int
 
 -- 
 John Baldwin
State-Changed-From-To: open->patched 
State-Changed-By: brucec 
State-Changed-When: Mon Feb 21 09:56:19 UTC 2011 
State-Changed-Why:  
Fixed in HEAD. 


Responsible-Changed-From-To: freebsd-bugs->brucec 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Mon Feb 21 09:56:19 UTC 2011 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103862 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/103862: commit references a PR
Date: Mon, 21 Feb 2011 09:56:15 +0000 (UTC)

 Author: brucec
 Date: Mon Feb 21 09:56:08 2011
 New Revision: 218910
 URL: http://svn.freebsd.org/changeset/base/218910
 
 Log:
   The FD_FORM ioctl used to ignore errors from the floppy controller; now when
   it encounters an error it returns an error from the ioctl.
   Ignore any errors when using the FD_FORM ioctl.
   
   PR:	kern/103862
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/fdformat/fdformat.c
 
 Modified: head/usr.sbin/fdformat/fdformat.c
 ==============================================================================
 --- head/usr.sbin/fdformat/fdformat.c	Mon Feb 21 09:01:34 2011	(r218909)
 +++ head/usr.sbin/fdformat/fdformat.c	Mon Feb 21 09:56:08 2011	(r218910)
 @@ -75,8 +75,7 @@ format_track(int fd, int cyl, int secs, 
  		f.fd_formb_secno(i) = il[i+1];
  		f.fd_formb_secsize(i) = secsize;
  	}
 -	if(ioctl(fd, FD_FORM, (caddr_t)&f) < 0)
 -		err(EX_OSERR, "ioctl(FD_FORM)");
 +	(void)ioctl(fd, FD_FORM, (caddr_t)&f);
  }
  
  static int
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brucec 
State-Changed-When: Thu Feb 24 11:05:02 UTC 2011 
State-Changed-Why:  
Merged to stable/7 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103862 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/103862: commit references a PR
Date: Thu, 24 Feb 2011 11:03:21 +0000 (UTC)

 Author: brucec
 Date: Thu Feb 24 11:03:16 2011
 New Revision: 218994
 URL: http://svn.freebsd.org/changeset/base/218994
 
 Log:
   MFC r218910:
   
   The FD_FORM ioctl used to ignore errors from the floppy controller; now when
   it encounters an error it returns an error from the ioctl.
   Ignore any errors when using the FD_FORM ioctl.
   
   PR:   kern/103862
 
 Modified:
   stable/8/usr.sbin/fdformat/fdformat.c
 Directory Properties:
   stable/8/usr.sbin/fdformat/   (props changed)
 
 Modified: stable/8/usr.sbin/fdformat/fdformat.c
 ==============================================================================
 --- stable/8/usr.sbin/fdformat/fdformat.c	Thu Feb 24 10:45:41 2011	(r218993)
 +++ stable/8/usr.sbin/fdformat/fdformat.c	Thu Feb 24 11:03:16 2011	(r218994)
 @@ -75,8 +75,7 @@ format_track(int fd, int cyl, int secs, 
  		f.fd_formb_secno(i) = il[i+1];
  		f.fd_formb_secsize(i) = secsize;
  	}
 -	if(ioctl(fd, FD_FORM, (caddr_t)&f) < 0)
 -		err(EX_OSERR, "ioctl(FD_FORM)");
 +	(void)ioctl(fd, FD_FORM, (caddr_t)&f);
  }
  
  static int
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/103862: commit references a PR
Date: Thu, 24 Feb 2011 11:04:51 +0000 (UTC)

 Author: brucec
 Date: Thu Feb 24 11:04:47 2011
 New Revision: 218995
 URL: http://svn.freebsd.org/changeset/base/218995
 
 Log:
   MFC r218910:
   
   The FD_FORM ioctl used to ignore errors from the floppy controller; now when
   it encounters an error it returns an error from the ioctl.
   Ignore any errors when using the FD_FORM ioctl.
   
   PR:   kern/103862
 
 Modified:
   stable/7/usr.sbin/fdformat/fdformat.c
 Directory Properties:
   stable/7/usr.sbin/fdformat/   (props changed)
 
 Modified: stable/7/usr.sbin/fdformat/fdformat.c
 ==============================================================================
 --- stable/7/usr.sbin/fdformat/fdformat.c	Thu Feb 24 11:03:16 2011	(r218994)
 +++ stable/7/usr.sbin/fdformat/fdformat.c	Thu Feb 24 11:04:47 2011	(r218995)
 @@ -75,8 +75,7 @@ format_track(int fd, int cyl, int secs, 
  		f.fd_formb_secno(i) = il[i+1];
  		f.fd_formb_secsize(i) = secsize;
  	}
 -	if(ioctl(fd, FD_FORM, (caddr_t)&f) < 0)
 -		err(EX_OSERR, "ioctl(FD_FORM)");
 +	(void)ioctl(fd, FD_FORM, (caddr_t)&f);
  }
  
  static int
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
