From nobody@FreeBSD.org  Thu Aug  3 21:13:12 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2FF2516A4DF
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Aug 2006 21:13:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0878A43D62
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Aug 2006 21:13:11 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k73LDAfa061373
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 3 Aug 2006 21:13:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k73LDAoT061372;
	Thu, 3 Aug 2006 21:13:10 GMT
	(envelope-from nobody)
Message-Id: <200608032113.k73LDAoT061372@www.freebsd.org>
Date: Thu, 3 Aug 2006 21:13:10 GMT
From: Igor Popov <igorpopov@newmail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: kernel ppp (if_ppp) doesn't use any compression except VJ
X-Send-Pr-Version: www-2.3

>Number:         101333
>Category:       kern
>Synopsis:       [ppp] [patch] ppp(4) (if_ppp) doesn't use any compression except VJ
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 03 21:20:15 GMT 2006
>Closed-Date:    Sat Oct 28 18:10:02 GMT 2006
>Last-Modified:  Sat Oct 28 18:10:25 GMT 2006
>Originator:     Igor Popov
>Release:        6.0 and 6.1
>Organization:
>Environment:
FreeBSD moon.wbt.ru 6.1-RELEASE-p3 FreeBSD 6.1-RELEASE-p3 #0: Mon Jul 10 16:47:52 EEST 2006     toor@moon.wbt.ru:/usr/obj/usr/src/sys/SUPERKERNEL  i386

>Description:
kernel ppp (if_ppp) doesn't use any compression except VJ, it can't find any compress module
>How-To-Repeat:
just try to setup ppp connection
>Fix:
Taken from NetBSD

--- /sys/net/if_ppp.c	Sun Apr 23 14:19:48 2006
+++ if_ppp.c	Sun Jun 25 13:36:58 2006
@@ -560,7 +560,7 @@
 		    sc->sc_flags &= ~SC_DECOMP_RUN;
 		    splx(s);
 		}
-		break;
+		return error;
 	    }
 	if (sc->sc_flags & SC_DEBUG)
 	    if_printf(PPP2IFP(sc), "no compressor for [%x %x %x], %x\n",
		    
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Sat Oct 21 09:44:11 UTC 2006 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Sat Oct 21 09:44:11 UTC 2006 
Responsible-Changed-Why:  
I'm handling this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101333 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/101333: commit references a PR
Date: Sat, 21 Oct 2006 09:44:42 +0000 (UTC)

 glebius     2006-10-21 09:44:02 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/net              if_ppp.c 
   Log:
   Fix error in rev. 1.68. The intention was to break out the switch(){},
   but actually exited from the for(){} loop. This fixes the PPPIOCSCOMPRESS
   ioctl.
   
   PR:             kern/101333
   Submitted by:   Igor Popov <igorpopov newmail.ru>
   
   Revision  Changes    Path
   1.115     +1 -1      src/sys/net/if_ppp.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Sat Oct 28 18:09:41 UTC 2006 
State-Changed-Why:  
Merged to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101333 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/101333: commit references a PR
Date: Sat, 28 Oct 2006 18:10:02 +0000 (UTC)

 glebius     2006-10-28 18:09:40 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/net              if_ppp.c 
   Log:
   MFC rev. 1.115:
     Fix error in rev. 1.68. The intention was to break out the switch(){},
     but actually exited from the for(){} loop. This fixes the PPPIOCSCOMPRESS
     ioctl.
   
     PR:                   kern/101333
     Submitted by:         Igor Popov <igorpopov newmail.ru>
   
   Approved by:    re (hrs)
   
   Revision   Changes    Path
   1.105.2.4  +1 -1      src/sys/net/if_ppp.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
