From nobody@FreeBSD.org  Tue Jul 25 08:18:09 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1144D16A4DF
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Jul 2006 08:18:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DED3043D46
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Jul 2006 08:18:08 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k6P8I8uI023464
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Jul 2006 08:18:08 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k6P8I8Mk023463;
	Tue, 25 Jul 2006 08:18:08 GMT
	(envelope-from nobody)
Message-Id: <200607250818.k6P8I8Mk023463@www.freebsd.org>
Date: Tue, 25 Jul 2006 08:18:08 GMT
From: Valerio Daelli <valerio.daelli@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: panic in ddb mode if sending signal '0'
X-Send-Pr-Version: www-2.3

>Number:         100802
>Category:       kern
>Synopsis:       [ddb] [patch] panic in ddb mode if sending signal '0'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    rwatson
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 25 08:20:16 GMT 2006
>Closed-Date:    Mon Mar 10 11:39:42 UTC 2008
>Last-Modified:  Mon Mar 10 11:40:05 UTC 2008
>Originator:     Valerio Daelli
>Release:        5.4
>Organization:
IFOM
>Environment:
FreeBSD webgate.ifom-ieo-campus.it 5.4-RELEASE-p12 FreeBSD 5.4-RELEASE-p12 #1: Thu Mar  2 14:16:41 CET 2006     root@webgate.ifom-ieo-campus.it:/usr/obj/usr/src/sys/WEBGATE  alpha
>Description:
If you break in ddb mode by pressing CTRL-ALT-ESC and send any process
a signal '0', then kernel panics.
>How-To-Repeat:
Break in ddb mode (CTRL-ALT-ESC), type ps, get a pid and type

kill 0 <PID>
>Fix:
Correct line number 561 in /usr/src/sys/ddb/db_command.c:

from

         if (sig < 0 || sig > _SIG_MAXSIG)

to

       if (sig < 1 || sig > _SIG_MAXSIG)

and recompile the kernel.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rwatson 
Responsible-Changed-By: rwatson 
Responsible-Changed-When: Fri Mar 7 12:34:08 UTC 2008 
Responsible-Changed-Why:  
Take ownership of this DDB issue since I've had my hands in it recently. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100802 
State-Changed-From-To: open->analyzed 
State-Changed-By: rwatson 
State-Changed-When: Fri Mar 7 13:41:45 UTC 2008 
State-Changed-Why:  
I've confirmed that this problem can be reproduced on FreeBSD 8.0 and will 
test and commit the fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100802 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/100802: commit references a PR
Date: Fri,  7 Mar 2008 14:26:40 +0000 (UTC)

 rwatson     2008-03-07 14:26:31 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/ddb              db_command.c 
   Log:
   When killing a user process from DDB, check that the requested signal is
   > 0 rather than >= 0, or we will panic when trying to deliver the signal.
   
   MFC after:      3 days
   PR:             100802
   Submitted by:   Valerio Daelli <valerio.daelli at gmail.com>
   
   Revision  Changes    Path
   1.77      +1 -1      src/sys/ddb/db_command.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: rwatson 
State-Changed-When: Fri Mar 7 14:30:58 UTC 2008 
State-Changed-Why:  
Fix committed to CVS; I'll leave this PR in the patched state until I've 
MFC'd the fix in a few days. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=100802 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/100802: commit references a PR
Date: Mon, 10 Mar 2008 10:26:09 +0000 (UTC)

 rwatson     2008-03-10 10:26:04 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/ddb              db_command.c 
   Log:
   Merge db_command.c:1.77 from HEAD to RELENG_7:
   
     When killing a user process from DDB, check that the requested signal is
     > 0 rather than >= 0, or we will panic when trying to deliver the signal.
   
     PR:             100802
     Submitted by:   Valerio Daelli <valerio.daelli at gmail.com>
   
   Revision  Changes    Path
   1.73.2.1  +1 -1      src/sys/ddb/db_command.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/100802: commit references a PR
Date: Mon, 10 Mar 2008 10:40:08 +0000 (UTC)

 rwatson     2008-03-10 10:40:00 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/ddb              db_command.c 
   Log:
   Merge db_command.c from HEAD to RELENG_6:
   
     When killing a user process from DDB, check that the requested signal is
     > 0 rather than >= 0, or we will panic when trying to deliver the signal.
   
     PR:             100802
     Submitted by:   Valerio Daelli <valerio.daelli at gmail.com>
   
   Revision  Changes    Path
   1.60.2.5  +1 -1      src/sys/ddb/db_command.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: rwatson 
State-Changed-When: Mon Mar 10 11:39:17 UTC 2008 
State-Changed-Why:  
Close PR as now MFC'd to RELENG_5, RELENG_6, and RELENG_7.  Thanks for the 
submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100802 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/100802: commit references a PR
Date: Mon, 10 Mar 2008 11:39:03 +0000 (UTC)

 rwatson     2008-03-10 11:38:57 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_5)
     sys/ddb              db_command.c 
   Log:
   Merge db_command.c:1.77 from HEAD to RELENG_5:
   
     When killing a user process from DDB, check that the requested signal is
     > 0 rather than >= 0, or we will panic when trying to deliver the signal.
   
     PR:             100802
     Submitted by:   Valerio Daelli <valerio.daelli at gmail.com>
   
   Revision  Changes    Path
   1.57.2.3  +1 -1      src/sys/ddb/db_command.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
