From nobody@FreeBSD.org  Fri Sep 14 12:25:45 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 477B337B40A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Sep 2001 12:25:44 -0700 (PDT)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f8EJPiL51038;
	Fri, 14 Sep 2001 12:25:44 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200109141925.f8EJPiL51038@freefall.freebsd.org>
Date: Fri, 14 Sep 2001 12:25:44 -0700 (PDT)
From: "Antonio D'souza" <quik@quikbox.ca>
To: freebsd-gnats-submit@FreeBSD.org
Subject: java/jdk13 attempts to build even if one of it's deps fails.
X-Send-Pr-Version: www-1.0

>Number:         30576
>Category:       java
>Synopsis:       java/jdk13 attempts to build even if one of it's deps fails.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 14 12:30:00 PDT 2001
>Closed-Date:    Mon Jul 21 15:16:58 PDT 2003
>Last-Modified:  Mon Jul 21 15:20:19 PDT 2003
>Originator:     Antonio D'souza
>Release:        4.4-prerelease
>Organization:
CheckFree i-Solutions
>Environment:
FreeBSD alice.quiknet 4.4-PRERELEASE FreeBSD 4.4-PRERELEASE #3: Wed Aug  8 14:06:44 EDT 2001     quik@quikbox.ca:/usr/obj/usr/src/sys/QUIK  i386
>Description:
the native jdk1.3 depends upon the linux version but because the port for the linux version requires the user to manually fetch some files, the port (for the linux version) simply displays a message informing the user about where to obtain these files and exits but does not return an error code so when the native jdk13 port tries to build the linux one, it keeps going after the build fails and then fails itself too.
>How-To-Repeat:
try to build java/jdk13 on a box that has never had the linux version of jdk13 built or installed on it.
>Fix:
The linux version of the port should return an error code that signifies failure if it does not have the requisite files in /usr/ports/distfiles.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->sobomax 
Responsible-Changed-By: petef 
Responsible-Changed-When: Fri Oct 5 00:11:35 PDT 2001 
Responsible-Changed-Why:  
Over to maintainer; but this looks like more of a general problem too. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=30576 
Responsible-Changed-From-To: sobomax->glewis 
Responsible-Changed-By: sobomax 
Responsible-Changed-When: Fri Aug 30 05:27:00 PDT 2002 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=30576 
Responsible-Changed-From-To: glewis->portmgr 
Responsible-Changed-By: glewis 
Responsible-Changed-When: Mon Jul 21 10:22:55 PDT 2003 
Responsible-Changed-Why:  
I've worked around this issue for the particular port mentioned, 
but as one of the notes states "this looks like more of a general 
problem too". 

Hence I'm reassigning to portmgr to see if they consider it to be 
a general problem.  The problematic scenario is as follows: 

. Port A uses the IGNORE variable to indicate that the distfile 
must be fetched by hand (for example). 
. Port B depends on port A (to build, for instance). 
. Building port B without port A installed will do the following: 

. Try to build port A but "fail" and spit out IGNORE message. 
Unfortunately this produces a 0 exit status and... 
. Continue with build of port B until an unexpected failure 
occurs. 

The build should really halt after the first step since 
continuing on obfuscates the reason for the failure. 

Maybe this is just an abuse of the IGNORE variable and there is 
already a better way to do this?  If so please let me know and 
I'll fix the offending jdk ports.  If not it would probably be 
worthwhile creating a way to do this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=30576 

From: Kris Kennaway <kris@obsecurity.org>
To: Greg Lewis <glewis@FreeBSD.org>
Cc: portmgr@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org
Subject: Re: java/30576: java/jdk13 attempts to build even if one of it's deps fails.
Date: Mon, 21 Jul 2003 14:27:39 -0700

 On Mon, Jul 21, 2003 at 10:30:46AM -0700, Greg Lewis wrote:
 
 >   . Try to build port A but "fail" and spit out IGNORE message.
 >     Unfortunately this produces a 0 exit status and...
 
 IGNORE probably just needs to set a non-zero exit status.
 
 Kris
State-Changed-From-To: open->closed 
State-Changed-By: glewis 
State-Changed-When: Mon Jul 21 15:16:21 PDT 2003 
State-Changed-Why:  
IGNORE does now cause the port build to exit with a non-zero status 
when its being built as a dependency. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=30576 

From: Greg Lewis <glewis@misty.eyesbeyond.com>
To: Kris Kennaway <kris@obsecurity.org>
Cc: Greg Lewis <glewis@FreeBSD.org>, portmgr@FreeBSD.org,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: java/30576: java/jdk13 attempts to build even if one of it's deps fails.
Date: Mon, 21 Jul 2003 16:23:14 -0600

 On Mon, Jul 21, 2003 at 02:27:39PM -0700, Kris Kennaway wrote:
 > On Mon, Jul 21, 2003 at 10:30:46AM -0700, Greg Lewis wrote:
 > 
 > >   . Try to build port A but "fail" and spit out IGNORE message.
 > >     Unfortunately this produces a 0 exit status and...
 > 
 > IGNORE probably just needs to set a non-zero exit status.
 
 Oops, further investigation indicates that it now does when the package
 is being built as a dependency.  Sorry!  I'll close the PR.
 
 -- 
 Greg Lewis                          Email   : glewis@eyesbeyond.com
 Eyes Beyond                         Web     : http://www.eyesbeyond.com
 Information Technology              FreeBSD : glewis@FreeBSD.org
 
>Unformatted:
