From jhelfman@experts-exchange.com  Mon Dec 19 18:39:33 2011
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3185F106564A;
	Mon, 19 Dec 2011 18:39:33 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 105728FC08;
	Mon, 19 Dec 2011 18:39:32 +0000 (UTC)
Received: from mail.experts-exchange.com (localhost [127.0.0.1])
	by mail.experts-exchange.com (Postfix) with ESMTP id EBF006FED91;
	Mon, 19 Dec 2011 10:39:32 -0800 (PST)
Received: from mail.experts-exchange.com ([127.0.0.1])
	by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id I0P2kyRBrO3c; Mon, 19 Dec 2011 10:39:32 -0800 (PST)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.experts-exchange.com (Postfix) with SMTP id C4E546FED81;
	Mon, 19 Dec 2011 10:39:32 -0800 (PST)
Received: (nullmailer pid 72550 invoked by uid 1001);
	Mon, 19 Dec 2011 18:39:04 -0000
Message-Id: <1324319944.277110.72549.nullmailer@experts-exchange.com>
Date: Mon, 19 Dec 2011 10:39:04 -0800
From: Jason Helfman <jhelfman@experts-exchange.com>
Reply-To: Jason Helfman <jhelfman@experts-exchange.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jkim@freebsd.org, jilles@stack.nl
Subject: [patch] java/openjdk6: build and distribute open timezone data (tzdata)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         163456
>Category:       java
>Synopsis:       [patch] java/openjdk6: build and distribute open timezone data (tzdata)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-java
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 19 18:40:05 UTC 2011
>Closed-Date:    Mon Apr 16 02:49:03 UTC 2012
>Last-Modified:  Mon Apr 16 02:49:03 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
Experts Exchange, LLC.
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64


	
>Description:
Timezone data hasn't been updated since 2010 in OpenJDK. This patch downloads open timezone data, uses the built java tool
javazic.jar to translate files so java may use them, and distributes into the correct location.

Builds cleanly in Tinderbox => http://jgh.devio.us/files/logs/openjdk6-b24_1.log.gz

This patch encapsulates the spirit of ports/161945, and potentially could be seen as a duplicate if compilefontconfig.jar
were copied into ${PREFIX}/openjdk6/jre/lib/

>How-To-Repeat:
	
>Fix:

Index: Makefile
===================================================================
RCS file: /home/jhelfman/ncvs/ports/java/openjdk6/Makefile,v
retrieving revision 1.53
diff -u -r1.53 Makefile
--- Makefile	30 Nov 2011 21:18:29 -0000	1.53
+++ Makefile	19 Dec 2011 17:21:17 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	openjdk6
 PORTVERSION=	b24
+PORTREVISION=	1
 CATEGORIES=	java devel
 MASTER_SITES=	http://download.java.net/openjdk/jdk6/promoted/${PORTVERSION}/ \
 		http://download.java.net/jaxp/openjdk/jdk6/:jaxp \
@@ -17,13 +18,16 @@
 		http://icedtea.classpath.org/download/drops/:jaxws \
 		http://icedtea.classpath.org/download/drops/:jaf \
 		${MASTER_SITE_APACHE:S,%SUBDIR%/,ant/binaries/:ant,} \
-		http://download.java.net/openjdk/jtreg/promoted/4.1/${JTREGVERSION}/:jtreg
+		http://download.java.net/openjdk/jtreg/promoted/4.1/${JTREGVERSION}/:jtreg \
+		ftp://ftp.iana.org/tz/releases/:tzdata \
+		http://www.iana.org/time-zones/repository/releases/:tzdata
 DISTNAME=	openjdk-6-src-${PORTVERSION}-${OPENJDK_BUILDDATE}
 DISTFILES=	${DISTNAME}${EXTRACT_SUFX} \
 		${JAXPFILE}:jaxp \
 		${JAXWSFILE}:jaxws \
 		${JAFFILE}:jaf \
-		${ANTFILE}:ant
+		${ANTFILE}:ant \
+		${TZDATAFILE}:tzdata
 EXTRACT_ONLY=	${DISTNAME}${EXTRACT_SUFX} ${ANTFILE}
 
 MAINTAINER=	java@FreeBSD.org
@@ -64,6 +68,8 @@
 JAFFILE=	jdk6-jaf-${JAF_BUILD}.zip
 JTREGVERSION=	b03
 JTREGFILE=	jtreg-4.1-bin-${JTREGVERSION}_11_jul_2011.zip
+TZDATA_BUILD=	2011n
+TZDATAFILE=	tzdata${TZDATA_BUILD}${EXTRACT_SUFX}
 
 # do not depend on devel/apache-ant to avoid circular dependency, but
 # use .tar.bz2 distfile to avoid duplicated downloads
@@ -258,6 +264,24 @@
 	@${ECHO_MSG} ""
 .endif
 
+post-build-script:
+	@${ECHO_MSG} "Building new timezone data..."
+	@${RM} -rf ${WRKSRC}/build/${OPENJDK_OSARCH}/lib/zi/*
+	@${MKDIR} ${WRKSRC}/${TZDATA_BUILD} && ${TAR} xf ${DISTDIR}/${TZDATAFILE} -C ${WRKSRC}/${TZDATA_BUILD}
+	cd ${WRKSRC}/${TZDATA_BUILD} && ${WRKSRC}/build/${OPENJDK_OSARCH}/bin/java -jar \
+                ${WRKSRC}/build/${OPENJDK_OSARCH}/btjars/javazic.jar -V ${TZDATA_BUILD} \
+                -d  ${WRKSRC}/build/${OPENJDK_OSARCH}/lib/zi/ \
+                africa \
+                antarctica \
+                asia \
+                australasia \
+                etcetera \
+                europe \
+                factory \
+                northamerica \
+                southamerica \
+                systemv 2>/dev/null
+
 do-install:
 	@${MKDIR} ${PREFIX}/openjdk6/
 	@${CP} -Rp ${WRKSRC}/build/${OPENJDK_OSARCH}/j2sdk-image/ ${PREFIX}/openjdk6/
Index: distinfo
===================================================================
RCS file: /home/jhelfman/ncvs/ports/java/openjdk6/distinfo,v
retrieving revision 1.25
diff -u -r1.25 distinfo
--- distinfo	30 Nov 2011 21:18:29 -0000	1.25
+++ distinfo	19 Dec 2011 06:43:20 -0000
@@ -8,5 +8,5 @@
 SIZE (jdk6-jaf-b20.zip) = 71243
 SHA256 (apache-ant-1.8.2-bin.tar.bz2) = ecb49f5017807c9320bf19702149328cf4779a01bddca2b6c47e3ebb0e39c9c7
 SIZE (apache-ant-1.8.2-bin.tar.bz2) = 6740047
-SHA256 (jtreg-4.1-bin-b03_11_jul_2011.zip) = 7ae38e80d3342670cc9142eee423d0a755bf005e4d83b40c5681f0f7d95f1cce
-SIZE (jtreg-4.1-bin-b03_11_jul_2011.zip) = 4901245
+SHA256 (tzdata2011n.tar.gz) = a343e542486b2b8ebdeca474eed79f1c04f69420ca943c2b9bdea1d2385e38cd
+SIZE (tzdata2011n.tar.gz) = 204684
>Release-Note:
>Audit-Trail:

From: Jason Helfman <jhelfman@e-e.com>
To: bug-followup@freebsd.org
Cc: freebsd-java@freebsd.org
Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open
 timezone data (tzdata)
Date: Mon, 19 Dec 2011 10:44:22 -0800

 --i0/AhcQY5QxfSsSZ
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Disposition: inline
 
 Updated patch. jtreg was removed from distinfo
 
 -jgh
 
 -- 
 Jason Helfman
 System Administrator
 experts-exchange.com
 http://www.experts-exchange.com/M_4830110.html
 E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
 
 --i0/AhcQY5QxfSsSZ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="openjdk6-tzdata.patch.txt"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/jhelfman/ncvs/ports/java/openjdk6/Makefile,v
 retrieving revision 1.53
 diff -u -r1.53 Makefile
 --- Makefile	30 Nov 2011 21:18:29 -0000	1.53
 +++ Makefile	19 Dec 2011 17:21:17 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	openjdk6
  PORTVERSION=	b24
 +PORTREVISION=	1
  CATEGORIES=	java devel
  MASTER_SITES=	http://download.java.net/openjdk/jdk6/promoted/${PORTVERSION}/ \
  		http://download.java.net/jaxp/openjdk/jdk6/:jaxp \
 @@ -17,13 +18,16 @@
  		http://icedtea.classpath.org/download/drops/:jaxws \
  		http://icedtea.classpath.org/download/drops/:jaf \
  		${MASTER_SITE_APACHE:S,%SUBDIR%/,ant/binaries/:ant,} \
 -		http://download.java.net/openjdk/jtreg/promoted/4.1/${JTREGVERSION}/:jtreg
 +		http://download.java.net/openjdk/jtreg/promoted/4.1/${JTREGVERSION}/:jtreg \
 +		ftp://ftp.iana.org/tz/releases/:tzdata \
 +		http://www.iana.org/time-zones/repository/releases/:tzdata
  DISTNAME=	openjdk-6-src-${PORTVERSION}-${OPENJDK_BUILDDATE}
  DISTFILES=	${DISTNAME}${EXTRACT_SUFX} \
  		${JAXPFILE}:jaxp \
  		${JAXWSFILE}:jaxws \
  		${JAFFILE}:jaf \
 -		${ANTFILE}:ant
 +		${ANTFILE}:ant \
 +		${TZDATAFILE}:tzdata
  EXTRACT_ONLY=	${DISTNAME}${EXTRACT_SUFX} ${ANTFILE}
  
  MAINTAINER=	java@FreeBSD.org
 @@ -64,6 +68,8 @@
  JAFFILE=	jdk6-jaf-${JAF_BUILD}.zip
  JTREGVERSION=	b03
  JTREGFILE=	jtreg-4.1-bin-${JTREGVERSION}_11_jul_2011.zip
 +TZDATA_BUILD=	2011n
 +TZDATAFILE=	tzdata${TZDATA_BUILD}${EXTRACT_SUFX}
  
  # do not depend on devel/apache-ant to avoid circular dependency, but
  # use .tar.bz2 distfile to avoid duplicated downloads
 @@ -258,6 +264,24 @@
  	@${ECHO_MSG} ""
  .endif
  
 +post-build-script:
 +	@${ECHO_MSG} "Building new timezone data..."
 +	@${RM} -rf ${WRKSRC}/build/${OPENJDK_OSARCH}/lib/zi/*
 +	@${MKDIR} ${WRKSRC}/${TZDATA_BUILD} && ${TAR} xf ${DISTDIR}/${TZDATAFILE} -C ${WRKSRC}/${TZDATA_BUILD}
 +	cd ${WRKSRC}/${TZDATA_BUILD} && ${WRKSRC}/build/${OPENJDK_OSARCH}/bin/java -jar \
 +                ${WRKSRC}/build/${OPENJDK_OSARCH}/btjars/javazic.jar -V ${TZDATA_BUILD} \
 +                -d  ${WRKSRC}/build/${OPENJDK_OSARCH}/lib/zi/ \
 +                africa \
 +                antarctica \
 +                asia \
 +                australasia \
 +                etcetera \
 +                europe \
 +                factory \
 +                northamerica \
 +                southamerica \
 +                systemv 2>/dev/null
 +
  do-install:
  	@${MKDIR} ${PREFIX}/openjdk6/
  	@${CP} -Rp ${WRKSRC}/build/${OPENJDK_OSARCH}/j2sdk-image/ ${PREFIX}/openjdk6/
 Index: distinfo
 ===================================================================
 RCS file: /home/jhelfman/ncvs/ports/java/openjdk6/distinfo,v
 retrieving revision 1.25
 diff -u -r1.25 distinfo
 --- distinfo	30 Nov 2011 21:18:29 -0000	1.25
 +++ distinfo	19 Dec 2011 18:42:09 -0000
 @@ -8,5 +8,7 @@
  SIZE (jdk6-jaf-b20.zip) = 71243
  SHA256 (apache-ant-1.8.2-bin.tar.bz2) = ecb49f5017807c9320bf19702149328cf4779a01bddca2b6c47e3ebb0e39c9c7
  SIZE (apache-ant-1.8.2-bin.tar.bz2) = 6740047
 +SHA256 (tzdata2011n.tar.gz) = a343e542486b2b8ebdeca474eed79f1c04f69420ca943c2b9bdea1d2385e38cd
 +SIZE (tzdata2011n.tar.gz) = 204684
  SHA256 (jtreg-4.1-bin-b03_11_jul_2011.zip) = 7ae38e80d3342670cc9142eee423d0a755bf005e4d83b40c5681f0f7d95f1cce
  SIZE (jtreg-4.1-bin-b03_11_jul_2011.zip) = 4901245
 
 --i0/AhcQY5QxfSsSZ--

From: Andriy Gapon <avg@FreeBSD.org>
To: Jason Helfman <jhelfman@e-e.com>
Cc: bug-followup@FreeBSD.org, freebsd-java@FreeBSD.org
Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open
 timezone data (tzdata)
Date: Mon, 19 Dec 2011 21:34:55 +0200

 on 19/12/2011 20:44 Jason Helfman said the following:
 > Updated patch. jtreg was removed from distinfo
 
 Jason,
 
 I wonder if it would make sense to add a dependency on misc/zoneinfo and use
 data from there instead of separately downloading and using it.
 
 -- 
 Andriy Gapon

From: jgh@FreeBSD.org
To: Andriy Gapon <avg@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, freebsd-java@FreeBSD.org
Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open
 timezone data (tzdata)
Date: Mon, 19 Dec 2011 13:28:01 -0800

 --h31gzZEtNLTqOjlF
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Disposition: inline
 
 On Mon, Dec 19, 2011 at 09:34:55PM +0200, Andriy Gapon thus spake:
 >on 19/12/2011 20:44 Jason Helfman said the following:
 >> Updated patch. jtreg was removed from distinfo
 >
 >Jason,
 >
 >I wonder if it would make sense to add a dependency on misc/zoneinfo and use
 >data from there instead of separately downloading and using it.
 >
 >-- 
 >Andriy Gapon
 
 This wouldn't work, as java needs to prepare the files and distribute them.
 I have updated the patch, and it works now. The updated zonefiles were being
 clobbered. Had to move build location. Updated patch is attached.
 
 -jgh
 
 -- 
 Jason Helfman         | FreeBSD Committer
 jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
 
 8E0D C457 9A0F C91C 23F3  0454 2059 9A63 4150 D3DC
 
 --h31gzZEtNLTqOjlF
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="openjdk.txt"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/jhelfman/ncvs/ports/java/openjdk6/Makefile,v
 retrieving revision 1.53
 diff -u -r1.53 Makefile
 --- Makefile	30 Nov 2011 21:18:29 -0000	1.53
 +++ Makefile	19 Dec 2011 21:24:11 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	openjdk6
  PORTVERSION=	b24
 +PORTREVISION=	1
  CATEGORIES=	java devel
  MASTER_SITES=	http://download.java.net/openjdk/jdk6/promoted/${PORTVERSION}/ \
  		http://download.java.net/jaxp/openjdk/jdk6/:jaxp \
 @@ -17,13 +18,16 @@
  		http://icedtea.classpath.org/download/drops/:jaxws \
  		http://icedtea.classpath.org/download/drops/:jaf \
  		${MASTER_SITE_APACHE:S,%SUBDIR%/,ant/binaries/:ant,} \
 -		http://download.java.net/openjdk/jtreg/promoted/4.1/${JTREGVERSION}/:jtreg
 +		http://download.java.net/openjdk/jtreg/promoted/4.1/${JTREGVERSION}/:jtreg \
 +		ftp://ftp.iana.org/tz/releases/:tzdata \
 +		http://www.iana.org/time-zones/repository/releases/:tzdata
  DISTNAME=	openjdk-6-src-${PORTVERSION}-${OPENJDK_BUILDDATE}
  DISTFILES=	${DISTNAME}${EXTRACT_SUFX} \
  		${JAXPFILE}:jaxp \
  		${JAXWSFILE}:jaxws \
  		${JAFFILE}:jaf \
 -		${ANTFILE}:ant
 +		${ANTFILE}:ant \
 +		${TZDATAFILE}:tzdata
  EXTRACT_ONLY=	${DISTNAME}${EXTRACT_SUFX} ${ANTFILE}
  
  MAINTAINER=	java@FreeBSD.org
 @@ -64,6 +68,8 @@
  JAFFILE=	jdk6-jaf-${JAF_BUILD}.zip
  JTREGVERSION=	b03
  JTREGFILE=	jtreg-4.1-bin-${JTREGVERSION}_11_jul_2011.zip
 +TZDATA_BUILD=	2011n
 +TZDATAFILE=	tzdata${TZDATA_BUILD}${EXTRACT_SUFX}
  
  # do not depend on devel/apache-ant to avoid circular dependency, but
  # use .tar.bz2 distfile to avoid duplicated downloads
 @@ -258,6 +264,24 @@
  	@${ECHO_MSG} ""
  .endif
  
 +post-build-script:
 +	@${ECHO_MSG} "Building new timezone data..."
 +	@${RM} -rf ${WRKSRC}/build/${OPENJDK_OSARCH}/j2sdk-image/jre/lib/zi/*
 +	@${MKDIR} ${WRKSRC}/${TZDATA_BUILD} && ${TAR} xf ${DISTDIR}/${TZDATAFILE} -C ${WRKSRC}/${TZDATA_BUILD}
 +	cd ${WRKSRC}/${TZDATA_BUILD} && ${WRKSRC}/build/${OPENJDK_OSARCH}/bin/java -jar \
 +                ${WRKSRC}/build/${OPENJDK_OSARCH}/btjars/javazic.jar -V ${TZDATA_BUILD} \
 +                -d  ${WRKSRC}/build/${OPENJDK_OSARCH}/j2sdk-image/jre/lib/zi/ \
 +                africa \
 +                antarctica \
 +                asia \
 +                australasia \
 +                etcetera \
 +                europe \
 +                factory \
 +                northamerica \
 +                southamerica \
 +                systemv 2>/dev/null
 +
  do-install:
  	@${MKDIR} ${PREFIX}/openjdk6/
  	@${CP} -Rp ${WRKSRC}/build/${OPENJDK_OSARCH}/j2sdk-image/ ${PREFIX}/openjdk6/
 Index: distinfo
 ===================================================================
 RCS file: /home/jhelfman/ncvs/ports/java/openjdk6/distinfo,v
 retrieving revision 1.25
 diff -u -r1.25 distinfo
 --- distinfo	30 Nov 2011 21:18:29 -0000	1.25
 +++ distinfo	19 Dec 2011 18:42:09 -0000
 @@ -8,5 +8,7 @@
  SIZE (jdk6-jaf-b20.zip) = 71243
  SHA256 (apache-ant-1.8.2-bin.tar.bz2) = ecb49f5017807c9320bf19702149328cf4779a01bddca2b6c47e3ebb0e39c9c7
  SIZE (apache-ant-1.8.2-bin.tar.bz2) = 6740047
 +SHA256 (tzdata2011n.tar.gz) = a343e542486b2b8ebdeca474eed79f1c04f69420ca943c2b9bdea1d2385e38cd
 +SIZE (tzdata2011n.tar.gz) = 204684
  SHA256 (jtreg-4.1-bin-b03_11_jul_2011.zip) = 7ae38e80d3342670cc9142eee423d0a755bf005e4d83b40c5681f0f7d95f1cce
  SIZE (jtreg-4.1-bin-b03_11_jul_2011.zip) = 4901245
 
 --h31gzZEtNLTqOjlF--

From: Andriy Gapon <avg@FreeBSD.org>
To: jgh@FreeBSD.org
Cc: bug-followup@FreeBSD.org, freebsd-java@FreeBSD.org
Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open
 timezone data (tzdata)
Date: Tue, 20 Dec 2011 00:08:59 +0200

 on 19/12/2011 23:28 jgh@FreeBSD.org said the following:
 > On Mon, Dec 19, 2011 at 09:34:55PM +0200, Andriy Gapon thus spake:
 >> on 19/12/2011 20:44 Jason Helfman said the following:
 >>> Updated patch. jtreg was removed from distinfo
 >>
 >> Jason,
 >>
 >> I wonder if it would make sense to add a dependency on misc/zoneinfo and use
 >> data from there instead of separately downloading and using it.
 > 
 > This wouldn't work, as java needs to prepare the files and distribute them.
 > I have updated the patch, and it works now. The updated zonefiles were being
 > clobbered. Had to move build location. Updated patch is attached.
 
 Oh, I didn't mean to use the files as is.  My suggestion was to create Java tz
 files from the already installed zoneinfo files.  So that e.g. Java software and
 other software have the same idea of the timezones.
 
 -- 
 Andriy Gapon

From: Greg Lewis <glewis@eyesbeyond.com>
To: Jason Helfman <jhelfman@experts-exchange.com>
Cc: FreeBSD-gnats-submit@freebsd.org, jilles@stack.nl, jkim@freebsd.org
Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open
 timezone data (tzdata)
Date: Tue, 20 Dec 2011 09:47:57 -0800

 G'day Jason,
 
 On Mon, Dec 19, 2011 at 10:39:04AM -0800, Jason Helfman wrote:
 > Timezone data hasn't been updated since 2010 in OpenJDK. This patch downloads open timezone data, uses the built java tool
 > javazic.jar to translate files so java may use them, and distributes into the correct location.
 > 
 > Builds cleanly in Tinderbox => http://jgh.devio.us/files/logs/openjdk6-b24_1.log.gz
 > 
 > This patch encapsulates the spirit of ports/161945, and potentially could be seen as a duplicate if compilefontconfig.jar
 > were copied into ${PREFIX}/openjdk6/jre/lib/
 
 Thanks for doing this!  I wonder if with a little more work we couldn't
 make this work for all of the JDK ports instead of having to reimplement
 it for openjdk7, jdk16, jdk15, diablo, etc.
 
 I.e., can we pull this out into a separate port that installs the
 appropriate zoneinfo files into somewhere like
 ${LOCALBASE}/share/java/zoneinfo and then symlink the zi directory in all
 of the jdk and jre ports to that directory.
 
 I haven't looked deeply into your change but I assume the biggest problem
 with this is that you need a JDK with javazic.jar already installed before
 you can process the raw zoneinfo files so we'd be creating a circular
 dependency.
 
 -- 
 Greg Lewis                          Email   : glewis@eyesbeyond.com
 Eyes Beyond                         Web     : http://www.eyesbeyond.com
 Information Technology              FreeBSD : glewis@FreeBSD.org

From: Jilles Tjoelker <jilles@stack.nl>
To: Greg Lewis <glewis@eyesbeyond.com>
Cc: Jason Helfman <jhelfman@experts-exchange.com>,
	FreeBSD-gnats-submit@freebsd.org, jkim@freebsd.org
Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open
 timezone data (tzdata)
Date: Tue, 20 Dec 2011 23:05:04 +0100

 On Tue, Dec 20, 2011 at 09:47:57AM -0800, Greg Lewis wrote:
 > On Mon, Dec 19, 2011 at 10:39:04AM -0800, Jason Helfman wrote:
 > > Timezone data hasn't been updated since 2010 in OpenJDK. This patch downloads open timezone data, uses the built java tool
 > > javazic.jar to translate files so java may use them, and distributes into the correct location.
 
 > > Builds cleanly in Tinderbox => http://jgh.devio.us/files/logs/openjdk6-b24_1.log.gz
 
 Great.
 
 > > This patch encapsulates the spirit of ports/161945, and potentially could be seen as a duplicate if compilefontconfig.jar
 > > were copied into ${PREFIX}/openjdk6/jre/lib/
 
 > Thanks for doing this!  I wonder if with a little more work we couldn't
 > make this work for all of the JDK ports instead of having to reimplement
 > it for openjdk7, jdk16, jdk15, diablo, etc.
 
 > I.e., can we pull this out into a separate port that installs the
 > appropriate zoneinfo files into somewhere like
 > ${LOCALBASE}/share/java/zoneinfo and then symlink the zi directory in all
 > of the jdk and jre ports to that directory.
 
 This would avoid the need to update and recompile all JDKs whenever
 tzdata changes.
 
 > I haven't looked deeply into your change but I assume the biggest problem
 > with this is that you need a JDK with javazic.jar already installed before
 > you can process the raw zoneinfo files so we'd be creating a circular
 > dependency.
 
 Yes, this causes a bootstrapping problem. It is not much worse than the
 bootstrapping problem Java already has, though. The bootstrap
 requirement changes from a JDK to a JDK-with-javazic.jar.
 
 Also, the files generated by javazic.jar are architecture-independent so
 this should not make bootstrapping a new architecture harder (except
 that ports has no concept of architecture-independent binary packages).
 
 Another alternative is a second tzdata-java port that downloads the
 generated files, so it does not need Java to build.
 
 Don't let this stop you from committing the changes to openjdk6, though.
 
 -- 
 Jilles Tjoelker
State-Changed-From-To: open->analyzed 
State-Changed-By: jgh 
State-Changed-When: Fri Dec 30 06:45:04 UTC 2011 
State-Changed-Why:  
seeking a better tool and process that would apply to all jdks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163456 
State-Changed-From-To: analyzed->closed 
State-Changed-By: jgh 
State-Changed-When: Mon Apr 16 02:49:01 UTC 2012 
State-Changed-Why:  
using java/java-zoneinfo as a dependency for timezone data, this issues 
is now closed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163456 
>Unformatted:
