From nobody@FreeBSD.org  Fri Oct 20 18:51:37 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BA5916A403
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Oct 2006 18:51:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2E20343D66
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Oct 2006 18:51:37 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k9KIpat0047045
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 20 Oct 2006 18:51:36 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k9KIpacB047044;
	Fri, 20 Oct 2006 18:51:36 GMT
	(envelope-from nobody)
Message-Id: <200610201851.k9KIpacB047044@www.freebsd.org>
Date: Fri, 20 Oct 2006 18:51:36 GMT
From: Patrick Eisenacher<eisenacher@s3-solutions.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Makefile jdk14 broken
X-Send-Pr-Version: www-3.0

>Number:         104627
>Category:       java
>Synopsis:       Makefile jdk14 broken
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-java
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 20 19:00:37 GMT 2006
>Closed-Date:    Sat Apr 07 05:00:26 GMT 2007
>Last-Modified:  Sat Apr 07 05:00:26 GMT 2007
>Originator:     Patrick Eisenacher
>Release:        4.11
>Organization:
>Environment:
FreeBSD eagleeye.test-intern.org 4.11-STABLE FreeBSD 4.11-STABLE #0: Mon Oct  2 13:04:24 CEST 2006     root@eagleeye.test-intern.org:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
if one of the required external files is missing, make fails because some weird characters have slipped into the corresponding conditional tests in the Makefile
>How-To-Repeat:
cd /usr/ports/java/jdk14/
make build
>Fix:
just remove the surplus characters from the Makefile

Patch attached with submission follows:

--- Makefile	Thu Oct 19 21:54:42 2006
+++ Makefile.new	Thu Oct 19 21:56:23 2006
@@ -160,48 +160,48 @@
 LD_LIBRARY_PATH_FILES=	../../hotspot/src/os/bsd/vm/os_bsd.cpp
 
 # Check for JDK sources and patch file
-.if !defined(PACKAGE_BUILDING) && (!exists(${DISTDIR}/${SCSL_SRCFILE}) || !exists(${DISTDIR}/${SCSL_BINFILE}) || (defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE})) || !exists(${DISTDIR}/${PATCHSETFILE}))#{
+.if !defined(PACKAGE_BUILDING) && (!exists(${DISTDIR}/${SCSL_SRCFILE}) || !exists(${DISTDIR}/${SCSL_BINFILE}) || (defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE})) || !exists(${DISTDIR}/${PATCHSETFILE}))
 ECHO_MSG=/usr/bin/printf
 IGNORE= :\n\
 Due to licensing restrictions, certain files must be fetched manually.\n\n
-.if !exists(${DISTDIR}/${SCSL_SRCFILE}) || !exists(${DISTDIR}/${SCSL_BINFILE})#{
+.if !exists(${DISTDIR}/${SCSL_SRCFILE}) || !exists(${DISTDIR}/${SCSL_BINFILE})
 IGNORE += Please open http://www.sun.com/software/java2/download.html\n\
 in a web browser and follow the \"Download\" link for the\n\
 \"Java 2 SDK ${JDK_VERSION}\".  You will be required to log in and register,\n\
 but you can create an account on this page.  After registration and\n\
 accepting the Sun Community Source License, download the\n
-.if !exists(${DISTDIR}/${SCSL_SRCFILE})#{
+.if !exists(${DISTDIR}/${SCSL_SRCFILE})
 IGNORE += SCSL Source file, ${SCSL_SRCFILE}
-.endif#}
-.if !exists(${DISTDIR}/${SCSL_BINFILE})#{
-.if !exists(${DISTDIR}/${SCSL_SRCFILE})#{
+.endif
+.if !exists(${DISTDIR}/${SCSL_BINFILE})
+.if !exists(${DISTDIR}/${SCSL_SRCFILE})
 IGNORE += and the\n
-.endif#}
+.endif
 IGNORE += SCSL Binaries file, ${SCSL_BINFILE}
-.endif#}
+.endif
 IGNORE += .\n\n
-.if !exists(${DISTDIR}/${PATCHSETFILE}) || (defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE}))#{
+.if !exists(${DISTDIR}/${PATCHSETFILE}) || (defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE}))
 IGNORE += In addition, please
-.endif#}
-.elif !exists(${DISTDIR}/${PATCHSETFILE}) || (defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE}))#}{
+.endif
+.elif !exists(${DISTDIR}/${PATCHSETFILE}) || (defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE}))
 IGNORE += Please
-.endif#}
-.if defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE})#{
+.endif
+.if defined(WITH_POLICY) && !exists(${DISTDIR}/${POLICYFILE})
 IGNORE += open http://java.sun.com/products/jce/index-14.html\n\
 in a web browser and follow the \"Download JCE Unlimited Strength\n\
 Jurisdiction Policy Files\" link for \"Other Downloads\" to obtain the\n\
 JCE policy file, ${POLICYFILE}.\n\n
-.if !exists(${DISTDIR}/${PATCHSETFILE})#{
+.if !exists(${DISTDIR}/${PATCHSETFILE})
 IGNORE += In addition, please
-.endif#}
-.endif#}
-.if !exists(${DISTDIR}/${PATCHSETFILE})#{
+.endif
+.endif
+.if !exists(${DISTDIR}/${PATCHSETFILE})
 IGNORE += download the patchset, ${PATCHSETFILE}, from\n\
 http://www.eyesbeyond.com/freebsddom/java/jdk14.html.\n\n
-.endif#}
+.endif
 IGNORE += Please place the downloaded file(s) in ${DISTDIR}
 IGNORE += \n and restart the build.\n\n
-.endif#}
+.endif
 
 # JDK 1.4.2 require recent version of FreeBSD due to recent libc_r updates.
 # Make check for reqiuired primities as early as possible

>Release-Note:
>Audit-Trail:

From: Stefan Walter <stefan@freebsd.org>
To: Patrick Eisenacher <eisenacher@s3-solutions.de>
Cc: GNATS <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: java/104627: Makefile jdk14 broken
Date: Fri, 6 Apr 2007 14:49:26 +0200

 --ZJcv+A0YCCLh2VIg
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Hi,
 
 the weird characters you mention in your problem description in this PR
 [1] are merely Java-style curly braces surrounding code blocks. They
 aren't needed in the Makefile at all, but they shouldn't have any negative
 effect either since they're commented out. Can you still reproduce the
 problem? If yes, what exactly do you mean by "make fails".  Do you get any
 error message?
 
 Regards,
 Stefan
 
 [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=java/104627
 
 --ZJcv+A0YCCLh2VIg
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iQGVAwUBRhZB1laRERsSueCzAQKUowv6At4D8vM/CLsyWfkoFst6WIqBM/Co2bJc
 Dbd96ODWeTKZzbydTZ3zhO84RO1igKK3DYVazHteEnDbHqVyCkuybw1o97EFvvTI
 tfhEe5cWTLnnAsRCh9qciXelPq7FCIso4BBKP/0MDDoOXIT5J8ge6gqi/Rqiyfk0
 A+8SR8TqQ9c6iku5h51JYGGR99UhiwiwCZDsI0rwe3depJTtZ9k48jMuG61NBcH7
 kdUE+hyPpnbLvs9XnvmAI8zQ86B/wLKsAnls02IzUxNEsMlouWOXeYss4vGL/7CY
 RPd/60/qFN0+eT3MO+bs+cXEz3ol34dUYCMzRV6CitF5LKselDV8iSbQOVJ4/5iG
 r9EVHkymHpgs8GyBNhQSck/FXLPxNnF7d7+ghsUwZcQFtFuUvcuFXlngtxdB2t6y
 zpZqqCD4Seg6YowkB79FIlmVr/pSKUSWfJN7Uhzt46pr3mIeqTr+0pbDOhKbySLS
 WlPPhy+FutrJ4ThGfos6+1Rbfe2CxuKr
 =kEDC
 -----END PGP SIGNATURE-----
 
 --ZJcv+A0YCCLh2VIg--
State-Changed-From-To: open->feedback 
State-Changed-By: stefan 
State-Changed-When: Fri Apr 6 13:20:22 UTC 2007 
State-Changed-Why:  
Awaiting feedback from submitter. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104627 
State-Changed-From-To: feedback->closed 
State-Changed-By: glewis 
State-Changed-When: Sat Apr 7 04:59:06 UTC 2007 
State-Changed-Why:  
The commented out curly braces were only a problem for make(1) on FreeBSD 4.x 
which is no longer supported by ports.  Closing. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104627 
>Unformatted:
