From marcel@pluto2.freebsd.org  Tue Nov 13 20:27:35 2007
Return-Path: <marcel@pluto2.freebsd.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1CD6D16A41A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Nov 2007 20:27:35 +0000 (UTC)
	(envelope-from marcel@pluto2.freebsd.org)
Received: from pluto2.freebsd.org (pluto2.freebsd.org [69.147.83.83])
	by mx1.freebsd.org (Postfix) with ESMTP id 10F9F13C44B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Nov 2007 20:27:35 +0000 (UTC)
	(envelope-from marcel@pluto2.freebsd.org)
Received: from pluto2.freebsd.org (localhost [127.0.0.1])
	by pluto2.freebsd.org (8.14.2/8.14.2) with ESMTP id lADKRYmI001805
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Nov 2007 20:27:34 GMT
	(envelope-from marcel@pluto2.freebsd.org)
Received: (from marcel@localhost)
	by pluto2.freebsd.org (8.14.2/8.14.2/Submit) id lADKRY1K001799;
	Tue, 13 Nov 2007 20:27:34 GMT
	(envelope-from marcel)
Message-Id: <200711132027.lADKRY1K001799@pluto2.freebsd.org>
Date: Tue, 13 Nov 2007 20:27:34 GMT
From: Marcel Moolenaar <marcel@pluto2.freebsd.org>
Reply-To: Marcel Moolenaar <marcel@pluto2.freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: cpu_thread_setup() needs teardown counterpart
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         118024
>Category:       ia64
>Synopsis:       cpu_thread_setup() needs teardown counterpart
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ia64
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 13 20:30:01 UTC 2007
>Closed-Date:    Wed Nov 14 20:31:29 UTC 2007
>Last-Modified:  Wed Nov 14 20:31:29 UTC 2007
>Originator:     Marcel Moolenaar
>Release:        FreeBSD 8.0-CURRENT ia64
>Organization:
>Environment:
System: FreeBSD pluto2.freebsd.org 8.0-CURRENT FreeBSD 8.0-CURRENT #2: Sun Nov 11 01:45:35 UTC 2007 marcel@pluto2.freebsd.org:/q/obj/q/8.x/src/sys/PLUTO2 ia64


>Description:
FreeBSD/ia64 (pluto2.freebsd.org) (ttyu3)

login: panic: lock "High FP lock" 0xe0000000104e4640 already initialized
cpuid = 0
KDB: enter: panic
[thread pid 21719 tid 100142 ]
Stopped at      kdb_enter+0x81: [F1]    nop.f 0x0
db> bt
Tracing pid 21719 tid 100142 td 0xe0000000123b1b00
kdb_enter(0xe000000004658d08, 0xe0000000042dac60, 0x793, 0xa000000033be3508) at kdb_enter+0x81
panic(0xe00000000465c710, 0xe000000004689268, 0xe0000000104e4640) at panic+0x2e0
lock_init(0xe0000000104e4640, 0xe0000000047341b8, 0xe000000004689268, 0x0, 0x20000) at lock_init+0x50
mtx_init(0xe0000000104e4640, 0xe000000004689268, 0x0, 0x1) at mtx_init+0x120
cpu_thread_setup(0xe0000000104e4360, 0xe0000000042f77d0, 0x207) at cpu_thread_setup+0x90
thread_alloc(0xe0000000104e4360, 0xe0000000042a95e0) at thread_alloc+0xe0
thread_alloc_spare(0xe0000000123b1b00, 0x2000000000036058, 0x10, 0xe0000000042ab620, 0x896) at thread_alloc_spare+0x30
thread_userret(0xe0000000123b1b00, 0xe0000000123a3080, 0x0, 0x0) at thread_userret+0xfe0
userret(0xe0000000123b1b00, 0xa000000033be3550, 0xe0000000123b1b00, 0xe0000000042c4d60) at userret+0x140
fork_return(0xe0000000123b1b00, 0xa000000033be3550, 0xe00000000429f7b0, 0x40c) at fork_return+0x30
fork_exit(0xe0000000046f8c70, 0xe0000000123b1b00, 0xa000000033be3550) at fork_exit+0x110
enter_userland() at enter_userland
db> reset

thread_init() calls cpu_thread_setup(), but thread_fini() has no
counterpart (e.g. cpu_thread_teardown()). As such, the mtx_init()
called from cpu_thread_setup() has no corresponding mtx_destroy().


>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ia64/118024: commit references a PR
Date: Wed, 14 Nov 2007 20:22:03 +0000 (UTC)

 marcel      2007-11-14 20:21:54 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/amd64/amd64      vm_machdep.c 
     sys/arm/arm          vm_machdep.c 
     sys/i386/i386        vm_machdep.c 
     sys/ia64/ia64        machdep.c vm_machdep.c 
     sys/kern             kern_thread.c 
     sys/powerpc/powerpc  vm_machdep.c 
     sys/sparc64/sparc64  vm_machdep.c 
     sys/sun4v/sun4v      vm_machdep.c 
     sys/sys              proc.h 
   Log:
   o  Rename cpu_thread_setup() to cpu_thread_alloc() to better
      communicate that it relates to (is called by) thread_alloc()
   o  Add cpu_thread_free() which is called from thread_free()
      to counter-act cpu_thread_alloc().
   
   i386:   Have cpu_thread_free() call cpu_thread_clean() to
           preserve behaviour.
   ia64:   Have cpu_thread_free() call mtx_destroy() for the
           mutex initialized in cpu_thread_alloc().
   
   PR: ia64/118024
   
   Revision  Changes    Path
   1.256     +6 -1      src/sys/amd64/amd64/vm_machdep.c
   1.35      +8 -3      src/sys/arm/arm/vm_machdep.c
   1.284     +8 -1      src/sys/i386/i386/vm_machdep.c
   1.227     +1 -1      src/sys/ia64/ia64/machdep.c
   1.95      +8 -1      src/sys/ia64/ia64/vm_machdep.c
   1.260     +2 -2      src/sys/kern/kern_thread.c
   1.117     +6 -1      src/sys/powerpc/powerpc/vm_machdep.c
   1.77      +7 -2      src/sys/sparc64/sparc64/vm_machdep.c
   1.8       +7 -2      src/sys/sun4v/sun4v/vm_machdep.c
   1.495     +2 -1      src/sys/sys/proc.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: marcel 
State-Changed-When: Wed Nov 14 20:30:49 UTC 2007 
State-Changed-Why:  
Fixed. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=118024 
>Unformatted:
