From nobody@FreeBSD.org  Fri Apr 28 07:38:54 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8DF2C16A401
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Apr 2006 07:38:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 02D7143D64
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Apr 2006 07:38:47 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k3S7clAf018227
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Apr 2006 07:38:47 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k3S7clXE018226;
	Fri, 28 Apr 2006 07:38:47 GMT
	(envelope-from nobody)
Message-Id: <200604280738.k3S7clXE018226@www.freebsd.org>
Date: Fri, 28 Apr 2006 07:38:47 GMT
From: Yuichiro Goto <y7goto@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: twiddle in cdboot does not work
X-Send-Pr-Version: www-2.3

>Number:         96452
>Category:       i386
>Synopsis:       twiddle in cdboot does not work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 28 07:40:13 GMT 2006
>Closed-Date:    Wed Mar 07 13:46:49 GMT 2007
>Last-Modified:  Wed Mar 07 13:46:49 GMT 2007
>Originator:     Yuichiro Goto
>Release:        FreeBSD 6.1-RC1
>Organization:
>Environment:
FreeBSD cobalt.my.domain 6.1-RC FreeBSD 6.1-RC #0: Wed Apr 26 10:38:08 JST 2006     root@cobalt.my.domain:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
twiddle in src/sys/boot/i386/cdboot.s does not work, because when XLAT instruction is executed, BX register must hold the address of a table of twiddle chars, but two characters of twiddle chars are in BX register instead.
>How-To-Repeat:
Boot using cdboot.
>Fix:
Index: cdboot.s
===================================================================
RCS file: /home/ncvs/src/sys/boot/i386/cdboot/cdboot.s,v
retrieving revision 1.13.12.1
diff -u -r1.13.12.1 cdboot.s
--- cdboot.s    18 Apr 2006 13:51:12 -0000      1.13.12.1
+++ cdboot.s    28 Apr 2006 07:36:48 -0000
@@ -472,7 +472,7 @@
 twiddle:       push %ax                        # Save
                push %bx                        # Save
                mov twiddle_index,%al           # Load index
-               mov twiddle_chars,%bx           # Address table
+               mov $twiddle_chars,%bx          # Address table
                inc %al                         # Next
                and $3,%al                      #  char
                mov %al,twiddle_index           # Save index for next call

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Thu Feb 22 21:03:32 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96452 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Fri Feb 23 21:08:34 UTC 2007 
State-Changed-Why:  
I just committed this fix to HEAD, will commit to the remaining 
branches in a couple of days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96452 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: i386/96452: commit references a PR
Date: Fri, 23 Feb 2007 21:07:51 +0000 (UTC)

 remko       2007-02-23 21:07:44 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/boot/i386/cdboot cdboot.s 
   Log:
   Fix the cdboot twiddle display.
   I created and tested this with a custom FreeSBIE cd-image.
   
   PR:             i386/96452
   Submitted by:   Yuichiro Goto <y7goto at gmail dot com>
   MFC after:      3 days
   Approved by:    imp (mentor)
   
   Revision  Changes    Path
   1.17      +1 -1      src/sys/boot/i386/cdboot/cdboot.s
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: i386/96452: commit references a PR
Date: Tue,  6 Mar 2007 18:28:37 +0000 (UTC)

 remko       2007-03-06 18:28:28 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/boot/i386/cdboot cdboot.s 
   Log:
   MFC cdboot.s rev 1.17
   
     Fix the cdboot twiddle display.
     I created and tested this with a custom FreeSBIE cd-image.
   
     PR:             i386/96452
     Submitted by:   Yuichiro Goto <y7goto at gmail dot com>
     MFC after:      3 days
     Approved by:    imp (mentor)
   
   Approved by:    imp (mentor)
   
   Revision  Changes    Path
   1.13.8.4  +1 -1      src/sys/boot/i386/cdboot/cdboot.s
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Wed Mar 7 13:46:48 UTC 2007 
State-Changed-Why:  
The patch has been committed to -HEAD and 6-STABLE, thanks for the 
submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96452 
>Unformatted:
