From root@inbox.lv  Sun Apr 25 13:16:34 2004
Return-Path: <root@inbox.lv>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 15EEE16A4CE; Sun, 25 Apr 2004 13:16:34 -0700 (PDT)
Received: from gull.mail.pas.earthlink.net (gull.mail.pas.earthlink.net [207.217.120.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EA89C43D62; Sun, 25 Apr 2004 13:16:33 -0700 (PDT)
	(envelope-from root@inbox.lv)
Received: from pool0448.cvx36-bradley.dialup.earthlink.net ([216.244.19.193] helo=ringworm.mojavegreen.com)
	by gull.mail.pas.earthlink.net with esmtp (Exim 3.33 #1)
	id 1BHq3C-0005Kr-00; Sun, 25 Apr 2004 13:16:31 -0700
Received: by ringworm.mojavegreen.com (Postfix, from userid 0)
	id D3AB48455; Sun, 25 Apr 2004 13:12:28 -0700 (PDT)
Message-Id: <20040425201228.D3AB48455@ringworm.mojavegreen.com>
Date: Sun, 25 Apr 2004 13:12:28 -0700 (PDT)
From: Michael C.Shultz <ringworm@inbox.lv>
Reply-To: Michael C.Shultz <ringworm@inbox.lv>
To: FreeBSD-gnats-submit@freebsd.org
Cc: freebsd-stable@freebsd.org
Subject: make buildworld fails for STABLE
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         65965
>Category:       i386
>Synopsis:       make buildworld fails for STABLE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-i386
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 25 13:20:13 PDT 2004
>Closed-Date:    Sun Apr 25 13:56:24 PDT 2004
>Last-Modified:  Sun Apr 25 14:10:12 PDT 2004
>Originator:     Michael C. Shultz <ringworm@inbox.lv>
>Release:        FreeBSD 4.10-BETA i386
>Organization:
Mojavegreen Software Co.
>Environment:
System: FreeBSD ringworm.mojavegreen.com 4.10-BETA FreeBSD 4.10-BETA #0: Wed Apr 7 20:15:25 PDT 2004 mike@ringworm.home.com:/speed/usr.obj/storage/usr.src/sys/RINGWORM i386


>Description:

Build world for STABLE failed for me this morning with:

/usr.src/sbin/ifconfig/ifconfig.c:288: `IFCAP_POLLING' undeclared here (not in a function)
/usr.src/sbin/ifconfig/ifconfig.c:288: initializer element is not constant
/usr.src/sbin/ifconfig/ifconfig.c:288: (near initialization for `cmds[71].c_parameter')
/usr.src/sbin/ifconfig/ifconfig.c:289: `IFCAP_POLLING' undeclared here (not in a function)
/usr.src/sbin/ifconfig/ifconfig.c:289: initializer element is not constant
/storage/usr.src/sbin/ifconfig/ifconfig.c:289: (near initialization for `cmds[72].c_parameter')


>How-To-Repeat:

	cd /usr/src
	make buildworld

>Fix:

	The problem is in /usr/src/sbin/ifconfig/ifconfig.c there is a line:

	#include <net/if.h>

	that prevents the new if.h at /usr/src/sys/net/if.h

	from being read. 
	it should read:

	#include "../../sys/net/if.h"

	inorder to pull the new if.h

	So I am including a patch for /usr/src/sbin/ifconfig/ifconfig.c
	below: 
	PS: I've never sent a patch before, if this is wrong please
	explain or tell me where I can find the correct what to do it. Thanks.

--- ifconfig.c.ORIG     Sun Apr 25 12:38:02 2004
+++ ifconfig.c  Sun Apr 25 12:53:02 2004
@@ -54,7 +54,11 @@
 #include <sys/linker.h>

 #include <net/ethernet.h>
+/**************************
 #include <net/if.h>
+***************************/
+ #include "../../sys/net/if.h"
+/***************************/
 #include <net/if_var.h>
 #include <net/if_dl.h>
 #include <net/if_types.h>


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: simon 
State-Changed-When: Sun Apr 25 13:55:53 PDT 2004 
State-Changed-Why:  
During buildworld a new set of headers is created/installed for use 
during build, so <net/if.h> should give the correct updated header. 
It sounds like you have some old stuff in your build environment.  Try 
removing your /usr/obj tree, running 'make cleandir', and then retry   
the build.                                                           

For the development branches it is also better just to write a mail to 
the appropriate list (freebsd-stable in this case) instead of sending  
PR's for stuff like this (build errors and so on).                    

I just did test buildworld of 4-STABLE (on a 4.9-R) and that 
succeeded, so I'm closing the PR. 

In any case, thanks for the effort. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65965 

From: "Michael C. Shultz" <ringworm@inbox.lv>
To: freebsd-gnats-submit@FreeBSD.org, ringworm@inbox.lv
Cc:  
Subject: Re: i386/65965: make buildworld fails for STABLE
Date: Sun, 25 Apr 2004 13:59:24 -0700

 I just read in the problem report article this:
 
 "...and make sure to specify the exact CVS revision numbers of the files you 
 modified so the developers who read your report will be able to apply them 
 easily. "
 
 So is this the information they mean?
 
 static const char rcsid[] =
   "$FreeBSD: src/sbin/ifconfig/ifconfig.c,v 1.51.2.22 2004/04/22 22:03:26 ru 
 Exp $";
 #endif /* not lint */
 
>Unformatted:
