From hsn@netmag.cz  Mon Feb  9 09:21:52 2004
Return-Path: <hsn@netmag.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 40A0B16A4D0
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Feb 2004 09:21:41 -0800 (PST)
Received: from mail.tiscali.cz (stateless3.tiscali.cz [213.235.135.72])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA45C43D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Feb 2004 09:21:40 -0800 (PST)
	(envelope-from hsn@netmag.cz)
Received: from asura.bsd (212.11.96.14) by mail.tiscali.cz (6.7.018)
        id 3FB969350158D24D for FreeBSD-gnats-submit@freebsd.org; Mon, 9 Feb 2004 18:21:38 +0100
Received: from hsn@localhost
	by asura.bsd (Exim 4.24_4 FreeBSD) id 1ApuXc-0000xL-Bu
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 08 Feb 2004 20:24:28 +0100
Message-Id: <E1ApuXc-0000xL-Bu@asura.bsd>
Date: Sun, 08 Feb 2004 20:24:28 +0100
From: Radim Kolar <hsn@netmag.cz>
Reply-To: Radim Kolar <hsn@netmag.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: npx.c do not compiles without ISA bus configured
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         62595
>Category:       i386
>Synopsis:       npx.c do not compiles without ISA bus configured
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-i386
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 09 09:30:21 PST 2004
>Closed-Date:    Mon Feb 09 12:27:42 PST 2004
>Last-Modified:  Mon Feb  9 18:30:19 PST 2004
>Originator:     Radim Kolar
>Release:        FreeBSD 5.2-RELEASE-p2 i386
>Organization:
Sanatana Dharma
>Environment:
System: FreeBSD asura.bsd 5.2-RELEASE-p2 FreeBSD 5.2-RELEASE-p2 #2: Sun Feb 8 16:07:05 CET 2004 root@asura.bsd:/usr/src/sys/i386/compile/GENERIC i386

	
>Description:
If you don't have 'device isa' entry in kernel configuration, kernel
build will fail in npx driver. I want to build a smallest possible kernel,
so i have commeted isa bus out.
>How-To-Repeat:
asura# make NO_MODULES=yes
cc -c -O -pipe -mcpu=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Wstric
t-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fforma
t-extensions -std=c99 -g -nostdinc -I-  -I. -I../../.. -I../../../contrib/dev/ac
pica -I../../../contrib/ipfilter -I../../../contrib/dev/ath -I../../../contrib/d
ev/ath/freebsd -I../../../contrib/ngatm -D_KERNEL -include opt_global.h -fno-com
mon -finline-limit=15000 -fno-strict-aliasing  -mno-align-long-strings -mpreferr
ed-stack-boundary=2 -ffreestanding -Werror  ../../../i386/isa/npx.c
../../../i386/isa/npx.c:1032: warning: `npx_driver' defined but not used
../../../i386/isa/npx.c:1038: warning: `npx_devclass' defined but not used
*** Error code 1

Stop in /usr/src/sys/i386/compile/DEBUG.
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Mon Feb 9 12:27:41 PST 2004 
State-Changed-Why:  
isa is not optional on i386. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62595 

From: Bruce Evans <bde@zeta.org.au>
To: Radim Kolar <hsn@netmag.cz>
Cc: FreeBSD-gnats-submit@freebsd.org, freebsd-i386@freebsd.org
Subject: Re: i386/62595: npx.c do not compiles without ISA bus configured
Date: Tue, 10 Feb 2004 13:20:17 +1100 (EST)

 On Sun, 8 Feb 2004, Radim Kolar wrote:
 
 > >Description:
 > If you don't have 'device isa' entry in kernel configuration, kernel
 > build will fail in npx driver. I want to build a smallest possible kernel,
 > so i have commeted isa bus out.
 
 Try this patch.  i386 require isa so leaving it out will give a kernel
 hat won't actually work, however.  The NPX_ISA ifdefs in npx.c basically
 leave out isa-pnp, not isa, and some i386 kernels configured without isa
 can only be linked because not configuring it doesn't actually leave out
 all the isa bits.
 
 %%%
 Index: npx.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/i386/isa/npx.c,v
 retrieving revision 1.144
 diff -u -2 -r1.144 npx.c
 --- npx.c	3 Nov 2003 21:53:38 -0000	1.144
 +++ npx.c	10 Feb 2004 01:30:35 -0000
 @@ -1038,5 +1038,4 @@
  static devclass_t npx_devclass;
 
 -#ifdef DEV_ISA
  /*
   * We prefer to attach to the root nexus so that the usual case (exception 16)
 @@ -1045,4 +1044,5 @@
  DRIVER_MODULE(npx, nexus, npx_driver, npx_devclass, 0, 0);
 
 +#ifdef DEV_ISA
  /*
   * This sucks up the legacy ISA support assignments from PNPBIOS/ACPI.
 %%%
 
 Bruce
>Unformatted:
