From petri@ibr.cs.tu-bs.de  Fri Jun  9 08:58:35 1995
Received: from ra.ibr.cs.tu-bs.de (ra.ibr.cs.tu-bs.de [134.169.246.34])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id IAA15721
          ; Fri, 9 Jun 1995 08:58:29 -0700
Received: from achill [134.169.34.18] by ra.ibr.cs.tu-bs.de (8.6.10/tubsibr) with ESMTP id RAA18454; Fri, 9 Jun 1995 17:58:16 +0200
Received: from petri@localhost by achill.ibr.cs.tu-bs.de (8.6.10/tubsibr) id RAA05474; Fri, 9 Jun 1995 17:58:15 +0200
Message-Id: <199506091558.RAA05474@achill.ibr.cs.tu-bs.de>
Date: Fri, 9 Jun 1995 17:58:15 +0200
From: Stefan Petri <petri@ibr.cs.tu-bs.de>
Reply-To: petri@ibr.cs.tu-bs.de
To: FreeBSD-gnats-submit@freebsd.org, bugs@freebsd.org
Subject: missing break in isa/if_el.c causes panic in bpf.c + fix
X-Send-Pr-Version: 3.2

>Number:         548
>Category:       i386
>Synopsis:       missing break in isa/if_el.c causes panic in bpf.c + fix
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs (FreeBSD bugs mailing list)
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 23 07:38:32 1995
>Closed-Date:    Sat Jun 24 08:28:46 MET DST 1995
>Last-Modified:
>Originator:     Stefan Petri
>Release:        FreeBSD 2.0-950412-SNAP i386
>Organization:
TU Braunschweig, Inst. f. Betriebssysteme u. Rechnerverbund
>Environment:

	FreeBSD 2.0-950412-SNAP, some PC with (dont laugh) 3C501 Ethernet
	card.

>Description:

	The kernel's bpf module panics when turning off promiscous mode
	on a 3C501 ethernet card (interface el0). The reason is a missing
	``break'' statement after the SIOCSIFFLAGS case in the big switch
	in el_ioctl() in i386/isa/if_el.c

>How-To-Repeat:

	> tcpdump -i el0
	tcpdump: listening on el0
	[..packet printout deleted..]
	^C

	panic: bpf: ifpromisc failed
	[..]

>Fix:
	

*** /usr/src/sys/i386/isa/if_el.c-2.0-950412-SNAP	Wed Apr 12 22:47:48 1995
--- if_el.c	Thu Jun  8 19:13:53 1995
***************
*** 768,773 ****
--- 768,774 ----
  		    	    ((ifp->if_flags & IFF_RUNNING) == 0))
  				el_init(ifp->if_unit);
  		}
+ 		break;
  
  	case SIOCSIFMTU:
  


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Sat Jun 24 08:28:46 MET DST 1995 
State-Changed-Why:  
The problem has already been fixed in 2.0.5R, and the fixe moved into 
the HEAD by revision 1.14 of if_el.c. 
>Unformatted:



