From matthias.andree@web.de  Wed Apr 17 19:06:38 2002
Return-Path: <matthias.andree@web.de>
Received: from krusty.e-technik.uni-dortmund.de (krusty.E-Technik.Uni-Dortmund.DE [129.217.163.1])
	by hub.freebsd.org (Postfix) with ESMTP id CD80637B417
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 Apr 2002 19:06:37 -0700 (PDT)
Received: from merlin.emma.line.org (localhost [127.0.0.1])
	by krusty.e-technik.uni-dortmund.de (Postfix) with ESMTP id CDF9CA3831
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 18 Apr 2002 04:06:35 +0200 (CEST)
Received: from gandalf.emma.line.org (unknown [192.168.0.66])
	by merlin.emma.line.org (Postfix) with ESMTP
	id 786AEB277; Thu, 18 Apr 2002 04:06:32 +0200 (CEST)
Received: by gandalf.emma.line.org (Postfix, from userid 1000)
	id E31EA2B; Thu, 18 Apr 2002 04:06:33 +0200 (CEST)
Message-Id: <20020418020633.E31EA2B@gandalf.emma.line.org>
Date: Thu, 18 Apr 2002 04:06:33 +0200 (CEST)
From: Matthias Andree <matthias.andree@web.de>
Reply-To: Matthias Andree <matthias.andree@web.de>
To: FreeBSD-gnats-submit@freebsd.org
Subject: make.conf/bsd.cpu.mk: i486 does not set -march.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         37212
>Category:       i386
>Synopsis:       make.conf/bsd.cpu.mk: i486 does not set -march.
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 17 19:10:02 PDT 2002
>Closed-Date:    Fri Jul 19 01:11:16 PDT 2002
>Last-Modified:  Fri Jul 19 01:11:16 PDT 2002
>Originator:     Matthias Andree
>Release:        FreeBSD 4.5-RELEASE-p3 i386
>Organization:
>Environment:
System: FreeBSD gandalf 4.5-RELEASE-p3 FreeBSD 4.5-RELEASE-p3 #0: Wed Apr 17 19:25:25 CEST 2002 root@emma1.emma.line.org:/usr/src_release/src/sys/compile/GANDALF i386


	
>Description:
When /etc/make.conf sets CPUTYPE=i486, -m486 (which is a synonym for
-mcpu=i486) will be added to the gcc options. However, CPUTYPE=i586 sets
-march=i586, which can make quite a difference because it drops i386 and
i486 compatibility.

I'd find it more consistent if CPUTYPE=i486 used -march=i486 (dropping
i386 compatibility) instead of -mcpu=i486 (-m486).
	
>How-To-Repeat:
	
>Fix:
Here's a patch against /usr/share/mk/bsd.cpu.mk:

--- /usr/share/mk/bsd.cpu.mk.orig	Thu Apr 18 03:49:38 2002
+++ /usr/share/mk/bsd.cpu.mk	Thu Apr 18 03:50:03 2002
@@ -49,7 +49,7 @@
 .  elif ${CPUTYPE} == "i586"
 _CPUCFLAGS = -march=pentium
 .  elif ${CPUTYPE} == "i486"
-_CPUCFLAGS = -m486
+_CPUCFLAGS = -march=i486
 .  endif
 . elif ${MACHINE_ARCH} == "alpha"
 .  if ${CPUTYPE} == "ev6"
	


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: ru 
State-Changed-When: Thu Apr 18 02:35:41 PDT 2002 
State-Changed-Why:  
Committed into 5.0-CURRENT, thanks! 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: ru 
Responsible-Changed-When: Thu Apr 18 02:35:41 PDT 2002 
Responsible-Changed-Why:  
MFC in three days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37212 
State-Changed-From-To: patched->closed 
State-Changed-By: ru 
State-Changed-When: Fri Jul 19 01:09:50 PDT 2002 
State-Changed-Why:  
Committed to 4.6-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37212 
>Unformatted:
