From avatar@www.mmlab.cse.yzu.edu.tw  Thu Sep 21 08:46:19 2000
Return-Path: <avatar@www.mmlab.cse.yzu.edu.tw>
Received: from www.mmlab.cse.yzu.edu.tw (www.mmlab.cse.yzu.edu.tw [140.138.145.166])
	by hub.freebsd.org (Postfix) with SMTP id 11E1037B42C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 21 Sep 2000 08:39:57 -0700 (PDT)
Received: (qmail 4983 invoked by uid 1000); 21 Sep 2000 15:12:35 -0000
Message-Id: <20000921151235.4982.qmail@www.mmlab.cse.yzu.edu.tw>
Date: 21 Sep 2000 15:12:35 -0000
From: avatar@mmlab.cse.yzu.edu.tw
Sender: avatar@www.mmlab.cse.yzu.edu.tw
Reply-To: avatar@mmlab.cse.yzu.edu.tw
To: FreeBSD-gnats-submit@freebsd.org
Subject: ESS audio mixer with speaker support
X-Send-Pr-Version: 3.2

>Number:         21452
>Category:       i386
>Synopsis:       Add speaker volume adjusting support for ESS audio mixer
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    cg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 21 08:50:00 PDT 2000
>Closed-Date:    Sun Apr 8 14:24:53 PDT 2001
>Last-Modified:  Sun Apr 08 14:27:37 PDT 2001
>Originator:     Tai-hwa Liang
>Release:        FreeBSD 3.4-RELEASE i386
>Organization:
Multimedia Laboratory at Yuan Ze University
>Environment:

	FreeBSD 4.1-RELEASE, with newpcm:

		FreeBSD Audio Driver (newpcm) Sep  1 2000 08:21:59
		Installed devices:
		pcm0: <ESS 1869 DSP> at io 0x220 irq 5 drq 3:5 (1p/1r channels)


>Description:

	Add(missing in current newpcm?) speaker volume adjusting support
for ESS audio mixer.


>How-To-Repeat:

	Apply patch(against src/sys/dev/sound/isa/ess.c,v 1.3.2.1) in Fix
section.

>Fix:
	
	

--- sys/dev/sound/isa/ess.c.old	Thu Sep 21 23:02:20 2000
+++ sys/dev/sound/isa/ess.c	Thu Sep 21 22:31:49 2000
@@ -722,7 +722,7 @@
 
 	mix_setdevs(m, SOUND_MASK_SYNTH | SOUND_MASK_PCM | SOUND_MASK_LINE |
 		       SOUND_MASK_MIC | SOUND_MASK_CD | SOUND_MASK_VOLUME |
-		       SOUND_MASK_LINE1);
+		       SOUND_MASK_LINE1 | SOUND_MASK_SPEAKER);
 
 	ess_setmixer(sc, 0, 0); /* reset */
 
@@ -766,6 +766,10 @@
 	case SOUND_MIXER_CD:
 		preg = 0x38;
 		rreg = 0x6a;
+		break;
+
+	case SOUND_MIXER_SPEAKER:
+		preg = 0x3c;
 		break;
 
 	case SOUND_MIXER_VOLUME:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->cg 
Responsible-Changed-By: johan 
Responsible-Changed-When: Sun Sep 24 12:57:07 PDT 2000 
Responsible-Changed-Why:  
Over to pcm maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=21452 
State-Changed-From-To: open->closed 
State-Changed-By: greid 
State-Changed-When: Sun Apr 8 14:24:53 PDT 2001 
State-Changed-Why:  
Committed to -current (rev 1.16), MFC'd to -stable (rev 1.3.2.4) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=21452 
>Unformatted:
 
