From dan@kulesh.obluda.cz  Sun Dec 30 20:49:36 2007
Return-Path: <dan@kulesh.obluda.cz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7696916A418
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Dec 2007 20:49:36 +0000 (UTC)
	(envelope-from dan@kulesh.obluda.cz)
Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz [78.128.192.10])
	by mx1.freebsd.org (Postfix) with ESMTP id 0896913C4D3
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Dec 2007 20:49:35 +0000 (UTC)
	(envelope-from dan@kulesh.obluda.cz)
Received: from kulesh.obluda.cz (openvpn.ms.mff.cuni.cz [195.113.20.87])
	by smtp1.kolej.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id lBUKnJqm027679
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Dec 2007 21:49:21 +0100 (CET)
	(envelope-from dan@kulesh.obluda.cz)
Received: from kulesh.obluda.cz (localhost. [127.0.0.1])
	by kulesh.obluda.cz (8.14.2/8.14.2) with ESMTP id lBUKmvFA044264
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Dec 2007 21:48:57 +0100 (CET)
	(envelope-from dan@kulesh.obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.14.2/8.14.1/Submit) id lBUKmvPu044263;
	Sun, 30 Dec 2007 21:48:57 +0100 (CET)
	(envelope-from dan)
Message-Id: <200712302048.lBUKmvPu044263@kulesh.obluda.cz>
Date: Sun, 30 Dec 2007 21:48:57 +0100 (CET)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Typo in bus_dmamem_alloc()
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119175
>Category:       i386
>Synopsis:       [busdma] [patch] Typo in bus_dmamem_alloc()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-i386
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 30 20:50:00 UTC 2007
>Closed-Date:    Wed Mar 30 06:21:49 UTC 2011
>Last-Modified:  Wed Mar 30 06:21:49 UTC 2011
>Originator:     Dan Lukes
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
Obludarium
>Environment:
src/sys/i386/i386/busdma_machdep.c,v 1.74.2.5 2007/05/02 18:48:1
but it apply to HEAD's version as well

>Description:

	KTR record ENOMEM error message even if bus_dmamem_alloc() succesfull

>How-To-Repeat:
>Fix:


--- sys/i386/i386/busdma_machdep.c.ORIG	2007-12-30 21:35:48.000000000 +0100
+++ sys/i386/i386/busdma_machdep.c	2007-12-30 21:37:40.000000000 +0100
@@ -529,8 +529,8 @@
 	if (flags & BUS_DMA_NOCACHE)
 		pmap_change_attr((vm_offset_t)*vaddr, dmat->maxsize,
 		    PAT_UNCACHEABLE);
-	CTR4(KTR_BUSDMA, "%s: tag %p tag flags 0x%x error %d",
-	    __func__, dmat, dmat->flags, ENOMEM);
+	CTR3(KTR_BUSDMA, "%s: tag %p tag flags 0x%x",
+	    __func__, dmat, dmat->flags);
 	return (0);
 }
 
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: remko 
State-Changed-When: Wed Jul 14 08:20:01 UTC 2010 
State-Changed-Why:  
Hello Dan, 

The code is not entirely the same as in your report, is it still 
relevant? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119175 
State-Changed-From-To: feedback->closed 
State-Changed-By: remko 
State-Changed-When: Wed Mar 30 06:21:48 UTC 2011 
State-Changed-Why:  
I cannot recall having received information about this: Fedback timeout 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119175 
>Unformatted:
