From nobody@FreeBSD.org  Tue May 29 17:40:24 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 038E316A468
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 May 2007 17:40:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id E8ED613C45A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 May 2007 17:40:23 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l4THeNVm013290
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 May 2007 17:40:23 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l4THeN7D013289;
	Tue, 29 May 2007 17:40:23 GMT
	(envelope-from nobody)
Message-Id: <200705291740.l4THeN7D013289@www.freebsd.org>
Date: Tue, 29 May 2007 17:40:23 GMT
From: Pankov Pavel<pankov_p@mail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Add PDCM bit name to CPU Features2
X-Send-Pr-Version: www-3.0

>Number:         113133
>Category:       i386
>Synopsis:       Add PDCM bit name to CPU Features2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 29 17:50:03 GMT 2007
>Closed-Date:    Thu Dec 25 21:23:42 UTC 2008
>Last-Modified:  Thu Dec 25 21:23:42 UTC 2008
>Originator:     Pankov Pavel
>Release:        6.0-RELEASE-p4
>Organization:
MPEI
>Environment:
FreeBSD pankovpv.sovietservers.com 6.0-RELEASE-p4 FreeBSD 6.0-RELEASE-p4 #8: Mon Feb 27 09:09:25 MSK 2006     root@CRYO.SOVIETSERVERS.COM:/usr/obj/usr/src/sys/CRYO  i386
>Description:
According to "Intel 64 and IA-32 Architectures Software Developer's Manual Volume 2A: Instruction Set Reference, A-M" (http://developer.intel.com/design/processor/manuals/253666.pdf) the PDCM bit name in extended CPU features displaying code in -CURRENT is missing. Attached patch fixes it. This bit is set, for example, in my Core 2 Duo T5600.

Also, RELENG_6 lacks names for SMX, SSSE3, xTPR, PDCM bits. I think they can be MFC'd safely and easily.
>How-To-Repeat:
Boot on the CPU that has highlighted bits set.
>Fix:
Apply the attached patch to -CURRENT (can also be downloaded here: http://www.pankov.pp.ru/patches/identcpu-PDCM.diff).

Patch attached with submission follows:

Index: i386/i386/identcpu.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/i386/identcpu.c,v
retrieving revision 1.177
diff -u -r1.177 identcpu.c
--- i386/i386/identcpu.c	18 Apr 2007 10:08:24 -0000	1.177
+++ i386/i386/identcpu.c	29 May 2007 17:06:50 -0000
@@ -750,7 +750,7 @@
 				"\015<b12>"
 				"\016CX16"	/* CMPXCHG16B Instruction */
 				"\017xTPR"	/* Send Task Priority Messages*/
-				"\020<b15>"
+				"\020PDCM"	/* Perf/Debug Capability MSR */
 				"\021<b16>"
 				"\022<b17>"
 				"\023DCA"	/* Direct Cache Access */


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->des 
Responsible-Changed-By: des 
Responsible-Changed-When: Tue May 29 19:05:43 UTC 2007 
Responsible-Changed-Why:  
Low-hanging fruit 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113133 
State-Changed-From-To: open->patched 
State-Changed-By: des 
State-Changed-When: Tue May 29 19:26:23 UTC 2007 
State-Changed-Why:  
Awaiting MFC 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113133 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: i386/113133: commit references a PR
Date: Tue, 29 May 2007 19:21:59 +0000 (UTC)

 des         2007-05-29 19:21:53 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/i386/i386        identcpu.c 
   Log:
   Add feature name for features2 bit 15.
   
   PR:             i386/113133
   Submitted by:   Pankov Pavel <pankov_p@mail.ru>
   MFC after:      3 days
   
   Revision  Changes    Path
   1.178     +1 -1      src/sys/i386/i386/identcpu.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->suspended 
State-Changed-By: linimon 
State-Changed-When: Thu Feb 28 21:54:50 UTC 2008 
State-Changed-Why:  
This is now in 6.x and 7.0.  When 5.x goes EOL we'll just close it (EOL 
is in a few months). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113133 
State-Changed-From-To: suspended->closed  
State-Changed-By: brucec 
State-Changed-When: Thu Dec 25 21:22:54 UTC 2008 
State-Changed-Why:  
5.x has gone EOL. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113133 
>Unformatted:
