From thomas@cuivre.fr.eu.org  Mon Mar 26 00:03:39 2007
Return-Path: <thomas@cuivre.fr.eu.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EC95916A401
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Mar 2007 00:03:39 +0000 (UTC)
	(envelope-from thomas@cuivre.fr.eu.org)
Received: from melamine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org [82.225.155.84])
	by mx1.freebsd.org (Postfix) with ESMTP id B384813C489
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Mar 2007 00:03:39 +0000 (UTC)
	(envelope-from thomas@cuivre.fr.eu.org)
Received: by melamine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id 6681A5C0FD; Mon, 26 Mar 2007 02:03:36 +0200 (CEST)
Message-Id: <20070326000336.6681A5C0FD@melamine.cuivre.fr.eu.org>
Date: Mon, 26 Mar 2007 02:03:36 +0200 (CEST)
From: Thomas Quinot <thomas@cuivre.fr.eu.org>
Reply-To: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: boot0sio never sets port speed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         110828
>Category:       i386
>Synopsis:       boot0sio never sets port speed
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    thomas
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 26 00:10:03 GMT 2007
>Closed-Date:    Wed Apr 11 07:20:15 GMT 2007
>Last-Modified:  Wed Apr 11 07:30:02 GMT 2007
>Originator:     Thomas Quinot
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD melamine.cuivre.fr.eu.org 6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Mar 18 12:49:35 CET 2007 thomas@melamine.cuivre.fr.eu.org:/space/build/obj/space/build/src/RELENG_6/sys/SMP i386


	
>Description:
	A junk value is passed in AX when bioscom is called to set up serial
	port parameters because COMSPEED is treated as an address instead of
	an immediate value. This causes the port parameters not to be set.

>How-To-Repeat:
	
>Fix:

Index: boot0.S
===================================================================
RCS file: /space/mirror/ncvs/src/sys/boot/i386/boot0/boot0.S,v
retrieving revision 1.14.2.1
diff -u -r1.14.2.1 boot0.S
--- boot0.S	31 May 2006 21:32:24 -0000	1.14.2.1
+++ boot0.S	25 Mar 2007 23:56:53 -0000
@@ -96,7 +96,7 @@
 /*
  * Initialize the serial port.  bioscom preserves the driver number in DX.
  */
-		movw COMSPEED,%ax		# defined by Makefile
+		movw $COMSPEED,%ax		# defined by Makefile
 		callw bioscom
 #endif
 /*


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->thomas 
Responsible-Changed-By: thomas 
Responsible-Changed-When: Mon Mar 26 00:14:03 UTC 2007 
Responsible-Changed-Why:  
I'll take care of this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110828 

From: Thomas Quinot <thomas@FreeBSD.ORG>
To: jhb@freebsd.org
Cc: bug-followup@freebsd.org
Subject: Re: i386/110828: boot0sio never sets port speed
Date: Mon, 26 Mar 2007 02:32:24 +0200

 John,
 
 Since you have done some changes with respect to the setting of port
 speed in boot0sio, I'd appreciate if you could have a look at this PR.
 It looks to me like we are really passing a wrong value to bioscom,
 causing the speed to never be set (even when COMSPEED == 0).
 
 The fix is simple (see patch in PR), but I'd rather have at least a
 second pair of eyeballs on it before checking it in.
 
 Thanks!
 Thomas.
 

From: John Baldwin <jhb@freebsd.org>
To: Thomas Quinot <thomas@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: i386/110828: boot0sio never sets port speed
Date: Mon, 26 Mar 2007 11:49:55 -0400

 On Sunday 25 March 2007 08:32:24 pm Thomas Quinot wrote:
 > John,
 > 
 > Since you have done some changes with respect to the setting of port
 > speed in boot0sio, I'd appreciate if you could have a look at this PR.
 > It looks to me like we are really passing a wrong value to bioscom,
 > causing the speed to never be set (even when COMSPEED == 0).
 > 
 > The fix is simple (see patch in PR), but I'd rather have at least a
 > second pair of eyeballs on it before checking it in.
 > 
 > Thanks!
 > Thomas.
 
 The fix is correct.  That's twice now I've screwed that up (see the cdboot 
 twiddle fix recently).  :(
 
 -- 
 John Baldwin
State-Changed-From-To: open->patched 
State-Changed-By: thomas 
State-Changed-When: Mon Mar 26 21:57:09 UTC 2007 
State-Changed-Why:  
Patch committed to HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110828 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: i386/110828: commit references a PR
Date: Mon, 26 Mar 2007 21:56:23 +0000 (UTC)

 thomas      2007-03-26 21:56:13 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/boot/i386/boot0  boot0.S 
   Log:
   Fix setting of serial port speed. A junk value was passed in AX when
   bioscom is called to set up serial port parameters because COMSPEED
   was treated as an address instead of an immediate value, causing
   serial port parameters to never be set.
   
   PR:             i386/110828
   Reviewed by:    jhb
   MFC after:      2 weeks
   
   Revision  Changes    Path
   1.16      +1 -1      src/sys/boot/i386/boot0/boot0.S
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Thomas Quinot <thomas@FreeBSD.ORG>
To: John Baldwin <jhb@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: i386/110828: boot0sio never sets port speed
Date: Mon, 26 Mar 2007 23:56:53 +0200

 * John Baldwin, 2007-03-26 :
 
 > The fix is correct.  That's twice now I've screwed that up (see the cdboot 
 > twiddle fix recently).  :(
 
 Thanks for the review! I've committed the patch.
 
 Thomas.
 
State-Changed-From-To: patched->closed 
State-Changed-By: thomas 
State-Changed-When: Wed Apr 11 07:19:51 UTC 2007 
State-Changed-Why:  
Patch MFC'd to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110828 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: i386/110828: commit references a PR
Date: Wed, 11 Apr 2007 07:19:42 +0000 (UTC)

 thomas      2007-04-11 07:19:36 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/boot/i386/boot0  boot0.S 
   Log:
   MFC rev. 1.16:
   Fix setting of serial port speed. A junk value was passed in AX when
   bioscom is called to set up serial port parameters because COMSPEED
   was treated as an address instead of an immediate value, causing
   serial port parameters to never be set.
   
   PR:     i386/110828
   
   Revision  Changes    Path
   1.14.2.2  +1 -1      src/sys/boot/i386/boot0/boot0.S
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
