From nobody@FreeBSD.org  Mon Jan 15 08:24:14 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9F0B216A4C8
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 15 Jan 2007 08:24:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 8FB6813C4C9
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 15 Jan 2007 08:24:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l0F8O9o3026182
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 15 Jan 2007 08:24:09 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l0F8O9AQ026164;
	Mon, 15 Jan 2007 08:24:09 GMT
	(envelope-from nobody)
Message-Id: <200701150824.l0F8O9AQ026164@www.freebsd.org>
Date: Mon, 15 Jan 2007 08:24:09 GMT
From: Yuxiang Luo<fedora@ercist.iscas.ac.cn>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Forget to unlock mutex-locks
X-Send-Pr-Version: www-3.0

>Number:         107943
>Category:       i386
>Synopsis:       Forget to unlock mutex-locks
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-i386
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 15 08:30:21 GMT 2007
>Closed-Date:    Tue Feb 13 01:01:34 GMT 2007
>Last-Modified:  Wed Aug 22 14:50:01 GMT 2007
>Originator:     Yuxiang Luo
>Release:        6.0 stable
>Organization:
Institute of Software, Chinese Academy of Sciences
>Environment:
FreeBSD Earth.Earth 6.0-RELEASE FreeBSD 6.0-RELEASE #2: Tue Feb 28 02:32:45 UTC 2006     root@guhao.fsd.iscas:/usr/obj/usr/src/sys/CAS-EARTH  i386
>Description:
These two bugs, exiting with mutex-lock holded, are detected by a static
analyzer we are developing.
One of them are caused by GOTO statement.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

*** aac_cam.c	Wed Jul 26 07:46:00 2006
--- aac_cam_new.c	Mon Jan 15 15:49:41 2007
***************
*** 571,576 ****
--- 571,577 ----
  		device_printf(sc->aac_dev,"Error %d sending ResetBus command\n",
  		    e);
  		aac_release_sync_fib(sc);
+ 		mtx_unlock(&sc->aac_io_lock);
  		return (CAM_REQ_ABORTED);
  	}
  

>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: i386/107943: commit references a PR
Date: Mon, 15 Jan 2007 16:22:28 +0000 (UTC)

 scottl      2007-01-15 16:22:20 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/aac          aac_cam.c 
   Log:
   Add a missing mutex unlock to an error path.
   
   Submitted by: Yuxiang Luo
   PR: 107943
   
   Revision  Changes    Path
   1.26      +1 -0      src/sys/dev/aac/aac_cam.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Feb 13 01:01:11 UTC 2007 
State-Changed-Why:  
Fix committed by scottl on 1/15/2007.  Thanks for the submission. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107943 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: i386/107943: commit references a PR
Date: Wed, 22 Aug 2007 14:46:38 +0000 (UTC)

 emaste      2007-08-22 14:46:28 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/dev/aac          aac_cam.c 
   Log:
   MFC aac_cam.c 1.26:
     Add a missing mutex unlock to an error path.
   
     Submitted by: Yuxiang Luo
     PR: 107943
   
   Revision  Changes    Path
   1.20.2.4  +1 -0      src/sys/dev/aac/aac_cam.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
