From ybbkaz@yahoo.co.jp  Sun Feb 19 16:49:09 2006
Return-Path: <ybbkaz@yahoo.co.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 907CF16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 19 Feb 2006 16:49:09 +0000 (GMT)
	(envelope-from ybbkaz@yahoo.co.jp)
Received: from ybbsmtp17.mail.tnz.yahoo.co.jp (ybbsmtp17.mail.tnz.yahoo.co.jp [203.216.228.247])
	by mx1.FreeBSD.org (Postfix) with SMTP id EAD8043D48
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 19 Feb 2006 16:49:08 +0000 (GMT)
	(envelope-from ybbkaz@yahoo.co.jp)
Received: (qmail 15846 invoked by alias); 19 Feb 2006 16:49:07 -0000
Received: from unknown (HELO eyes.violasystem.net) (219.0.96.106 with poptime)
  by ybbsmtp17.mail.tnz.yahoo.co.jp with SMTP; 19 Feb 2006 16:49:07 -0000
Received: from eyes.violasystem.net (localhost [127.0.0.1])
	by eyes.violasystem.net (8.13.4/8.13.4) with ESMTP id k1JGkhVl009261
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 20 Feb 2006 01:46:43 +0900 (JST)
	(envelope-from ybbkaz@yahoo.co.jp)
Received: (from kazuaki@localhost)
	by eyes.violasystem.net (8.13.4/8.13.4/Submit) id k1JGkfFH009260;
	Mon, 20 Feb 2006 01:46:41 +0900 (JST)
	(envelope-from ybbkaz@yahoo.co.jp)
Message-Id: <200602191646.k1JGkfFH009260@eyes.violasystem.net>
Date: Mon, 20 Feb 2006 01:46:41 +0900 (JST)
From: Kazuaki Oda <ybbkaz@yahoo.co.jp>
Reply-To: Kazuaki Oda <ybbkaz@yahoo.co.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] sort(1): numeric sort is broken on multi-byte locales
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         93566
>Category:       gnu
>Synopsis:       [patch] sort(1): numeric sort is broken on multi-byte locales
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 19 16:50:03 GMT 2006
>Closed-Date:    
>Last-Modified:  Fri Mar 09 00:40:25 GMT 2007
>Originator:     Kazuaki Oda
>Release:        FreeBSD 6.1-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD eyes.violasystem.net 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #0: Sat Feb 18 00:16:19 JST 2006 kazuaki@eyes.violasystem.net:/usr/obj/usr/src/sys/EYES i386


	
>Description:
	If you run the following command:
	% ls -l /usr/bin | env LANG=ja_JP.eucJP sort -n -k 5
	Probably you get wrong result.
	It is not sorted by fifth column correctly.
	If you run:
	% ls -l /usr/bin | env LANG=C sort -n -k 5
	The result is OK.
>How-To-Repeat:
	
>Fix:

	Blank characters are skipped at the top of numcompare() function.
	But in case of MB_CUR_MAX > 1, more than MB_LEN_MAX characters are not
	skipped.
	MB_LEN_MAX is 6 (defined in /usr/include/limits.h).
	So if you have more than 6 blank characters, you can get wrong result.

	The following patch resolves this problem.

--- sort.c.patch begins here ---
--- contrib/gnu-sort/src/sort.c.orig	Thu Aug 12 14:46:04 2004
+++ contrib/gnu-sort/src/sort.c	Sun Feb 19 23:22:49 2006
@@ -1450,8 +1450,8 @@
   if (MB_CUR_MAX > 1)
     {
       size_t mblength;
-      size_t alen = strnlen (a, MB_LEN_MAX);
-      size_t blen = strnlen (b, MB_LEN_MAX);
+      size_t alen = strlen (a);
+      size_t blen = strlen (b);
 
       while (ismbblank (a, alen, &mblength))
 	a += mblength, alen -= mblength;
--- sort.c.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->tjr 
Responsible-Changed-By: ache 
Responsible-Changed-When: Tue Feb 21 20:54:35 UTC 2006 
Responsible-Changed-Why:  
To our multibyte guru 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93566 
Responsible-Changed-From-To: tjr->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Mar 9 00:40:02 UTC 2007 
Responsible-Changed-Why:  
tjr has returned his commit bit for safekeeping. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93566 
>Unformatted:
