From marcolz@serv4.ilse.nl  Tue Apr 24 17:21:10 2001
Return-Path: <marcolz@serv4.ilse.nl>
Received: from newage.l3.ilse.nl (newage.l3.ilse.nl [212.72.39.210])
	by hub.freebsd.org (Postfix) with ESMTP id 1DD1637B424
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 24 Apr 2001 17:21:09 -0700 (PDT)
	(envelope-from marcolz@serv4.ilse.nl)
Received: from serv4.ilse.nl (serv4.ilse.nl [212.189.131.14])
	by newage.l3.ilse.nl (8.11.0/8.10.2) with ESMTP id f3P0L3J41358;
	Wed, 25 Apr 2001 02:21:04 +0200 (MEST)
Received: (from marcolz@localhost)
	by serv4.ilse.nl (8.11.3/8.11.1) id f3P0L2718571;
	Wed, 25 Apr 2001 02:21:02 +0200 (CEST)
	(envelope-from marcolz)
Message-Id: <200104250021.f3P0L2718571@serv4.ilse.nl>
Date: Wed, 25 Apr 2001 02:21:02 +0200 (CEST)
From: marcolz@ilse.nl
Reply-To: marcolz@ilse.nl
To: FreeBSD-gnats-submit@freebsd.org
Cc: sys@ilse.nl
Subject: gcc warning about strftime's '%+'
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         26827
>Category:       gnu
>Synopsis:       gcc doesn't know about '%+' in formatstring of strftime()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 24 17:30:01 PDT 2001
>Closed-Date:    Fri May 25 12:01:52 PDT 2001
>Last-Modified:  Fri May 25 12:02:01 PDT 2001
>Originator:     Marc Olzheim
>Release:        FreeBSD 4.3-RC i386
>Organization:
ilse technology
>Environment:
System: FreeBSD serv4.ilse.nl 4.3-RC FreeBSD 4.3-RC #0: Thu Apr 19 10:48:44 CEST 2001 marcolz@serv4.ilse.nl:/usr/src/sys/compile/serv4 i386


	
>Description:
gcc warns when using '%+' in a formatstring when using strftime(), although
libc knows it.
>How-To-Repeat:
Any piece of code containing something like
strftime(buffer, sizeof(buffer), "%+", localtime(&(sb.st_mtime)));
compiled with with -Wall
>Fix:
--- /usr/src/contrib/gcc/c-common.c	Wed Apr 25 02:03:07 2001
+++ /usr/src/contrib/gcc/c-common.c	Wed Apr 25 02:05:37 2001
@@ -1155,7 +1155,7 @@
   { "D", 		0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "2" },
   { "g", 		0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "2O-_0w" },
   { "cx", 		0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "3E" },
-  { "%RTXnrt",		0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "" },
+  { "%+RTXnrt",		0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "" },
   { "P",		0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "G" },
   { "HIMSUWdemw",	0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "-_0Ow" },
   { "Vju",		0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, "-_0Oow" },
>Release-Note:
>Audit-Trail:

From: Dima Dorfman <dima@unixfreak.org>
To: marcolz@ilse.nl
Cc: FreeBSD-gnats-submit@freebsd.org, sys@ilse.nl
Subject: Re: gnu/26827: gcc warning about strftime's '%+' 
Date: Tue, 24 Apr 2001 17:33:13 -0700

 marcolz@ilse.nl writes:
 > 
 > >Number:         26827
 > >Category:       gnu
 > >Synopsis:       gcc doesn't know about '%+' in formatstring of strftime()
 > >Description:
 > gcc warns when using '%+' in a formatstring when using strftime(), although
 > libc knows it.
 
 Is "%+" a FreeBSDism?  If it isn't, this should probably be sent to
 the GCC folks.

From: Marc Olzheim <marcolz@ilse.nl>
To: Dima Dorfman <dima@unixfreak.org>
Cc: marcolz@ilse.nl, FreeBSD-gnats-submit@freebsd.org, sys@ilse.nl
Subject: Re: gnu/26827: gcc warning about strftime's '%+'
Date: Wed, 25 Apr 2001 02:41:16 +0200

 > Is "%+" a FreeBSDism?  If it isn't, this should probably be sent to
 > the GCC folks.
 
 Hmmm.. I don't know... Linux has it in glibc2, but does not support it...
 
 Marc
Responsible-Changed-From-To: freebsd-bugs->obrien 
Responsible-Changed-By: dd 
Responsible-Changed-When: Sat Apr 28 20:05:10 PDT 2001 
Responsible-Changed-Why:  
Over to in-tree gcc maintainer, who should know (where to find out) if 
'%+' is a FreeBSDism. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=26827 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Fri May 25 12:01:52 PDT 2001 
State-Changed-Why:  
committed, thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=26827 
>Unformatted:
