From roberto@keltia.freenix.fr  Sun Oct 13 12:06:14 1996
Received: from mexico.brainstorm.eu.org (root@mexico.brainstorm.eu.org [193.56.58.253])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id MAA01228
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Oct 1996 12:06:07 -0700 (PDT)
Received: from brasil.brainstorm.eu.org (brasil.brainstorm.eu.org [193.56.58.33]) by mexico.brainstorm.eu.org (8.7.5/8.7.3) with ESMTP id UAA15794 for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Oct 1996 20:05:55 +0100
Received: (from uucp@localhost) by brasil.brainstorm.eu.org (8.6.12/8.6.12) with UUCP id VAA27387 for FreeBSD-gnats-submit@freebsd.org; Sun, 13 Oct 1996 21:05:34 +0200
Received: (from roberto@localhost) by keltia.freenix.fr (8.8.0/keltia-uucp-2.9) id VAA10998; Sun, 13 Oct 1996 21:05:24 +0200 (MET DST)
Message-Id: <199610131905.VAA10998@keltia.freenix.fr>
Date: Sun, 13 Oct 1996 21:05:24 +0200 (MET DST)
From: Ollivier Robert <roberto@keltia.freenix.fr>
Reply-To: roberto@keltia.freenix.fr
To: FreeBSD-gnats-submit@freebsd.org
Subject: /usr/bin/patch doesn't like Index: lines
X-Send-Pr-Version: 3.2

>Number:         1787
>Category:       gnu
>Synopsis:       Diffs with Index: lines are not honored for new files
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    markm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 13 12:10:00 PDT 1996
>Closed-Date:    Sun Mar 22 20:41:57 PST 1998
>Last-Modified:  Sun Mar 22 20:45:27 PST 1998
>Originator:     Ollivier Robert
>Release:        FreeBSD 2.2-961004-SNAP i386
>Organization:
Usenet Canal Historique
>Environment:

Not really relevant

>Description:

When one uses /usr/bin/patch to bring perl5.003_05 up to perl5.003_07 with
the diffs, new files are created in the current directory instead of the
right place specified by both the "***/---" lines and the "Index:" line.

patch-2.1.tar.gz from any GNU mirror sites doesn't have the problem.

>How-To-Repeat:

Get perl5.003_05.tar.gz from CPAN
Get perl5.003_06.pat.gz and perl5.003_07.pat.gz from CPAN as well and try
to apply them. Configure will note that the files are missing and yell.

>Fix:
	
Maybe update our patch or re-import patch-2.1 in contrib.


>Release-Note:
>Audit-Trail:

From: Mark Murray <mark@grondar.za>
To: roberto@keltia.freenix.fr
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: gnu/1787: /usr/bin/patch doesn't like Index: lines 
Date: Sun, 13 Oct 1996 22:27:01 +0200

 Ollivier Robert wrote:
 > >Description:
 > 
 > When one uses /usr/bin/patch to bring perl5.003_05 up to perl5.003_07 with
 > the diffs, new files are created in the current directory instead of the
 > right place specified by both the "***/---" lines and the "Index:" line.
 > 
 > patch-2.1.tar.gz from any GNU mirror sites doesn't have the problem.
 
 I fixed a related problem in our patch where if multiple files of
 the same name are all being patched (like if you are patching all
 the "Makefile"s in a subtree), then patch screwed up and tried to
 patch the file in the current directoryMultiple times. IIRC, the
 problem was one of priorities in the file pch.c - the man page said
 Index: was the highest, and I cant remember the rest offhand. I'll
 look further in the next day or so...
 
 M
 --
 Mark Murray
 46 Harvey Rd, Claremont, Cape Town 7700, South Africa
 +27 21 61-3768 GMT+0200
 Finger mark@grondar.za for PGP key

From: Mark Murray <mark@grondar.za>
To: roberto@keltia.freenix.fr
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: gnu/1787: /usr/bin/patch doesn't like Index: lines 
Date: Mon, 14 Oct 1996 21:08:49 +0200

 > Get perl5.003_05.tar.gz from CPAN
 > Get perl5.003_06.pat.gz and perl5.003_07.pat.gz from CPAN as well and try
 > to apply them. Configure will note that the files are missing and yell.
 
 Oh, boy. This one is nasty.
 
 Here is what I can find so far:
 
 The problem occurs when a file is being created and there is a
 shortened Index: line. This interacts badly with the -p1 option
 required by the patch. (patch -x128 ... is very useful, btw)
 
 This is how it is:
 
 Index: pod/perli18n.pod
 *** /dev/null
 --- perl003_04/pod/perli18n.pod
 <patch stuff>
 :
 :
 
 The -p1 option cuts off the pod/ on the Index: line. This one has me
 slightly stumped: The man pages suggest that Index: has the priority,
 and my experience with "cvs diff" suggest that this is A Good Thing (tm).
 All I can conclude is that the above patch is "bug-compatible" with the
 old patch, or am I missing something here? Should the -p option _not_
 apply to Index: lines? Suggestions?
 
 M
 --
 Mark Murray
 46 Harvey Rd, Claremont, Cape Town 7700, South Africa
 +27 21 61-3768 GMT+0200
 Finger mark@grondar.za for PGP key
Responsible-Changed-From-To: freebsd-bugs->markm 
Responsible-Changed-By: mpp 
Responsible-Changed-When: Fri Feb 21 17:54:17 PST 1997 
Responsible-Changed-Why:  
MArk has done some followup on this pr. 
State-Changed-From-To: open->closed 
State-Changed-By: hoek 
State-Changed-When: Sun Mar 22 20:41:57 PST 1998 
State-Changed-Why:  
OCFC (Originator Confirmed Fixed and Closable) 

This, of course, was loudly fixed during the recent patch(1) ruckus. 
>Unformatted:
