From nobody@FreeBSD.org  Sat Sep  6 06:05:10 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD6A31065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  6 Sep 2008 06:05:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A98438FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  6 Sep 2008 06:05:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m8665ANF042351
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 6 Sep 2008 06:05:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m8665Aaf042350;
	Sat, 6 Sep 2008 06:05:10 GMT
	(envelope-from nobody)
Message-Id: <200809060605.m8665Aaf042350@www.freebsd.org>
Date: Sat, 6 Sep 2008 06:05:10 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Typo in tree-nested.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         127136
>Category:       gnu
>Synopsis:       gcc(1): Typo in tree-nested.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    uqs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 06 06:10:01 UTC 2008
>Closed-Date:    Tue Aug 02 09:06:39 UTC 2011
>Last-Modified:  Tue Aug  2 09:10:13 UTC 2011
>Originator:     Henning Petersen
>Release:        
>Organization:
>Environment:
>Description:
Line 753 in tree-nested.c is

if (variably_modified_type_p ( TREE_TYPE(args),0, orig_fndecl)

change to


if (variably_modified_type_p ( TREE_TYPE(args), orig_fndecl)
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->uqs 
Responsible-Changed-By: uqs 
Responsible-Changed-When: Tue Jun 28 18:22:19 UTC 2011 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=127136 
State-Changed-From-To: open->patched 
State-Changed-By: uqs 
State-Changed-When: Fri Jul 1 20:46:19 UTC 2011 
State-Changed-Why:  
Patched in head 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127136 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: gnu/127136: commit references a PR
Date: Fri,  1 Jul 2011 20:46:10 +0000 (UTC)

 Author: uqs
 Date: Fri Jul  1 20:45:55 2011
 New Revision: 223715
 URL: http://svn.freebsd.org/changeset/base/223715
 
 Log:
   - Fix typo in check_for_nested_with_variably_modified present
   - Implement -Wvariable-decl.
   - Port -Wtrampolines support from gcc3.
   (all three also via OpenBSD)
   
   PR:		gnu/127136, gnu/157019
   Submitted by:	Henning Petersen, Pedro Giffuni
   MFC after:	6 weeks
 
 Modified:
   head/contrib/gcc/c-decl.c
   head/contrib/gcc/c.opt
   head/contrib/gcc/common.opt
   head/contrib/gcc/tree-nested.c
 
 Modified: head/contrib/gcc/c-decl.c
 ==============================================================================
 --- head/contrib/gcc/c-decl.c	Fri Jul  1 19:23:25 2011	(r223714)
 +++ head/contrib/gcc/c-decl.c	Fri Jul  1 20:45:55 2011	(r223715)
 @@ -4340,6 +4340,8 @@ grokdeclarator (const struct c_declarato
  			  pedwarn ("ISO C90 forbids variable-size array %qs",
  				   name);
  		      }
 +		    if (warn_variable_decl)
 +		      warning (0, "variable-sized array %qs", name);
  		  }
  
  		if (integer_zerop (size))
 
 Modified: head/contrib/gcc/c.opt
 ==============================================================================
 --- head/contrib/gcc/c.opt	Fri Jul  1 19:23:25 2011	(r223714)
 +++ head/contrib/gcc/c.opt	Fri Jul  1 20:45:55 2011	(r223715)
 @@ -404,6 +404,10 @@ Wtraditional
  C ObjC Var(warn_traditional)
  Warn about features not present in traditional C
  
 +Wtrampolines
 +Common Var(warn_trampolines)
 +Warn when trampolines are emitted
 +
  Wtrigraphs
  C ObjC C++ ObjC++
  Warn if trigraphs are encountered that might affect the meaning of the program
 
 Modified: head/contrib/gcc/common.opt
 ==============================================================================
 --- head/contrib/gcc/common.opt	Fri Jul  1 19:23:25 2011	(r223714)
 +++ head/contrib/gcc/common.opt	Fri Jul  1 20:45:55 2011	(r223715)
 @@ -189,6 +189,10 @@ Wunused-variable
  Common Var(warn_unused_variable)
  Warn when a variable is unused
  
 +Wvariable-decl
 +Common Var(warn_variable_decl)
 +Warn about variable-sized declarations.
 +
  Wvolatile-register-var
  Common Var(warn_register_var)
  Warn when a register variable is declared volatile
 
 Modified: head/contrib/gcc/tree-nested.c
 ==============================================================================
 --- head/contrib/gcc/tree-nested.c	Fri Jul  1 19:23:25 2011	(r223714)
 +++ head/contrib/gcc/tree-nested.c	Fri Jul  1 20:45:55 2011	(r223715)
 @@ -750,7 +750,7 @@ check_for_nested_with_variably_modified 
    for (cgn = cgn->nested; cgn ; cgn = cgn->next_nested)
      {
        for (arg = DECL_ARGUMENTS (cgn->decl); arg; arg = TREE_CHAIN (arg))
 -	if (variably_modified_type_p (TREE_TYPE (arg), 0), orig_fndecl)
 +	if (variably_modified_type_p (TREE_TYPE (arg), orig_fndecl))
  	  return true;
  
        if (check_for_nested_with_variably_modified (cgn->decl, orig_fndecl))
 @@ -1621,6 +1621,10 @@ convert_tramp_reference (tree *tp, int *
  	 it doesn't need a trampoline.  */
        if (DECL_NO_STATIC_CHAIN (decl))
  	break;
 +      if (warn_trampolines)
 +	{
 +	warning(0, "local function address taken needing trampoline generation");
 +	}
  
        /* Lookup the immediate parent of the callee, as that's where
  	 we need to insert the trampoline.  */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: uqs 
State-Changed-When: Tue Aug 2 09:06:13 UTC 2011 
State-Changed-Why:  
Merged to stable/8, thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127136 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: gnu/127136: commit references a PR
Date: Tue,  2 Aug 2011 09:06:13 +0000 (UTC)

 Author: uqs
 Date: Tue Aug  2 09:06:04 2011
 New Revision: 224600
 URL: http://svn.freebsd.org/changeset/base/224600
 
 Log:
   MFH r223715
   
   - Fix typo in check_for_nested_with_variably_modified
   - Implement -Wvariable-decl.
   - Port -Wtrampolines support from gcc3.
       (all three also via OpenBSD)
   
   PR:		gnu/127136, gnu/157019
   Submitted by:	Henning Petersen, Pedro Giffuni
 
 Modified:
   stable/8/contrib/gcc/c-decl.c
   stable/8/contrib/gcc/c.opt
   stable/8/contrib/gcc/common.opt
   stable/8/contrib/gcc/tree-nested.c
 Directory Properties:
   stable/8/contrib/gcc/   (props changed)
 
 Modified: stable/8/contrib/gcc/c-decl.c
 ==============================================================================
 --- stable/8/contrib/gcc/c-decl.c	Tue Aug  2 08:31:23 2011	(r224599)
 +++ stable/8/contrib/gcc/c-decl.c	Tue Aug  2 09:06:04 2011	(r224600)
 @@ -4340,6 +4340,8 @@ grokdeclarator (const struct c_declarato
  			  pedwarn ("ISO C90 forbids variable-size array %qs",
  				   name);
  		      }
 +		    if (warn_variable_decl)
 +		      warning (0, "variable-sized array %qs", name);
  		  }
  
  		if (integer_zerop (size))
 
 Modified: stable/8/contrib/gcc/c.opt
 ==============================================================================
 --- stable/8/contrib/gcc/c.opt	Tue Aug  2 08:31:23 2011	(r224599)
 +++ stable/8/contrib/gcc/c.opt	Tue Aug  2 09:06:04 2011	(r224600)
 @@ -404,6 +404,10 @@ Wtraditional
  C ObjC Var(warn_traditional)
  Warn about features not present in traditional C
  
 +Wtrampolines
 +Common Var(warn_trampolines)
 +Warn when trampolines are emitted
 +
  Wtrigraphs
  C ObjC C++ ObjC++
  Warn if trigraphs are encountered that might affect the meaning of the program
 
 Modified: stable/8/contrib/gcc/common.opt
 ==============================================================================
 --- stable/8/contrib/gcc/common.opt	Tue Aug  2 08:31:23 2011	(r224599)
 +++ stable/8/contrib/gcc/common.opt	Tue Aug  2 09:06:04 2011	(r224600)
 @@ -189,6 +189,10 @@ Wunused-variable
  Common Var(warn_unused_variable)
  Warn when a variable is unused
  
 +Wvariable-decl
 +Common Var(warn_variable_decl)
 +Warn about variable-sized declarations.
 +
  Wvolatile-register-var
  Common Var(warn_register_var)
  Warn when a register variable is declared volatile
 
 Modified: stable/8/contrib/gcc/tree-nested.c
 ==============================================================================
 --- stable/8/contrib/gcc/tree-nested.c	Tue Aug  2 08:31:23 2011	(r224599)
 +++ stable/8/contrib/gcc/tree-nested.c	Tue Aug  2 09:06:04 2011	(r224600)
 @@ -750,7 +750,7 @@ check_for_nested_with_variably_modified 
    for (cgn = cgn->nested; cgn ; cgn = cgn->next_nested)
      {
        for (arg = DECL_ARGUMENTS (cgn->decl); arg; arg = TREE_CHAIN (arg))
 -	if (variably_modified_type_p (TREE_TYPE (arg), 0), orig_fndecl)
 +	if (variably_modified_type_p (TREE_TYPE (arg), orig_fndecl))
  	  return true;
  
        if (check_for_nested_with_variably_modified (cgn->decl, orig_fndecl))
 @@ -1621,6 +1621,10 @@ convert_tramp_reference (tree *tp, int *
  	 it doesn't need a trampoline.  */
        if (DECL_NO_STATIC_CHAIN (decl))
  	break;
 +      if (warn_trampolines)
 +	{
 +	warning(0, "local function address taken needing trampoline generation");
 +	}
  
        /* Lookup the immediate parent of the callee, as that's where
  	 we need to insert the trampoline.  */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
