From nobody@FreeBSD.org  Tue Jan 23 00:59:01 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 74E8D16A401
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Jan 2007 00:59:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 663E413C4BF
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Jan 2007 00:59:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l0N0x1uV047146
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Jan 2007 00:59:01 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l0N0x1c9047145;
	Tue, 23 Jan 2007 00:59:01 GMT
	(envelope-from nobody)
Message-Id: <200701230059.l0N0x1c9047145@www.freebsd.org>
Date: Tue, 23 Jan 2007 00:59:01 GMT
From: Jessica Han<jessicah@juniper.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Infinite loop with kgdb while debugging mis-match kernel/core
X-Send-Pr-Version: www-3.0

>Number:         108229
>Category:       gnu
>Synopsis:       Infinite loop with kgdb while debugging mis-match kernel/core
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rodrigc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 23 01:00:36 GMT 2007
>Closed-Date:    Fri Feb 02 13:49:07 GMT 2007
>Last-Modified:  Fri Feb  2 13:50:11 GMT 2007
>Originator:     Jessica Han
>Release:        FreeBSD 6.1-RELEASE
>Organization:
Juniper Networks
>Environment:
i386
>Description:
I got an infinite loop while trying to debug a kernel core on FreeBSD 6.1, note that I happened to be debugging a wrong "kernel" binary for the core dump. 
# uname -sr
 FreeBSD 6.1-RELEASE
#kgdb kernel vmcore.0
kgdb: kvm_read: invalid address (0x50012)
kgdb: kvm_read: invalid address (0x7)
kgdb: kvm_read: invalid address (0xf5c)
kgdb: kvm_read: invalid address (0xf5c)
kgdb: kvm_read: invalid address (0xf5c)


 
 I've got a patch to fix it, can somebody review and commit it if it is okay? Thanks,

Jessica

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- /6.1-vanila/src/gnu/usr.bin/gdb/kgdb/kthr.c	Wed Sep 14 22:32:10 2005
+++ gnu/usr.bin/gdb/kgdb/kthr.c	Thu Nov 16 12:37:41 2006
@@ -92,12 +92,16 @@
 		dumptid = -1;
 
 	while (paddr != 0) {
-		if (kvm_read(kvm, paddr, &p, sizeof(p)) != sizeof(p))
+		if (kvm_read(kvm, paddr, &p, sizeof(p)) != sizeof(p)) {
 			warnx("kvm_read: %s", kvm_geterr(kvm));
+			break;
+		}
 		addr = (uintptr_t)TAILQ_FIRST(&p.p_threads);
 		while (addr != 0) {
-			if (kvm_read(kvm, addr, &td, sizeof(td)) != sizeof(td))
+			if (kvm_read(kvm, addr, &td, sizeof(td)) != sizeof(td)) {
 				warnx("kvm_read: %s", kvm_geterr(kvm));
+				break;
+			}
 			kt = malloc(sizeof(*kt));
 			kt->next = first;
 			kt->kaddr = addr;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rodrigc 
Responsible-Changed-By: rodrigc 
Responsible-Changed-When: Tue Jan 23 03:33:22 UTC 2007 
Responsible-Changed-Why:  
Grabbing 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108229 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: gnu/108229: commit references a PR
Date: Thu, 25 Jan 2007 06:39:44 +0000 (UTC)

 rodrigc     2007-01-25 06:39:25 UTC
 
   FreeBSD src repository
 
   Modified files:
     gnu/usr.bin/gdb/kgdb kthr.c 
   Log:
   Try to avoid a possible infinite loop when parsing an invalid kernel dump file.
   
   PR:             108229
   Submitted by:   Jessica Han <jessicah juniper net>
   Reviewed by:    marcel
   MFC after:      1 week
   
   Revision  Changes    Path
   1.6       +7 -2      src/gnu/usr.bin/gdb/kgdb/kthr.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: rodrigc 
State-Changed-When: Fri Feb 2 13:48:45 UTC 2007 
State-Changed-Why:  
Committed to HEAD and RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108229 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: gnu/108229: commit references a PR
Date: Fri,  2 Feb 2007 13:48:37 +0000 (UTC)

 rodrigc     2007-02-02 13:48:20 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     gnu/usr.bin/gdb/kgdb kthr.c 
   Log:
   MFC 1.6:
     Try to avoid a possible infinite loop when parsing an invalid
     kernel dump file.
   
     PR:             108229
     Submitted by:   Jessica Han <jessicah juniper net>
   
   Revision  Changes    Path
   1.2.2.3   +7 -2      src/gnu/usr.bin/gdb/kgdb/kthr.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
