From dawes@rf900.physics.usyd.edu.au Fri Mar 19 00:52:28 1999
Return-Path: <dawes@rf900.physics.usyd.edu.au>
Received: from rf900.physics.usyd.edu.au (rf900.physics.usyd.edu.au [129.78.129.109])
	by hub.freebsd.org (Postfix) with ESMTP id 664D814F94
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 19 Mar 1999 00:52:22 -0800 (PST)
	(envelope-from dawes@rf900.physics.usyd.edu.au)
Received: (from dawes@localhost)
	by rf900.physics.usyd.edu.au (8.9.1a/8.9.1) id TAA10740;
	Fri, 19 Mar 1999 19:52:02 +1100 (EST)
Message-Id: <199903190852.TAA10740@rf900.physics.usyd.edu.au>
Date: Fri, 19 Mar 1999 19:52:02 +1100 (EST)
From: dawes@xfree86.org
Sender: dawes@rf900.physics.usyd.edu.au
Reply-To: dawes@xfree86.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: cvs doesn't allow digits in local keywords
X-Send-Pr-Version: 3.2

>Number:         10670
>Category:       gnu
>Synopsis:       cvs doesn't allow digits in local keywords
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    peter
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 19 01:00:01 PST 1999
>Closed-Date:    Wed Sep 14 18:39:06 UTC 2011
>Last-Modified:  Wed Sep 14 18:39:06 UTC 2011
>Originator:     David Dawes
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
The XFree86 Project
>Environment:

Any current release from the active branches

>Description:

The XFree86 source uses a local RCS keyword "$XFree86$".  FreeBSD's
version of cvs has support for expanding local RCS keywords, but the
code that checks for them only allows them to contain alpha characters.
Although this is only an issue for XFree86 developers, changing the
behaviour to also allow numerical characters will make it possible for
them to use the FreeBSD version of cvs.

>How-To-Repeat:

Create a $CVSROOT/CVSROOT/options file like:

tag=XFree86=CVSHeader

check out a file with a $XFree86$ line, and note that it isn't expanded.

>Fix:
	
The following patch fixes this:

Index: rcs.c
===================================================================
RCS file: /home/cvs/src/contrib/cvs/src/rcs.c,v
retrieving revision 1.16
diff -u -r1.16 rcs.c
--- rcs.c	1998/03/11 09:30:51	1.16
+++ rcs.c	1999/03/19 08:37:55
@@ -3126,7 +3126,7 @@
 	/* Look for the first non alphabetic character after the '$'.  */
 	send = srch + srch_len;
 	for (s = srch; s < send; s++)
-	    if (! isalpha (*s))
+	    if (! isalnum (*s))
 		break;
 
 	/* If the first non alphabetic character is not '$' or ':',



>Release-Note:
>Audit-Trail:

From: dawes@xfree86.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: gnu/10670: cvs doesn't allow digits in local keywords
Date: Fri, 19 Mar 1999 19:52:02 +1100 (EST)

 >Number:         10670
 >Category:       gnu
 >Synopsis:       cvs doesn't allow digits in local keywords
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       low
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          change-request
 >Submitter-Id:   current-users
 >Arrival-Date:   Fri Mar 19 01:00:01 PST 1999
 >Closed-Date:
 >Last-Modified:
 >Originator:     David Dawes
 >Release:        FreeBSD 4.0-CURRENT i386
 >Organization:
 The XFree86 Project
 >Environment:
 
 Any current release from the active branches
 
 >Description:
 
 The XFree86 source uses a local RCS keyword "$XFree86$".  FreeBSD's
 version of cvs has support for expanding local RCS keywords, but the
 code that checks for them only allows them to contain alpha characters.
 Although this is only an issue for XFree86 developers, changing the
 behaviour to also allow numerical characters will make it possible for
 them to use the FreeBSD version of cvs.
 
 >How-To-Repeat:
 
 Create a $CVSROOT/CVSROOT/options file like:
 
 tag=XFree86=CVSHeader
 
 check out a file with a $XFree86$ line, and note that it isn't expanded.
 
 >Fix:
 	
 The following patch fixes this:
 
 Index: rcs.c
 ===================================================================
 RCS file: /home/cvs/src/contrib/cvs/src/rcs.c,v
 retrieving revision 1.16
 diff -u -r1.16 rcs.c
 --- rcs.c	1998/03/11 09:30:51	1.16
 +++ rcs.c	1999/03/19 08:37:55
 @@ -3126,7 +3126,7 @@
  	/* Look for the first non alphabetic character after the '$'.  */
  	send = srch + srch_len;
  	for (s = srch; s < send; s++)
 -	    if (! isalpha (*s))
 +	    if (! isalnum (*s))
  		break;
  
  	/* If the first non alphabetic character is not '$' or ':',
 
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 
 
 To Unsubscribe: send mail to majordomo@FreeBSD.org
 with "unsubscribe freebsd-bugs" in the body of the message
 
 
 
 
Responsible-Changed-From-To: freebsd-bugs->peter 
Responsible-Changed-By: johan 
Responsible-Changed-When: Thu May 9 20:01:03 PDT 2002 
Responsible-Changed-Why:  
Over to peter - our cvs maintainer? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=10670 
State-Changed-From-To: open->closed 
State-Changed-By: peter 
State-Changed-When: Wed Sep 14 18:38:24 UTC 2011 
State-Changed-Why:  
Sorry, this code is in an undead state in our tree and 
will likely be removed entirely before getting fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=10670 
>Unformatted:
