From nobody@FreeBSD.org  Wed Mar 29 00:01:33 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5D9E516A5D4
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 Mar 2006 00:01:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C5F2744220
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Mar 2006 23:39:29 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k2SNdTl4024016
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Mar 2006 23:39:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k2SNdTxW024015;
	Tue, 28 Mar 2006 23:39:29 GMT
	(envelope-from nobody)
Message-Id: <200603282339.k2SNdTxW024015@www.freebsd.org>
Date: Tue, 28 Mar 2006 23:39:29 GMT
From: Jos Backus <jos@catnook.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Incorrect example in wordexp(3) manpage
X-Send-Pr-Version: www-2.3

>Number:         95059
>Category:       docs
>Synopsis:       [patch] Incorrect example in wordexp(3) manpage
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ceri
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 29 00:10:13 GMT 2006
>Closed-Date:    Sat Oct 07 15:07:58 GMT 2006
>Last-Modified:  Sat Oct 07 15:07:58 GMT 2006
>Originator:     Jos Backus
>Release:        -current
>Organization:
>Environment:
FreeBSD lizzy.catnook.local 7.0-CURRENT FreeBSD 7.0-CURRENT #20: Sun Mar 19 17:20:05 PST 2006     root@lizzy.catnook.local:/usr/obj/usr/src/sys/LIZZY  i386
>Description:
The wordexp(3) manpage has an incorrect example: it uses pointer dereferencing whereas it should simply be accessing structure members:

lizzy:/tmp% cat we.c
#include <wordexp.h>

int
main(int argc, char **argv)
{
    wordexp_t we;

    wordexp("${EDITOR:-vi} *.c /etc/motd", &we, 0);
    execvp(we->we_wordv[0], we->we_wordv);
    exit(0);
}
lizzy:/tmp% lizzy:/tmp% make we  
cc -O2 -fno-strict-aliasing -pipe    we.c  -o we
we.c: In function `main':
we.c:9: error: invalid type argument of `->'
we.c:9: error: invalid type argument of `->'
*** Error code 1

Stop in /tmp.
lizzy:/tmp% 


>How-To-Repeat:

>Fix:
Patch the manpage:

--- wordexp.3.orig      Tue Mar 28 15:36:44 2006
+++ wordexp.3   Tue Mar 28 15:37:15 2006
@@ -167,7 +167,7 @@
 wordexp_t we;
 
 wordexp("${EDITOR:-vi} *.c /etc/motd", &we, 0);
-execvp(we->we_wordv[0], we->we_wordv);
+execvp(we.we_wordv[0], we.we_wordv);
 .Ed
 .Sh DIAGNOSTICS
 Diagnostic messages from the shell are written to the standard error output
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: ceri 
State-Changed-When: Tue Apr 18 21:37:42 UTC 2006 
State-Changed-Why:  
Patched in -HEAD; thanks. 


Responsible-Changed-From-To: freebsd-doc->ceri 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Tue Apr 18 21:37:42 UTC 2006 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=95059 
State-Changed-From-To: patched->closed 
State-Changed-By: ceri 
State-Changed-When: Sat Oct 7 15:07:31 UTC 2006 
State-Changed-Why:  
MFC'd to RELENG_6, apologies for forgetting this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=95059 
>Unformatted:
