From dunstan@freebsd.czest.pl  Tue Dec  6 18:58:47 2005
Return-Path: <dunstan@freebsd.czest.pl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 679AF16A426
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Dec 2005 18:58:47 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3064E43D64
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Dec 2005 18:58:44 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id jB6J0jPx071238
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 6 Dec 2005 19:00:45 GMT
	(envelope-from dunstan@freebsd.czest.pl)
Received: (from dunstan@localhost)
	by freebsd.czest.pl (8.13.4/8.12.9/Submit) id jB6J0jtP071237;
	Tue, 6 Dec 2005 19:00:45 GMT
	(envelope-from dunstan)
Message-Id: <200512061900.jB6J0jtP071237@freebsd.czest.pl>
Date: Tue, 6 Dec 2005 19:00:45 GMT
From: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
Reply-To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: acpi.4 should mention that ACPI_DEBUG depends on DDB.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         90042
>Category:       docs
>Synopsis:       [patch] acpi(4) should mention that ACPI_DEBUG depends on DDB.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wkoszek
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 06 19:00:16 GMT 2005
>Closed-Date:    Wed Mar 01 17:03:44 GMT 2006
>Last-Modified:  Wed Mar 01 17:03:44 GMT 2006
>Originator:     Wojciech A. Koszek
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD laptop.freebsd.czest.pl 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Tue Dec 6 19:19:23 CET 2005 root@laptop.freebsd.czest.pl:/usr/obj/usr/src/sys/ACPITEST i386


>Description:
Please commit this patch or similar, since it must be documented somewhere
in basesystem.
>How-To-Repeat:
>Fix:

http://freebsd.czest.pl/dunstan/FreeBSD/diff.0.acpi.4

--- acpi.4.diff begins here ---
(c) 2005 <Wojciech A. Koszek dunstan^freebsd.czest.pl>

Patch against FreeBSD 7.0-CURRENT, kern.osreldate: 700008.

diff -upr /usr/src/share/man/man4/acpi.4 src/share/man/man4/acpi.4
--- /usr/src/share/man/man4/acpi.4	Fri Jul 15 19:35:25 2005
+++ src/share/man/man4/acpi.4	Tue Dec  6 19:45:34 2005
@@ -35,6 +35,7 @@
 .Cd "device acpi"
 .Pp
 .Cd "options ACPI_DEBUG"
+.Cd "options DDB"
 .Sh DESCRIPTION
 The
 .Nm
@@ -252,7 +253,9 @@ The object and all of its children will 
 bus/children scan of the namespace.
 The ACPI CA code will still know about the avoided region.
 .Sh DEBUGGING OUTPUT
-To enable debugging output,
+To enable debugging output, your kernel must be compiled with
+.Cd "options DDB"
+and
 .Nm
 must be compiled with
 .Cd "options ACPI_DEBUG" .
--- acpi.4.diff ends here ---

>Release-Note:
>Audit-Trail:

From: Giorgos Keramidas <keramida@freebsd.org>
To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
Cc: bug-followup@freebsd.org
Subject: Re: docs/90042: acpi.4 should mention that ACPI_DEBUG depends on DDB.
Date: Tue, 28 Feb 2006 14:18:42 +0200

 On 2005-12-06 19:00, "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> wrote:
 
 > System: FreeBSD laptop.freebsd.czest.pl 7.0-CURRENT FreeBSD 7.0-CURRENT #0: \
 > Tue Dec 6 19:19:23 CET 2005 root@laptop.freebsd.czest.pl:/usr/obj/usr/src/sys/ACPITEST i386
 
 > Please commit this patch or similar, since it must be documented somewhere
 > in basesystem.
 
 > diff -upr /usr/src/share/man/man4/acpi.4 src/share/man/man4/acpi.4
 > --- /usr/src/share/man/man4/acpi.4	Fri Jul 15 19:35:25 2005
 > +++ src/share/man/man4/acpi.4	Tue Dec  6 19:45:34 2005
 > @@ -35,6 +35,7 @@
 >  .Cd "device acpi"
 >  .Pp
 >  .Cd "options ACPI_DEBUG"
 > +.Cd "options DDB"
 
 Is "DDB" really necessary though?  I thought that ACPI_DEBUG only controls
 the amount of debugging messages printed to the system console; with or
 without a kernel debugger.
 

From: "Wojciech A. Koszek" <wkoszek@freebsd.org>
To: Giorgos Keramidas <keramida@freebsd.org>
Cc: bug-followup@freebsd.org, njl@freebsd.org
Subject: Re: docs/90042: acpi.4 should mention that ACPI_DEBUG depends on DDB.
Date: Tue, 28 Feb 2006 19:32:36 +0100

 On wto, lut 28, 2006 at 02:18:42 +0200, Giorgos Keramidas wrote:
 > To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
 > Cc: bug-followup@freebsd.org
 > From: Giorgos Keramidas <keramida@freebsd.org>
 > Date: Tue, 28 Feb 2006 14:18:42 +0200
 > Subject: Re: docs/90042: acpi.4 should mention that ACPI_DEBUG depends on DDB.
 > 
 > On 2005-12-06 19:00, "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> wrote:
 > 
 >> System: FreeBSD laptop.freebsd.czest.pl 7.0-CURRENT FreeBSD 7.0-CURRENT #0: \
 >> Tue Dec 6 19:19:23 CET 2005 root@laptop.freebsd.czest.pl:/usr/obj/usr/src/sys/ACPITEST i386
 > 
 >> Please commit this patch or similar, since it must be documented somewhere
 >> in basesystem.
 > 
 >> diff -upr /usr/src/share/man/man4/acpi.4 src/share/man/man4/acpi.4
 >> --- /usr/src/share/man/man4/acpi.4	Fri Jul 15 19:35:25 2005
 >> +++ src/share/man/man4/acpi.4	Tue Dec  6 19:45:34 2005
 >> @@ -35,6 +35,7 @@
 >>  .Cd "device acpi"
 >>  .Pp
 >>  .Cd "options ACPI_DEBUG"
 >> +.Cd "options DDB"
 > 
 > Is "DDB" really necessary though?  I thought that ACPI_DEBUG only controls
 > the amount of debugging messages printed to the system console; with or
 > without a kernel debugger.
 
 Giorgos,
 
 You're right. Although this report is faked, problem reported here is quite different --
 with ACPI_DEBUG but without DDB, produced acpi.ko has unresolved symbol:
 AcpiDmDumpMethodInfo. Some #ifdef's are probably missing.
 
 cognet@ suggested to let njl@ know about it. Thus, I'm putting him in CC.
 Once this bug is fixed, I'll close my PR.
 
 Thanks,
 -- 
 Wojciech A. Koszek
 wkoszek@FreeBSD.org
 http://FreeBSD.czest.pl/dunstan/

From: Nate Lawson <nate@root.org>
To: Giorgos Keramidas <keramida@freebsd.org>, bug-followup@freebsd.org,
        njl@freebsd.org
Cc:  
Subject: Re: docs/90042: acpi.4 should mention that ACPI_DEBUG depends on
 DDB.
Date: Tue, 28 Feb 2006 13:08:42 -0800

 Wojciech A. Koszek wrote:
 > On wto, lut 28, 2006 at 02:18:42 +0200, Giorgos Keramidas wrote:
 >> To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
 >> Cc: bug-followup@freebsd.org
 >> From: Giorgos Keramidas <keramida@freebsd.org>
 >> Date: Tue, 28 Feb 2006 14:18:42 +0200
 >> Subject: Re: docs/90042: acpi.4 should mention that ACPI_DEBUG depends on DDB.
 >>
 >> On 2005-12-06 19:00, "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> wrote:
 >>
 >>> System: FreeBSD laptop.freebsd.czest.pl 7.0-CURRENT FreeBSD 7.0-CURRENT #0: \
 >>> Tue Dec 6 19:19:23 CET 2005 root@laptop.freebsd.czest.pl:/usr/obj/usr/src/sys/ACPITEST i386
 >>> Please commit this patch or similar, since it must be documented somewhere
 >>> in basesystem.
 >>> diff -upr /usr/src/share/man/man4/acpi.4 src/share/man/man4/acpi.4
 >>> --- /usr/src/share/man/man4/acpi.4	Fri Jul 15 19:35:25 2005
 >>> +++ src/share/man/man4/acpi.4	Tue Dec  6 19:45:34 2005
 >>> @@ -35,6 +35,7 @@
 >>>  .Cd "device acpi"
 >>>  .Pp
 >>>  .Cd "options ACPI_DEBUG"
 >>> +.Cd "options DDB"
 >> Is "DDB" really necessary though?  I thought that ACPI_DEBUG only controls
 >> the amount of debugging messages printed to the system console; with or
 >> without a kernel debugger.
 > 
 > Giorgos,
 > 
 > You're right. Although this report is faked, problem reported here is quite different --
 > with ACPI_DEBUG but without DDB, produced acpi.ko has unresolved symbol:
 > AcpiDmDumpMethodInfo. Some #ifdef's are probably missing.
 > 
 > cognet@ suggested to let njl@ know about it. Thus, I'm putting him in CC.
 > Once this bug is fixed, I'll close my PR.
 
 ACPI has a built-in debugger when ACPI_DEBUG is defined.  You do need 
 options DDB when compiling with it.  I think the manpage update is fine.
 
 -- 
 Nate
Responsible-Changed-From-To: freebsd-doc->wkoszek 
Responsible-Changed-By: wkoszek 
Responsible-Changed-When: Wed Mar 1 16:54:15 UTC 2006 
Responsible-Changed-Why:  
Take this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90042 
State-Changed-From-To: open->closed 
State-Changed-By: wkoszek 
State-Changed-When: Wed Mar 1 17:01:42 UTC 2006 
State-Changed-Why:  
Fix was commited to -HEAD. I'm hoping to see it MFCed after 3 days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90042 
>Unformatted:
