From riggs@riggiland.dyndns.org  Tue Aug 23 10:14:06 2005
Return-Path: <riggs@riggiland.dyndns.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 015AE16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Aug 2005 10:14:06 +0000 (GMT)
	(envelope-from riggs@riggiland.dyndns.org)
Received: from riggiland.dyndns.org (ppp-82-135-0-234.mnet-online.de [82.135.0.234])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 417C243D46
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Aug 2005 10:14:04 +0000 (GMT)
	(envelope-from riggs@riggiland.dyndns.org)
Received: from riggiland.dyndns.org (localhost [127.0.0.1])
	by riggiland.dyndns.org (8.13.3/8.13.3) with ESMTP id j7NAE0dE072366
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Aug 2005 12:14:02 +0200 (CEST)
	(envelope-from riggs@riggiland.dyndns.org)
Received: (from riggs@localhost)
	by riggiland.dyndns.org (8.13.3/8.13.3/Submit) id j7NAE0sU072365;
	Tue, 23 Aug 2005 12:14:00 +0200 (CEST)
	(envelope-from riggs)
Message-Id: <200508231014.j7NAE0sU072365@riggiland.dyndns.org>
Date: Tue, 23 Aug 2005 12:14:00 +0200 (CEST)
From: "Thomas E. Zander" <riggs@rrr.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Missing icmp related abbreviations for pf.conf(5) in icmp(4)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         85243
>Category:       docs
>Synopsis:       Missing icmp related abbreviations for pf.conf(5) in icmp(4)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bms
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 23 10:20:23 GMT 2005
>Closed-Date:    Sat Feb 10 12:02:06 GMT 2007
>Last-Modified:  Sat Feb 10 12:10:06 GMT 2007
>Originator:     Thomas E. Zander
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
FreeBSD 5.4-STABLE #7: Tue Aug 16 10:51:31 CEST 2005     root@marvin.riggiland.au:/usr/obj/usr/src/sys/MARVIN  i386
>Description:
According to the manpage pf.conf(5), rules may contain icmp-types
and/or codes by a name, for example somethig like
pass out inet proto icmp all icmp-type echoreq

Further it says "Text names for ICMP types and codes are listed in
icmp(4) and icmp6(4)."

While this is true for icmp6(4), the manpage icmp(4) lacks the
information.

>How-To-Repeat:
>Fix:

OpenBSD's icmp(4) manpage contains the textnames for icmp types
and codes which can be used by pf. Merging the tables containing
these abbreviations into FreeBSD's icmp(4) manpage should do well.
>Release-Note:
>Audit-Trail:

From: Daniel Gerzo <danger@rulez.sk>
To: bug-followup@FreeBSD.org, riggs@rrr.de
Cc:  
Subject: Re: docs/85243: Missing icmp related abbreviations for pf.conf(5) in icmp(4)
Date: Mon, 2 Jan 2006 01:28:29 +0100

 --qMm9M+Fa2AknHoGS
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Hello,
 
    Here is diff with information obtained from OpenBSD.
 
    slightly discussed with mlaier@ :)
    
 -- 
 Sincerely,
    Daniel Gerzo
 
 --qMm9M+Fa2AknHoGS
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="icmp.4.diff"
 
 --- icmp.4.orig	Fri Dec 30 15:27:16 2005
 +++ icmp.4	Fri Dec 30 16:08:48 2005
 @@ -138,6 +138,75 @@
  which are not directly addressed to us.
  By default continue with normal source selection.
  .El
 +.Ss Types
 +ICMP messages are classified according to the type and code fields
 +present in the ICMP header.  The abbreviations for the types and codes
 +may be used in rules in 
 +.Xr pf.conf 5 .
 +The following types are defined:
 +.Bl -column x xxxxxxxxxxxx -offset indent
 +.It Sy Num Ta Sy Abbrev. Ta Sy Description
 +.It 0 Ta echorep Ta "Echo reply"
 +.It 3 Ta unreach Ta "Destination unreachable"
 +.It 4 Ta squench Ta "Packet loss, slow down"
 +.It 5 Ta redir Ta "Shorter route exists"
 +.It 6 Ta althost Ta "Alternate host address"
 +.It 8 Ta echoreq Ta "Echo request"
 +.It 9 Ta routeradv Ta "Router advertisement"
 +.It 10 Ta routersol Ta "Router solicitation"
 +.It 11 Ta timex Ta "Time exceeded"
 +.It 12 Ta paramprob Ta "Invalid IP header"
 +.It 13 Ta timereq Ta "Timestamp request"
 +.It 14 Ta timerep Ta "Timestamp reply"
 +.It 15 Ta inforeq Ta "Information request"
 +.It 16 Ta inforep Ta "Information reply"
 +.It 17 Ta maskreq Ta "Address mask request"
 +.It 18 Ta maskrep Ta "Address mask reply"
 +.It 30 Ta trace Ta Traceroute
 +.It 31 Ta dataconv Ta "Data conversion problem"
 +.It 32 Ta mobredir Ta "Mobile host redirection"
 +.It 33 Ta ipv6-where Ta "IPv6 where-are-you"
 +.It 34 Ta ipv6-here Ta "IPv6 i-am-here"
 +.It 35 Ta mobregreq Ta "Mobile registration request"
 +.It 36 Ta mobregrep Ta "Mobile registration reply"
 +.It 39 Ta skip Ta SKIP
 +.It 40 Ta photuris Ta Photuris
 +.El
 +.Pp
 +The following codes are defined:
 +.Bl -column x xxxxxxxxxxxx xxxxxxxx -offset indent
 +.It Sy Num Ta Sy Abbrev. Ta Sy Type Ta Sy Description
 +.It 0 Ta net-unr Ta unreach Ta "Network unreachable"
 +.It 1 Ta host-unr Ta unreach Ta "Host unreachable"
 +.It 2 Ta proto-unr Ta unreach Ta "Protocol unreachable"
 +.It 3 Ta port-unr Ta unreach Ta "Port unreachable"
 +.It 4 Ta needfrag Ta unreach Ta "Fragmentation needed but DF bit set"
 +.It 5 Ta srcfail Ta unreach Ta "Source routing failed"
 +.It 6 Ta net-unk Ta unreach Ta "Network unknown"
 +.It 7 Ta host-unk Ta unreach Ta "Host unknown"
 +.It 8 Ta isolate Ta unreach Ta "Host isolated"
 +.It 9 Ta net-prohib Ta unreach Ta "Network administratively prohibited"
 +.It 10 Ta host-prohib Ta unreach Ta "Host administratively prohibited"
 +.It 11 Ta net-tos Ta unreach Ta "Invalid TOS for network"
 +.It 12 Ta host-tos Ta unreach Ta "Invalid TOS for host"
 +.It 13 Ta filter-prohib Ta unreach Ta "Prohibited access"
 +.It 14 Ta host-preced Ta unreach Ta "Precedence violation"
 +.It 15 Ta cutoff-preced Ta unreach Ta "Precedence cutoff"
 +.It 0 Ta redir-net Ta redir Ta "Shorter route for network"
 +.It 1 Ta redir-host Ta redir Ta "Shorter route for host"
 +.It 2 Ta redir-tos-net Ta redir Ta "Shorter route for TOS and network"
 +.It 3 Ta redir-tos-host Ta redir Ta "Shorter route for TOS and host"
 +.It 0 Ta normal-adv Ta routeradv Ta "Normal advertisement"
 +.It 16 Ta common-adv Ta routeradv Ta "Selective advertisement"
 +.It 0 Ta transit Ta timex Ta "Time exceeded in transit"
 +.It 1 Ta reassemb Ta timex Ta "Time exceeded in reassembly"
 +.It 0 Ta badhead Ta paramprob Ta "Invalid option pointer"
 +.It 1 Ta optmiss Ta paramprob Ta "Missing option"
 +.It 2 Ta badlen Ta paramprob Ta "Invalid length"
 +.It 1 Ta unknown-ind Ta photuris Ta "Unknown security index"
 +.It 2 Ta auth-fail Ta photuris Ta "Authentication failed"
 +.It 3 Ta decrypt-fail Ta photuris Ta "Decryption failed"
 +.El
  .Sh ERRORS
  A socket operation may fail with one of the following errors returned:
  .Bl -tag -width Er
 
 --qMm9M+Fa2AknHoGS--
Responsible-Changed-From-To: freebsd-doc->bms 
Responsible-Changed-By: bms 
Responsible-Changed-When: Fri Feb 9 02:23:32 UTC 2007 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85243 
State-Changed-From-To: open->patched 
State-Changed-By: bms 
State-Changed-When: Fri Feb 9 12:30:32 UTC 2007 
State-Changed-Why:  
committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85243 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/85243: commit references a PR
Date: Fri,  9 Feb 2007 12:30:35 +0000 (UTC)

 bms         2007-02-09 12:30:17 UTC
 
   FreeBSD src repository
 
   Modified files:
     share/man/man4       icmp.4 
   Log:
   Add lists of ICMP types and codes for user and developer reference.
   Cross-reference pf.conf(5) which is able to use these definitions.
   
   PR:             85243
   Submitted by:   Daniel Gerzo
   Obtained from:  OpenBSD
   MFC after:      1 day
   
   Revision  Changes    Path
   1.20      +72 -2     src/share/man/man4/icmp.4
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: bms 
State-Changed-When: Sat Feb 10 12:01:49 UTC 2007 
State-Changed-Why:  
MFC 

http://www.freebsd.org/cgi/query-pr.cgi?pr=85243 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/85243: commit references a PR
Date: Sat, 10 Feb 2007 12:01:47 +0000 (UTC)

 bms         2007-02-10 12:01:39 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     share/man/man4       icmp.4 
   Log:
   MFC rev 1.20:
     Add lists of ICMP types and codes for user and developer reference.
     Cross-reference pf.conf(5) which is able to use these definitions.
   
   PR:             85243
   Submitted by:   Daniel Gerzo
   Obtained from:  OpenBSD
   
   Revision  Changes    Path
   1.16.2.1  +72 -2     src/share/man/man4/icmp.4
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
